GitHub/divkit
1
0
Fork 0
mirror of https://github.com/divkit/divkit.git synced 2026-06-06 20:07:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Transition properties without id warnings

Browse Source 
commit_hash:0a9770ea52721d60fae24e6bf6052a4f760051e0
This commit is contained in:
4eb0da
2025-02-20 12:57:26 +03:00
parent ff0c03f067
commit 830488ad53
1 changed files with 40 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/web/divkit/src/components/utilities/Outer.svelte
+40 -19
View File
@@ -21,6 +21,9 @@
bottom: 'end',
baseline: 'baseline'
};
const stateChangeErrorMessage = (prop: string) =>
`The component id with the "${prop}" property for state change is missing. Either specify the id, or specify the "transition_trigger" property without "state_change" value.`;
</script>
<script lang="ts">
@@ -211,7 +214,7 @@
jsonTransitionTriggers = componentContext.fakeElement ?
[] :
(componentContext.json.transition_triggers || ['state_change', 'visibility_change']);
hasStateChangeTrigger = Boolean(jsonTransitionTriggers.indexOf('state_change') !== -1 && componentContext.id);
hasStateChangeTrigger = Boolean(jsonTransitionTriggers.indexOf('state_change') !== -1);
hasVisibilityChangeTrigger = Boolean(jsonTransitionTriggers.indexOf('visibility_change') !== -1);
if (currentNode) {
@@ -659,7 +662,7 @@
$: {
stateChangingInProgress = undefined;
if (hasStateChangeTrigger && componentContext.json.transition_in && rootCtx.isRunning('stateChange')) {
if (hasStateChangeTrigger && componentContext.id && componentContext.json.transition_in && rootCtx.isRunning('stateChange')) {
stateChangingInProgress = true;
}
}
@@ -667,6 +670,7 @@
transitionChangeInProgress = undefined;
if (
hasStateChangeTrigger &&
componentContext.id &&
rootCtx.isRunning('stateChange') && stateCtx.hasTransitionChange(componentContext.id)
) {
transitionChangeInProgress = true;
@@ -983,27 +987,44 @@
currentNode = node;
if (hasStateChangeTrigger && componentContext.json.transition_in) {
stateCtx.registerChildWithTransitionIn(
componentContext.json as DivBaseData,
componentContext,
componentContext.json.transition_in,
node
).then(() => {
stateChangingInProgress = false;
}).catch(e => {
stateChangingInProgress = false;
throw e;
});
if (componentContext.id) {
stateCtx.registerChildWithTransitionIn(
componentContext.json as DivBaseData,
componentContext,
componentContext.json.transition_in,
node
).then(() => {
stateChangingInProgress = false;
}).catch(e => {
stateChangingInProgress = false;
throw e;
});
} else {
componentContext.logError(wrapError(new Error(stateChangeErrorMessage('transition_in')), {
level: 'warn'
}));
}
}
if (hasStateChangeTrigger && componentContext.json.transition_out) {
stateCtx.registerChildWithTransitionOut(
componentContext.json as DivBaseData,
componentContext,
componentContext.json.transition_out,
node
);
if (componentContext.id) {
stateCtx.registerChildWithTransitionOut(
componentContext.json as DivBaseData,
componentContext,
componentContext.json.transition_out,
node
);
} else {
componentContext.logError(wrapError(new Error(stateChangeErrorMessage('transition_out')), {
level: 'warn'
}));
}
}
if (!componentContext.fakeElement) {
if (componentContext.json.transition_change && !componentContext.id) {
componentContext.logError(wrapError(new Error(stateChangeErrorMessage('transition_change')), {
level: 'warn'
}));
}
stateCtx.registerChildWithTransitionChange(
componentContext.json as DivBaseData,
componentContext,