GitHub/cyberduck
1
0
Fork 0
mirror of https://github.com/iterate-ch/cyberduck.git synced 2026-05-26 19:10:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cache list of certificates expensive to retrieve.

Browse Source
This commit is contained in:
David Kocher
2026-05-15 11:00:00 +02:00
parent f144ba74ed
commit 491e5f9154
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osx/src/main/java/ch/cyberduck/ui/cocoa/controller/BookmarkController.java
+4 -2
View File
@@ -597,14 +597,16 @@ public abstract class BookmarkController extends SheetController implements NSTa
this.certificatePopup.setTarget(this.id());
final Selector action = Foundation.selector("certificateSelectionChanged:");
this.certificatePopup.setAction(action);
// List of certificates with private key
final List<String> list = new KeychainX509KeyManager(new DisabledCertificateIdentityCallback(), bookmark,
CertificateStoreFactory.get()).list();
this.addObserver(bookmark -> {
certificatePopup.setEnabled(options.certificate);
certificatePopup.removeAllItems();
certificatePopup.addItemWithTitle(LocaleFactory.localizedString("None"));
if(options.certificate) {
certificatePopup.menu().addItem(NSMenuItem.separatorItem());
for(String certificate : new KeychainX509KeyManager(new DisabledCertificateIdentityCallback(), bookmark,
CertificateStoreFactory.get()).list()) {
for(String certificate : list) {
certificatePopup.addItemWithTitle(certificate);
certificatePopup.lastItem().setRepresentedObject(certificate);
}