GitHub/coturn
1
0
Fork 0
mirror of https://github.com/coturn/coturn.git synced 2026-05-12 09:40:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Prometheus metrics response leak (#1900)

Browse Source 
Fix memory leak introduced in #1853

Resolved #1898
This commit is contained in:
Pavel Punsky
2026-05-07 22:22:33 -07:00
committed by GitHub
parent 326816a92a
commit 238c311f05
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/relay/prom_server.c
+3 -9
View File
@@ -89,7 +89,6 @@ static MHD_RESULT promhttp_handler(void *cls, struct MHD_Connection *connection,
(void)con_cls;
char *body = "not found";
char *owned_body = NULL;
enum MHD_ResponseMemoryMode mode = MHD_RESPMEM_PERSISTENT;
unsigned int status = MHD_HTTP_NOT_FOUND;
@@ -97,15 +96,10 @@ static MHD_RESULT promhttp_handler(void *cls, struct MHD_Connection *connection,
status = MHD_HTTP_METHOD_NOT_ALLOWED;
body = "method not allowed";
} else if (strcmp(url, turn_params.prometheus_path) == 0) {
const char *prom_body = prom_collector_registry_bridge(PROM_COLLECTOR_REGISTRY_DEFAULT);
if (prom_body == NULL) {
body = (char *)prom_collector_registry_bridge(PROM_COLLECTOR_REGISTRY_DEFAULT);
if (body == NULL) {
return MHD_NO;
}
owned_body = strdup(prom_body);
if (owned_body == NULL) {
return MHD_NO;
}
body = owned_body;
mode = MHD_RESPMEM_MUST_FREE;
status = MHD_HTTP_OK;
} else if (strcmp(url, "/") == 0) {
@@ -118,7 +112,7 @@ static MHD_RESULT promhttp_handler(void *cls, struct MHD_Connection *connection,
struct MHD_Response *response = MHD_create_response_from_buffer(strlen(body), body, mode);
if (response == NULL) {
if (mode == MHD_RESPMEM_MUST_FREE) {
free(owned_body);
free(body);
}
ret = MHD_NO;
} else {