GitHub/XcodeGen
1
0
Fork 0
mirror of https://github.com/yonaskolb/XcodeGen.git synced 2026-03-18 20:02:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add improvement of performance in SpecValidation on validateSettings (#1522)

Browse Source
This commit is contained in:
Zewu Chen
2024-12-29 01:19:06 -03:00
committed by GitHub
parent 126339f1c8
commit 681e320867
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Sources/ProjectSpec/SpecValidation.swift
+8 -5
View File
@@ -17,27 +17,30 @@ extension Project {
errors.append(.invalidSettingsGroup(group))
}
}
for config in settings.configSettings.keys {
if !configs.contains(where: { $0.name.lowercased().contains(config.lowercased()) }) {
if !options.disabledValidations.contains(.missingConfigs) {
errors.append(.invalidBuildSettingConfig(config))
}
if !configs.contains(where: { $0.name.lowercased().contains(config.lowercased()) }),
!options.disabledValidations.contains(.missingConfigs) {
errors.append(.invalidBuildSettingConfig(config))
}
}
if settings.buildSettings.count == configs.count {
var allConfigs = true
for buildSetting in settings.buildSettings.keys {
outerLoop: for buildSetting in settings.buildSettings.keys {
var isConfig = false
for config in configs {
if config.name.lowercased().contains(buildSetting.lowercased()) {
isConfig = true
break
}
}
if !isConfig {
allConfigs = false
break outerLoop
}
}
if allConfigs {
errors.append(.invalidPerConfigSettings)
}