Prereview cleanup

This commit is contained in:
Bartosz Polaczyk
2021-12-16 20:13:41 +01:00
parent a905cdbddc
commit df627ca374
3 changed files with 3 additions and 3 deletions
@@ -67,7 +67,7 @@ public class XCPostbuild {
let primaryGitBranch = GitBranch(repoLocation: config.primaryRepo, branch: config.primaryBranch)
let gitClient = GitClientImpl(repoRoot: config.repoRoot, primary: primaryGitBranch, shell: shellGetStdout)
let pathRemapper = try StringDependenciesRemapperFactory().build(
orderKeys: DependenciesMapping.rewrittenEnvs + config.outOfBandMappings.keys,
orderKeys: DependenciesMapping.rewrittenEnvs,
envs: env,
customMappings: config.outOfBandMappings
)
@@ -116,7 +116,7 @@ public class XCPrebuild {
let client: NetworkClient = config.disableHttpCache ? networkClient : cacheNetworkClient
let remoteNetworkClient = RemoteNetworkClientImpl(client, urlBuilder)
let pathRemapper = try StringDependenciesRemapperFactory().build(
orderKeys: DependenciesMapping.rewrittenEnvs + config.outOfBandMappings.keys,
orderKeys: DependenciesMapping.rewrittenEnvs,
envs: env,
customMappings: config.outOfBandMappings
)
@@ -103,7 +103,7 @@ class DependenciesRemapperCompositeTests: XCTestCase {
XCTAssertEqual(localPaths, ["/root/specific/file"])
}
func testRemappingBackAndForthIsIdentity() throws {
func testRemappingTwoMappingsBackAndForthIsIdentical() throws {
let remapper = DependenciesRemapperComposite([
StringDependenciesRemapper(mappings: [StringDependenciesRemapper.Mapping(generic: "$(ROOT)", local: "/root")]),
StringDependenciesRemapper(mappings: [StringDependenciesRemapper.Mapping(generic: "$(SPECIFIC)", local: "$(ROOT)/specific")])