Bug fixing

2018-10-25 17:59:13 -06:00
3 changed files with 9 additions and 2 deletions
@@ -8,7 +8,7 @@

 Pod::Spec.new do |s|
  s.name             = 'VersaPlayerOverlayContentExtension'
-  s.version          = '0.1.3'
+  s.version          = '0.1.6'
  s.summary          = 'VersaPlayer extension to enable overlay content.'
  s.description      = 'VersaPlayer extension to enable overlay content functionality.'
  s.homepage         = 'https://github.com/josejuanqm/VersaPlayerOverlayContentExtension'
@@ -24,19 +24,21 @@ open class VersaPlayerOverlayContent: UIView {
    
    public func show(with status: VersaPlayerOverlayContentManagerPlayerStatus) {
        if shown { return } else { shown = true }
-        if shouldPausePlayerOnShow { player.pause() }
+        if shouldPausePlayerOnShow && player.isPlaying { player.pause() }
        player.overlayContentManager?.delegate?.willDisplayOverlayContentIn(player: player, content: self, status: status)
        player.controls?.behaviour.hide()
        player.showOverlay(content: self)
    }
    
    public func hide(with status: VersaPlayerOverlayContentManagerPlayerStatus) {
+        player.overlayContentManager?.isShowing = false
        player.overlayContentManager?.delegate?.willRemoveOverlayContentIn(player: player, content: self, status: status)
        player.controls?.behaviour.show()
        player.hideOverlay(content: self)
    }
    
    @IBAction public func hide() {
+        player.overlayContentManager?.isShowing = false
        player.overlayContentManager?.delegate?.willRemoveOverlayContentIn(player: player, content: self, status: player.overlayContentManager?.status ?? .none)
        player.controls?.behaviour.show()
        player.hideOverlay(content: self)
@@ -16,6 +16,7 @@ open class VersaPlayerOverlayContentManager: VersaPlayerExtension {

    public var delegate: VersaPlayerOverlayContentManagerDelegate? = nil
    public var status: VersaPlayerOverlayContentManagerPlayerStatus? = nil
+    internal var isShowing: Bool = false
    
    public init(with player: VersaPlayer, and delegate: VersaPlayerOverlayContentManagerDelegate) {
        super.init(with: player)
@@ -48,10 +49,14 @@ open class VersaPlayerOverlayContentManager: VersaPlayerExtension {
    }
    
    public func showIfNeededWith(status: VersaPlayerOverlayContentManagerPlayerStatus) {
+        if isShowing {
+            return
+        }
        if (delegate?.shouldShowOverlayContentForPlayer(player: player, status: status) ?? false) {
            if let view = delegate?.viewForOverlayContentIn(player: player, status: status) {
                view.player = player
                delegate?.willDisplayOverlayContentIn(player: player, content: view, status: status)
+                isShowing = true
                view.show(with: status)
            }
        }