mirror of
https://github.com/TextureGroup/Texture.git
synced 2026-04-07 19:17:39 +00:00
Andy Finnell
be0b74b4e2
## Summary For collection views, we do not currently check for batch fetching on scroll. This appears to be a bug, as `scrollViewDidScroll:` does call `_checkForBatchFetching`, and [the commit that added it states it's trying to check on each scroll](https://github.com/TextureGroup/Texture/commit/df497b82c286771658a0ef0826945c716baaa783). Unfortunately, `_checkForBatchFetching` checks for `isTracking` and `isDragging` first and returns if either are `YES`. Since we're in a scroll, they are `YES`. So the call is effectively a no-op. This bug has been around for 9 years and I'm unsure of the performance implications of turning the batch fetching check on for each scroll tick. Therefore, put the fix behind an experiment feature flag _and_ only call it on the first scroll tick for the scroll session, instead of every scroll tick. Finally, I moved the check after the delegate call, in case the delegate has logic in it to turn on or off the batch fetching. ## Test plan Ran the app and manually tested batching getting called or not. Also ran `build.sh tests`.
48 lines
2.7 KiB
Objective-C
48 lines
2.7 KiB
Objective-C
//
|
|
// ASExperimentalFeatures.h
|
|
// Texture
|
|
//
|
|
// Copyright (c) Pinterest, Inc. All rights reserved.
|
|
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
|
|
#import <Foundation/Foundation.h>
|
|
#import <AsyncDisplayKit/ASAvailability.h>
|
|
#import <AsyncDisplayKit/ASBaseDefines.h>
|
|
|
|
NS_ASSUME_NONNULL_BEGIN
|
|
|
|
/**
|
|
* A bit mask of features. Make sure to update configuration.json when you add entries.
|
|
*/
|
|
typedef NS_OPTIONS(NSUInteger, ASExperimentalFeatures) {
|
|
// If AS_ENABLE_TEXTNODE=0 or TextNode2 subspec is used this setting is a no op and ASTextNode2
|
|
// will be used in all cases
|
|
ASExperimentalTextNode = 1 << 0, // exp_text_node
|
|
ASExperimentalInterfaceStateCoalescing = 1 << 1, // exp_interface_state_coalesce
|
|
ASExperimentalLayerDefaults = 1 << 2, // exp_infer_layer_defaults
|
|
ASExperimentalCollectionTeardown = 1 << 3, // exp_collection_teardown
|
|
ASExperimentalFramesetterCache = 1 << 4, // exp_framesetter_cache
|
|
ASExperimentalSkipClearData = 1 << 5, // exp_skip_clear_data
|
|
ASExperimentalDidEnterPreloadSkipASMLayout = 1 << 6, // exp_did_enter_preload_skip_asm_layout
|
|
ASExperimentalDispatchApply = 1 << 7, // exp_dispatch_apply
|
|
ASExperimentalDrawingGlobal = 1 << 8, // exp_drawing_global
|
|
ASExperimentalOptimizeDataControllerPipeline = 1 << 9, // exp_optimize_data_controller_pipeline
|
|
ASExperimentalDisableGlobalTextkitLock = 1 << 10, // exp_disable_global_textkit_lock
|
|
ASExperimentalMainThreadOnlyDataController = 1 << 11, // exp_main_thread_only_data_controller
|
|
ASExperimentalRangeUpdateOnChangesetUpdate = 1 << 12, // exp_range_update_on_changeset_update
|
|
ASExperimentalNoTextRendererCache = 1 << 13, // exp_no_text_renderer_cache
|
|
ASExperimentalLockTextRendererCache = 1 << 14, // exp_lock_text_renderer_cache
|
|
ASExperimentalHierarchyDisplayDidFinishIsRecursive = 1 << 15, // exp_hierarchy_display_did_finish_is_recursive
|
|
ASExperimentalCheckBatchFetchingOnScroll = 1 << 16, // exp_check_batch_fetching_on_scroll
|
|
ASExperimentalFeatureAll = 0xFFFFFFFF
|
|
};
|
|
|
|
/// Convert flags -> name array.
|
|
ASDK_EXTERN NSArray<NSString *> *ASExperimentalFeaturesGetNames(ASExperimentalFeatures flags);
|
|
|
|
/// Convert name array -> flags.
|
|
ASDK_EXTERN ASExperimentalFeatures ASExperimentalFeaturesFromArray(NSArray<NSString *> *array);
|
|
|
|
NS_ASSUME_NONNULL_END
|