Scott Goodson
5c0c7d5345
Bump podspec version for AsyncDisplayKit 1.2.3
2015-07-25 22:39:28 -07:00
Ethan Nagel
357d02fee6
Attempt to fix travis by specifying cocoapods 0.37.2 explicitly
2015-07-25 22:07:27 -07:00
Ethan Nagel
d004b067e2
Attempt to fix travis by specifying cocoapods 0.37.2 explicitly
2015-07-25 22:07:21 -07:00
Scott Goodson
5777582708
Implement warning assertion for supplementary views in ASCollectionView.
...
Make sure ASTableViewStressTest passes. It was sometimes testing a scenario UITableView itself doesn't support.
2015-07-25 22:06:30 -07:00
Ethan Nagel
55af2a7255
short-circuit editing calls after the asyncDataSource has been set to nil (ASCollectionView)
2015-07-21 10:55:00 -07:00
Ethan Nagel
f98c8cded2
Update Podfile.lock to match earlier changes to Podfile.
2015-07-21 10:37:47 -07:00
Ethan Nagel
a744ebd276
PR Feedback: Require main thread for all edit commands, various cleanup.
2015-07-21 10:37:21 -07:00
Ethan Nagel
7b2fa8f524
Add support automatically adjusting the content offset to UITableView as well as support for performing endUpdates with no animations. Additionally, there are critical bug fixes for ASDataController (begin/end updates delegates not called in correct order) and ASRangeController (failure to fully refresh internal state when inserts or delete are made.)
2015-07-21 10:28:56 -07:00
Ethan Nagel
94608e992a
Wait to begin thrashing until we have completed reloading the data so we aren't trying to do both operations concurrently.
2015-07-21 10:23:28 -07:00
Ethan Nagel
e9de3b395a
Don't abuse the CI servers so much. Note - With this configuration we will often pass with a known race issue we currently have. Making ASTableViewStressTest more interesting so we can reliably reproduce the issue there.
2015-07-21 10:23:21 -07:00
Ethan Nagel
93a8058389
Update ASTableView test to be more random and more rigorous.
2015-07-21 10:23:14 -07:00
Ethan Nagel
1f8aad633f
short-circuit editing calls after the asyncDataSource has been set to nil (ASTableView)
2015-07-21 10:23:02 -07:00
Ryan Fitzgerald
ce28451323
releasing downloaded image when multiplex image node exits render range
2015-07-21 10:21:21 -07:00
Huy Nguyen
d1260562de
[appledoc] Fix appledoc warnings. ( #553 )
2015-07-21 10:21:08 -07:00
Ethan Nagel
4d7dd551f2
update Podfile to require FBSnapshotCase 1.8.1 because v2.0+ requires frameworks and we haven't tried enabling them yet.
2015-07-21 10:20:49 -07:00
appleguy
84b503c7ae
Merge pull request #538 from facebook/PodspecUpdate122
...
Update podspec to 1.2.2
2015-07-05 13:20:15 -07:00
Scott Goodson
3afcf33206
Update podspec to 1.2.2
2015-07-05 13:19:24 -07:00
appleguy
3f574a3306
Merge pull request #521 from jflinter/jack-uiresponder-additions
...
Add UIResponder methods to ASDisplayNode
2015-07-04 22:36:09 -07:00
appleguy
58a55f035d
Merge pull request #529 from facebook/DataControllerQueues
...
Overhaul ASDataController and extensively test ASTableView.
2015-07-04 21:06:34 -07:00
Scott Goodson
6220d65747
Property declaration tweak for odd Travis build failure (only on the Tests build).
2015-07-04 20:54:04 -07:00
Scott Goodson
8fa092fb77
Complete overhaul of ASFlowLayoutController.
...
Introduced ASIndexPath for efficient handling of index paths in C++ vectors,
while maintaining the readability of ".section" and ".row" instead of
".first" and ".second" inside of complicated business logic.
Confirmed that the working range calls are firing appropriately during
ASTableViewStressTest, including the deallocation of the rich text placeholders
provided by ASTextNode.
2015-07-04 20:22:04 -07:00
appleguy
51297088ce
Merge pull request #535 from eanagel/cell-clipsToBounds
...
Propagate ASCellNode's clipsToBounds value to the __ASTableViewCell
2015-07-01 20:11:38 -07:00
Ethan Nagel
4963a88717
Propagate ASCellNode's clipsToBounds value to the __ASTableViewCell. This helps work around a bug we are seeing in some rare cases (selected background view overlaps other cells if size of ASCellNode has changed.)
2015-06-29 21:22:55 -07:00
Scott Goodson
57465c7fd3
Overhaul ASDataController and extensively test ASTableView.
...
This diff resolves all known consistency issues with ASTableView and ASCollectionView.
It includes significantly more aggressive thrash-testing in ASTableViewStressTest,
which now passes on a variety of device and simulator configurations. It also updates
the unit tests run on every commit to ensure any regression is caught quickly.
A few of the salient changes in this diff:
- ASTableView now uses Rene's ASCollectionViewLayoutController, and actually uses a
UICollectionViewFlowLayout without any UICollectionView. This resolves an issue where
ASFlowLayoutController was generating slightly out-of-bounds indicies when programmatically
scrolling past the end of the table content. Because the custom implementation is likely
faster, I will revisit this later with profiling and possibly returning to the custom impl.
- There is now a second copy of the _nodes array maintained by ASDataController. It shares
the same node instances, but this does add some overhead to manipulating the arrays. I've
filed a task to follow up with optimization, as there are several great opportunities to
make it faster. However, I don't believe the overhead is a significant issue, and it does
guarantee correctness in even the toughest app usage scenarios.
- ASDataController no longer supports calling its delegate /before/ edit operations. No
other class was relying on this behavior, and it would be unusual for an app developer to
use ASDataController directly. However, it is possible that someone with a custom view
that integrates with ASDataController and ASRangeController could be affected by this.
- Further cleanup of organization, naming, additional comments, reduced code length
wherever possible. Overall, significantly more accessible to a new reader.
2015-06-28 18:03:45 -07:00
appleguy
8beae28b25
Merge pull request #506 from paulyoung/framework-target
...
Remove old and add new framework target.
2015-06-27 21:58:09 -07:00
appleguy
a654d880c3
Merge pull request #525 from facebook/Domain2
...
Update the identifier that AsyncDisplayKit uses to label its internal queues (2/2).
2015-06-27 12:11:35 -07:00
Scott Goodson
feba7f8ed1
Update the identifier that AsyncDisplayKit uses to label its internal queues (2/2).
2015-06-27 12:10:58 -07:00
appleguy
447159f08a
Merge pull request #524 from facebook/ASDK_Identifier_Domain
...
Update the identifier that AsyncDisplayKit uses to label its internal queues.
2015-06-27 12:08:28 -07:00
Scott Goodson
8fc79b1d4c
Update the identifier that AsyncDisplayKit uses to label its internal queues.
2015-06-27 12:07:40 -07:00
appleguy
1563c5e577
Merge pull request #523 from facebook/DataControllerSerialization
...
Clean up organization and naming of methods internal to ASDataController.
2015-06-27 11:50:43 -07:00
Scott Goodson
dc19970fe8
Clean up organization and naming of methods internal to ASDataController.
2015-06-27 11:48:55 -07:00
appleguy
a1e14e71ed
Merge pull request #522 from facebook/DataControllerAwesome
...
Clean up ASDataController for readability & API naming consistency.
2015-06-27 11:08:18 -07:00
Scott Goodson
06cfe68cbd
Clean up ASDataController for readability & API naming consistency.
2015-06-27 11:06:54 -07:00
Jack Flintermann
5889c7019e
basic unit tests
2015-06-27 03:19:52 -04:00
Jack Flintermann
8a200078bd
make ASEditableTextField properly subclass responder methods
2015-06-27 03:19:51 -04:00
Jack Flintermann
540eeec79b
move UIresponder methods out of UIView bridging category
2015-06-27 03:19:51 -04:00
Jack Flintermann
0b14d42033
add UIResponder methods to ASDisplayNode
2015-06-27 03:19:51 -04:00
Paul Young
7d464fb6b8
Merge branch 'master' into framework-target
...
Conflicts:
AsyncDisplayKit.xcodeproj/project.pbxproj
2015-06-26 23:31:43 +01:00
appleguy
da4ae469d8
Merge pull request #514 from eanagel/astableview-programmatic-scrolling-fix-v3
...
ASTableView programmatic scrolling fix w/contiguous guarantee
2015-06-26 13:18:54 -07:00
appleguy
585a70d72c
Merge pull request #511 from stripe-internal/jack-fix-podspec
...
Exclude ASDealloc2MainObject.h from main spec
2015-06-26 13:09:07 -07:00
Ethan Nagel
ae523f4fce
better logic for detecting when the pending index path is before or after the visible index paths
2015-06-25 09:53:36 -07:00
Jack Flintermann
6bf8ec5b03
exclude ASDealloc2MainObject.h from main spec
2015-06-25 10:47:10 -04:00
appleguy
71d9f210f1
Merge pull request #507 from sebreh/master
...
Include missing files in iOS Framework target
2015-06-24 15:45:35 -07:00
appleguy
3560ff98e7
Merge pull request #508 from victormayorov/master
...
Implemented UIAccessibilityIdentification for ASDisplayNode
2015-06-24 15:45:09 -07:00
Ethan Nagel
baf91b4a45
validate that _pendingVisibleIndexPath is contiguous with visibleIndexPaths before appending it. Also, always return a sorted array of NSIndexPaths
2015-06-24 13:18:12 -07:00
Ethan Nagel
0e37bff7c1
Revert to using a single NSIndexPath for the pending visible item
2015-06-24 13:13:43 -07:00
Victor Mayorov
a299a5b550
Implemented UIAccessibilityIdentification for ASDisplayNode
2015-06-24 11:03:51 -07:00
Victor Mayorov
1a7723d0c6
Merge remote-tracking branch 'AsyncDisplayKit/master'
...
Conflicts:
AsyncDisplayKit/Details/ASRangeController.mm
AsyncDisplayKitTests/ASTableViewTests.m
2015-06-24 10:19:41 -07:00
Sebastian Rehnby
c215356eb3
Include missing files in iOS Framework target
2015-06-24 15:55:50 +02:00
Paul Young
8fa6667d93
Remove old and add new framework target.
2015-06-23 23:24:55 -07:00
Scott Goodson
Ethan Nagel
Ryan Fitzgerald
Huy Nguyen
Scott Goodson
Jack Flintermann
Paul Young
Victor Mayorov
Sebastian Rehnby