Commit Graph
5092 Commits
Author SHA1 Message Date
appleguy aa9dff00de Merge pull request #2672 from facebook/AHRemoveVCFetch
[ASViewController] Remove Extra recursivelyFetchData Call
2016-11-29 10:46:22 -08:00
appleguy 7861c63a68 Merge pull request #2676 from maicki/MSRevertConstrainedSizeChanges
Revert constrainedSize changes that should have never made it in
2016-11-28 17:23:50 -08:00
Michael Schneider 52bb2a3a6e Revert constrainedSize changes that should have never made it in 2016-11-28 17:20:26 -08:00
Adlai Holler b00365ac59 Remove explicit recursivelyFetchData call from ASViewController 2016-11-28 15:34:46 -08:00
Hannah Troisi 5f9e84ce28 [Examples] fix CustomCollectionView-Swift project configs (#2671)
* fix podfile

* add Sample scheme

* remove example project workspace files

* remove use_frameworks!

* add Sample scheme

* add use_frameworks! back in

* add scrollableDirections method
2016-11-28 15:33:29 -08:00
Michael Schneider 4928af4635 [Layout Transition] Layout Transition Fixes (#2657)
* Don’t call layoutIfNeeded before starting the layout transition

* Further improvements
2016-11-28 12:57:03 -08:00
Adlai Holler a862ac230f Merge pull request #2664 from garrettmoon/enableRangeControllerMemWarning
This patch enables memory warning support on ASRangeController by def…
2016-11-28 11:30:50 -08:00
Adlai Holler 95ffbb2358 Merge pull request #2669 from facebook/IsViewLoadedMethod
Use the Method Form for UIViewController.viewLoaded – Maintains Xcode Backwards Compatibility
2016-11-28 11:28:54 -08:00
Adlai Holler 82e1c5bf0b Use the method form for UIViewController.isViewLoaded, since it is supported by Xcode 7.3.1 2016-11-28 11:12:22 -08:00
Adlai Holler 02283bd0d6 Merge pull request #2648 from maicki/MSFixASTableViewRotationGlitch
[ASTableView] Not animated for end updates if animation is already going on within ASTableView
2016-11-28 09:59:05 -08:00
Garrett Moon 04dc582a7a Rename didUpdateCurrentRangeMode to preserveCurrentRangeMode 2016-11-27 16:05:31 -08:00
Garrett Moon 62f378a9fd This patch enables memory warning support on ASRangeController by default
It also fixes a couple subtle bugs:
1. If a range controller update was in flight and you were manually setting the range
mode, you could actually clear out the range mode by calling updateCurrentRangeWithMode:
This is fixed by setting _didUpdateCurrentRange = YES if _needsRangeUpdate is YES.
2. Calling setNeedsUpdate after calling updateCurrentRangeWithMode: can cause the
current range mode to get cleared out. This is because updateCurrentRangeWithMode:
will not set _didUpdateCurrentRange if _currentRangeMode == rangeMode.
2016-11-27 15:42:07 -08:00
Rajeev Gupta 91734ea979 [Examples] CustomCollectionView in Swift3 (#2591)
* new Swift example

* removed asyncDataSource and asyncDelegate. Also using collectionNode methods instead of collectionView

* Fixing the folder structure

* Updated with @george-gw feedback. Thanks George.
2016-11-27 13:01:35 -08:00
appleguy 8d89f7074f Merge pull request #2662 from facebook/AHDrawMethodNoEscape
Add noescape Attribute to isCancelledBlock Parameters
2016-11-27 11:12:36 -08:00
Adlai Holler c205edc1b1 Merge pull request #2656 from maicki/MSHandleRootNodeViewLoadingInASViewController
[ASViewController] Trigger load view in ASViewController if node did load but not the view of the view controller
2016-11-27 10:43:42 -08:00
Adlai Holler aee2aaf40a Align the colons 2016-11-27 10:36:21 -08:00
Adlai Holler b689a59b45 Mark isCancelled block as noescape to improve the Swift import 2016-11-27 10:31:35 -08:00
Michael Schneider c178df0dbc Fix typo 2016-11-23 20:31:37 -08:00
Michael Schneider 64a316679c Trigger load view in ASViewController if node did load but not the view of the view controller 2016-11-23 20:31:37 -08:00
appleguy aefff563bd Merge pull request #2651 from facebook/PlaceholderContents
[ASDisplayNode] Create placeholders off main when possible.
2016-11-23 16:33:44 -08:00
Adlai Holler 7b71861e1f Merge pull request #2652 from ay8s/master
Update AsyncDisplayKit.podspec for 2.0-beta.2
2016-11-23 16:24:40 -08:00
Scott Goodson 3bfb437f2b [Cocoapods] Update version to 2.0-beta.2 2016-11-23 16:15:51 -08:00
Adlai Holler 97a328b83d Merge pull request #2654 from maicki/MSKittensExampleAccessViewInInit
[Examples] Never access the view property of the node in init
2016-11-23 16:10:05 -08:00
Adlai Holler 479dd6740e Merge pull request #2655 from rahul-malik/rmalik-nsurlsessionfix
Re-add NSURLSessionConfiguration support and fix crashes
2016-11-23 16:09:57 -08:00
Adlai Holler 14765a55d2 Revert "Merge pull request #2649 from facebook/AHCollectionNodeInitializer"
This reverts commit 0f620f458d, reversing
changes made to 0c65d21f8d.
2016-11-23 15:56:24 -08:00
rmalik 15f8dc572a - Fix assignment of alternativeRepresentationProvider to be the singleton
instance of ASPINRemoteImageDownloader.
- Revert "Revert "Expose internal singleton method as a class method vs instance method.""
- Fix API bug in ASCollectionNode+Beta
2016-11-23 15:51:40 -08:00
Michael Schneider 4f1d7ec064 Never access the view property of the node in init 2016-11-23 15:50:26 -08:00
Michael Schneider 1f7b838d5e Not animated for end updates if animation is already going on within ASTableView
Fix strange artifacts in ASTableView are visible when changing the device orientation or other animations are going on while calling endUpdates
2016-11-23 14:31:37 -08:00
Adlai Holler 0f620f458d Merge pull request #2649 from facebook/AHCollectionNodeInitializer
[ASCollectionNode] Modify Initialization API
2016-11-23 13:35:59 -08:00
Andrew Yates 0d092528e6 Update AsyncDisplayKit.podspec 2016-11-23 10:31:27 -08:00
Scott Goodson 1c70412868 [ASDisplayNode] Create placeholders off main when possible.
This is a fix for https://github.com/facebook/AsyncDisplayKit/issues/2620,
which is a followup to https://github.com/facebook/AsyncDisplayKit/pull/2610

This will ensure thread affinity is respected for .contents but still run
placeholderImage off-main when possible (node isn't loaded).
2016-11-22 22:29:24 -08:00
Scott Goodson 0c65d21f8d Revert "Expose internal singleton method as a class method vs instance method."
Causing crash: +[ASPINRemoteImageDownloader alternateRepresentationWithData:options:]: unrecognized selector sent to class 0x198e3d8

This reverts commit 91c06272b1.
2016-11-22 21:59:58 -08:00
appleguy b0644dba3b Merge pull request #2650 from rahul-malik/fix-nsurlsessionconfig
Expose internal singleton method as a class method vs instance method in ASPINRemoteImageDownloader
2016-11-22 18:04:58 -08:00
rmalik 91c06272b1 Expose internal singleton method as a class method vs instance method.
Currently setting an NSURLSessionConfiguration through ASPINRemoteImageManager
will crash.
2016-11-22 18:04:19 -08:00
Adlai Holler 94a0ba8635 Make the tests pass 2016-11-22 16:52:48 -08:00
Adlai Holler 04b93182cd Rejigger ASCollectionNode initializers 2016-11-22 16:49:52 -08:00
Austin Louden 60756a1da5 Fix self capture in ASCollectionNode (#2646)
* fix capture in ASCollectionNode

* fix capture self in ASTableNode
2016-11-21 15:28:32 -08:00
Adlai Holler d4191dc543 Merge pull request #2640 from facebook/AHRegisterDealloc2Main
Make a Public Function for Main Thread Deallocation
2016-11-21 11:56:10 +09:00
Adlai Holler 9a762f9832 Make a public function ASPerformMainThreadDeallocation 2016-11-21 11:17:24 +09:00
Adlai Holler 71872a298e Merge pull request #2223 from facebook/AHNaturalDealloc
[ASDisplayNode] Let Nodes Deallocate Naturally, Deallocate UIKit Components in Run Loop
2016-11-21 01:20:47 +09:00
Adlai Holler 10104f8ff0 Merge pull request #2638 from facebook/AHMediaTime
Use CACurrentMediaTime Instead of CFAbsoluteTime
2016-11-21 01:20:12 +09:00
Adlai Holler e923943e8c Use CACurrentMediaTime instead of CFAbsoluteTime 2016-11-21 00:54:07 +09:00
Adlai Holler 887f48cbda Add support for run loop queues with no handler, optimize 2016-11-21 00:49:54 +09:00
Adlai Holler 6d01bbeb19 Let nodes deallocate naturally, manually trampoline UIKit ivars
Be more aggressive with main thread punting

Trampoline setting the dataSource/delegate onto the main thread

Short-circuit the supplementary nodes method if no data source

Don't rely on assertions

Mark variable unused to fix release builds

Handle ASCollectionNode/ASTableNode deallocation better

Add some comments about new macro
2016-11-21 00:46:57 +09:00
Michael Schneider 1b0b9e4830 Fix layout transition measurement completion on main test (#2639) 2016-11-20 07:05:54 -08:00
Scott Goodson 72585e4262 Revert "Prevent premature placeholder image clearing when setting the video asset at a later point in time."
See test failure in https://github.com/facebook/AsyncDisplayKit/pull/2626

This reverts commit 4ad8361eea.
2016-11-19 21:59:14 -08:00
appleguy 49aee6eb03 Merge pull request #2637 from maicki/MSReaddConstrainedSizeCheckForLayoutTransition
[ASDisplayNode] Re-add layout transition check for invalid constrained size
2016-11-19 21:36:07 -08:00
Michael Schneider ddd4ef62ae Fix overlapping of nodes in layout transitions 2016-11-19 20:53:32 -08:00
Michael Schneider 9530b609f1 Readd layout transition check for invalid constrained size 2016-11-19 18:31:56 -08:00
appleguy 050de2af5c Merge pull request #2626 from master-nevi/video-flicker-fix
[ASVideoNode] Ensure we don't clear the placeholder image when setting the video asset
2016-11-19 16:20:00 -08:00