Commit Graph
5092 Commits
Author SHA1 Message Date
Adlai Holler 5b80a641af Improve Handling of Rasterized Node Interface & Hierarchy States (#2731)
* Improve handling of rasterize node interface states and testing

* Fix harder

* Finish fixes and move rasterization flag into beta header

* Re-enable rasterization in ASDKgram

* Re-enable working test

* Only do it in debug
2016-12-08 09:52:21 -08:00
Huy Nguyen 016d99f420 Document default values of alignItems and justifyContent (#2733) 2016-12-08 07:53:05 -08:00
Michael Schneider 4355f4d2ee [Layout] Don't crash if layout elements are created in layoutSpecThatFits: (#2694)
* Fix crash if layout elements are created with no owner and referenced in layoutSpecThatFits:

* Add failing test for nodes deallocated while creating in layoutSpecThatFits:

* Some more

* Some cleanup

* Added more complexity to tests

* Only cache sublayouts if the layout get’s flattened

* Address comments

* Address comments
2016-12-07 14:58:34 -08:00
Garrett Moon 80ab695cd0 Add lint mode to build.sh (#2728) 2016-12-07 14:38:12 -08:00
Adlai Holler 7de2decdcb Allow section-indexpaths in collection & table validation (#2727) 2016-12-07 13:36:15 -08:00
Michael Schneider a6b2166244 Don’t compare the hash instead compare the attributes in ASTextNodeRendererKey isEqual (#2726) 2016-12-07 09:57:48 -08:00
Michael Schneider beb98b448e [ASTextKit] Remove internal side effects related to constrainedSize. 2016-12-06 19:53:58 -08:00
Michael Schneider c3cbd3b583 Just call super to change the size of the cell node that will resize itself instead of setting the frame directly (#2725) 2016-12-06 15:53:09 -08:00
Adlai Holler 5b8330107f Merge pull request #2708 from maicki/MSPreventSettingImageSpecificImageNodeSubclasses
[ASImageNode] Add handling of setting .image in specific ASImageNode subclasses
2016-12-06 15:23:13 -08:00
Garrett Moon 54eba883d8 Update to RC 2 (#2723) 2.0-rc.2 2016-12-06 15:11:00 -08:00
Michael Schneider ee0cc9b103 Further logic and documentation improvements 2016-12-06 14:19:54 -08:00
Michael Schneider aec8dbfb33 Fix ASDKGram deprecation warning (#2719) 2016-12-06 11:52:31 -08:00
Garrett Moon d57760797a Update to beta 7 of PINRemoteImage - fixes image corruption issues. (#2720) 2016-12-06 11:11:00 -08:00
Andrey Konstantinov 52eb9df366 Fix typo in README (#2718) 2016-12-06 11:05:23 -08:00
Michael Schneider cacc366706 Some video node improvements 2016-12-06 06:55:47 -08:00
Michael Schneider ef84e99673 Tremendously make the implementation easier 2016-12-05 20:15:23 -08:00
Michael Schneider 018ad148bc Further work 2016-12-05 16:50:58 -08:00
Michael Schneider d57e33b2f0 Some further improvements 2016-12-05 16:43:46 -08:00
Michael Schneider 9fefd4a5b0 Cleanup ASVideoNode a bit 2016-12-05 16:43:46 -08:00
Michael Schneider 70b647c2b9 Add support for setting a static image to ASNetworkImageNode 2016-12-05 16:43:46 -08:00
Michael Schneider 143abdaa96 Change Header of ASImageNode+Private 2016-12-05 16:43:46 -08:00
Michael Schneider 9adb6554fc Add assertion against externally setting .image in specific ASImageNode subclasses 2016-12-05 16:43:46 -08:00
Adlai Holler 45c69ada36 Add some index path validation to avoid production crashes (#2716) 2016-12-05 16:37:44 -08:00
Adlai Holler 42c7bb291e Merge pull request #2715 from facebook/AHMoreBatchFetching
Ensure Batch Fetching Includes Leading Screens, Even if Not Scrolling
2016-12-05 16:27:01 -08:00
Adlai Holler 20c66f1025 Beef up the tests 2016-12-05 15:37:49 -08:00
Adlai Holler 9bc58dc024 When not visible, only batch fetch to fill visible area 2016-12-05 15:00:39 -08:00
Adlai Holler 21cad90355 Ensure we always fill leading screens for batching 2016-12-05 14:51:07 -08:00
Adlai Holler b775a1a8eb Merge pull request #2712 from facebook/AHFixAssertionMacros
Improve Assertion Macros
2016-12-05 12:54:14 -08:00
Adlai Holler 19b97a68af Fix our assertion macros 2016-12-05 11:42:26 -08:00
Michael Schneider a2e75152f8 [ASDisplayNode] Fix flickering for nodes that support range managed interface state (#2710)
* Fix flickering for range managed nodes

* Go back to old behavior to check for range managed before calling didExitPreloadState in interface state change
2016-12-05 10:34:03 -08:00
Michael Schneider e361d00a73 Our calculated layout is suitable for this constrainedSize, so keep using it and invalidate any pending layout that has been generated in the past. (#2706) 2016-12-02 16:17:14 -08:00
Adlai Holler 1997073802 Address Misc Warnings (#2698)
* Address compiler warnings

* Typo
2016-12-02 14:04:05 -08:00
Garrett Moon 9706b85145 Remove files that no longer exist from podfile exclusion (#2697)
* Remove files that no longer exist from podfile exclusion

* Missed some references to dealloc2main
show
2016-12-02 13:29:16 -08:00
Andrew Yates 8ab83504e3 Update Readme logo (#2691) 2016-12-02 13:14:53 -08:00
Garrett Moon d9209e69c2 Update to RC 1 (#2695) 2016-12-02 10:00:15 -08:00
Adlai Holler 40a8769217 Filter out extra items when querying collection view layout (#2693) 2016-12-02 08:48:46 -08:00
Adlai Holler 8e90a31cc1 Merge pull request #2687 from maicki/MSBetterErrorMessageForDeallocatedDisplayNodeInLayout
Better error message if a display node is created in layoutSpecThatFits: and deallocated before it was added to a subnode
2016-12-01 17:39:56 -08:00
Adlai Holler 051b738236 Inject data source class name into update validation exceptions, deprecate suppression flag (#2692) 2016-12-01 17:30:36 -08:00
Garrett Moon 8f7a632f4c Add the slack channel to the issue template. (#2690) 2016-12-01 14:00:36 -08:00
Garrett Moon ba2268ac99 2611 rename fetch data (#2689)
* Replace fetch data with preload terminology
- Deprecate `-fetchData` and `-clearFetchedData` in favor of `-preload` and `-clearPreloadedData`
- Move `-setNeedsPreload`, `-recursivelyPreload` and `-recursivelyClearPreloadedData` to ASDisplayNode+FrameworkPrivate.h
- Update internal implementation, comments and tests

* Folllow up on #2642:
- Remove -preload and -clearPreloadedData in favor of -didEnterPreloadState and -didExitPreloadState.
- -didEnterPreloadState and -didExitPreloadState call the deprecated -fetchData and -clearFetchedData methods if they are overriden.

* Missed one in a test

* Get rid of behavior change for now.

* Revert more behavior changes, fix tests.

* Don't need these anymore.
2016-12-01 13:41:22 -08:00
Michael Schneider c7ea15a5e4 Misc improvements to ASViewController (#2653)
- Remove layoutThatFit: call in viewWillAppear:
- Deprecate nodeConstrainedSize
- Use the view’s bounds to layout the node
2016-12-01 09:56:41 -08:00
Michael Schneider 66acd69e22 Better error message if a display node is created in layoutSpecThatFits: and deallocated before it was added to a subnode 2016-12-01 07:03:39 -08:00
Adlai Holler b075aa2851 Merge pull request #2682 from facebook/AHFixMoreDeallocVisibleCases
Fix Edge Cases of Table Cell Nodes Deallocated While Visible
2016-11-30 09:01:01 -08:00
Adlai Holler 81a04bc93b Remove magic number 2016-11-30 09:00:48 -08:00
Adlai Holler 361f7be6ed Merge pull request #2681 from facebook/2.0-beta.3
Update podspec to beta 3
2.0-beta.3
2016-11-29 17:05:56 -08:00
Adlai Holler 98ef8c00de Reduce cleverness 2016-11-29 16:27:33 -08:00
Adlai Holler 3fe87ffb64 Add a test replicating Issue 2252 2016-11-29 16:19:48 -08:00
Adlai Holler bb8d7d1be9 Modify ASTableView range code to fix interface state issues with grouped tables 2016-11-29 15:42:00 -08:00
Garrett Moon 7c685620aa Update podspec to beta 3 2016-11-29 14:58:41 -08:00
Adlai Holler df497b82c2 Improve Batch Fetching Call Pattern to Reduce Fetch Calls (#2675)
* Test & tweak batch fetching implementation

* Tighten the test

* Stop batch fetching at the end of range controller pass

* Clean up the test

* Still check for batch fetching after each frame when scrolling

* Ensure batch fetching happens for empty collection/table
2016-11-29 13:40:03 -08:00