GitHub/Texture
1
0
Fork 0
mirror of https://github.com/TextureGroup/Texture.git synced 2026-04-07 19:17:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,590 Commits 371 Branches 222 Tags
AHTextNodeProblem
Commit Graph
4590 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Schneider b2810edb0f Move dealloc method from ASImageNode+AnimatedImage category to ASImageNode 
Having a dealloc method in a category can be very problematic as the superclass dealloc method will not be called in case it exists.
 2016-07-08 14:41:47 -07:00
Adlai Holler ac9549ee89 Merge pull request #1870 from maicki/MSTuningParametersInTableView 
[ASTableView] Move setting of tuning parameters to the range controller
 2016-07-08 14:38:15 -07:00
Adlai Holler d1c84a1a28 Merge pull request #1814 from maicki/MSFixiOS8ModalRotationAdjustment 
[ASViewController] Fix Modal presented ASViewController don't rotate on iOS 8.3
 2016-07-08 14:37:59 -07:00
Michael Schneider 33e093b1f6 Check if a superview is present before calculating the legacy constrained size 2016-07-08 13:20:18 -07:00
Michael Schneider 057c48482a Fix Modal presented ASViewController don't rotate on iOS 8.3 2016-07-08 13:10:41 -07:00
Adlai Holler b1626b0f69 Merge pull request #1791 from colinmcardell/ASCollectionDataController_supplementaryNodeOfKind-fix 
[ASCollectionDataController] Exposing -supplementaryNodeOfKind
 2016-07-08 12:50:32 -07:00
Adlai Holler b3d673645d Merge pull request #1867 from maicki/MSFixXcode8Errors 
Fix Xcode 8 Errors
 2016-07-08 12:42:50 -07:00
Adlai Holler 78ef8cd8ae Merge pull request #1869 from facebook/AHDisableTroublesomeAssertions 
[ASDataController] Temporarily Disable Some Troublesome Assertions
 2016-07-08 12:15:08 -07:00
Michael Schneider 02a41f4db5 Move setting the tuning parameters to the range controller in ASTableView 2016-07-08 11:36:43 -07:00
Adlai Holler a0aad4609d [ASDataController] Temporarily disable some troublesome assertions 2016-07-08 11:36:43 -07:00
Adlai Holler 82233af5a7 Merge pull request #1860 from rcancro/upstream_remove_context 
[ASTraitCollection] Remove traitCollectionContext from ASTraitCollection; add containerWindowSize
 2016-07-08 11:18:04 -07:00
Michael Schneider f25e0f0d01 Fix Xcode 8 errors 2016-07-08 10:51:07 -07:00
Adlai Holler 33620b9e8e Merge pull request #1834 from maicki/MSVisibilityTriggeringViewCreation 
[ASVisibility] Don't change the range mode if the node was not loaded yet
 2016-07-08 10:32:20 -07:00
Adlai Holler 9154fbbdda Merge pull request #1864 from nguyenhuy/range_controller 
[ASRangeController] Minimize number of registrations to node display notifications
 2016-07-08 10:15:16 -07:00
Huy Nguyen 312de1a084 Make sure range controller listens to node display notifications if absolutely needed 2016-07-08 12:09:47 +07:00
Adlai Holler 8e1c8acb54 Merge pull request #1861 from facebook/AHCollectionViewLayerRetaining 
[ASCollectionView] Add strong Layer Pointer Under iOS < 9 to Workaround Crashes
 2016-07-07 18:26:02 -07:00
Adlai Holler 332ab2330a Merge pull request #1858 from maicki/MSFixBlockDeclaration 
[ASCollectionView] Add return type to the shouldNotAnimateBlock
 2016-07-07 14:42:20 -07:00
Adlai Holler 8ea1a2a813 Merge pull request #1854 from garrettmoon/fixiOS7VisibilityDepth 
<ASVisibility> Fixes to visibility depth behavior on iOS 7.
 2016-07-07 11:20:24 -07:00
Garrett Moon b79641d4ee Use indexOfObjectIdenticalTo since we only care if the pointers are equal. Thanks @Adlai-Holler! 2016-07-07 11:13:18 -07:00
Garrett Moon 8081123cb2 Fix visibility assert on iOS 7 
It appears that didMoveToViewController: can be called with nil,
yet self.parentViewController will *not* be nil. This can result
in calling parent view controller's visibility depth. Instead of
asserting, these methods should return NSNotFound which also happens
to be a really large number, effectively infinite depth.
 2016-07-07 11:08:06 -07:00
ricky ff0e2846e3 fixed formatting 2016-07-07 10:56:58 -07:00
ricky 7314a18ab4 rename containerWindowSize to containerSize 2016-07-07 10:55:18 -07:00
Adlai Holler 54ee62f002 [ASCollectionView] Add a strong pointer from ASCollectionView -> layer under iOS < 9 to workaround issue 2016-07-07 10:36:41 -07:00
ricky 3512cf47aa assert we are on the main thread before accessing view. 2016-07-07 10:21:40 -07:00
ricky ec4b666bc5 update ASTraitCollection header 2016-07-07 09:59:24 -07:00
ricky 637c4f3a9f [ASTraitCollection] Remove traitCollectionContext from ASTraitCollection; add containerWindowSize 
Passing around a pointer was leading to crashes as the ASVC was the sole owner of the context. There are cases where the VC would dealloc while its subnodes were laying out. This could lead to the subnodes accessing a garbage pointer.
 2016-07-07 09:23:37 -07:00
Michael Schneider 94ca363936 Add return type to the shouldNotAnimateBlock 2016-07-07 07:00:07 -07:00
Kiel Gillard 762e9832df Make ASViewController sample build and run. 2016-07-07 15:41:21 +10:00
Kiel Gillard 6a15ab6130 * Tidy the header imports, forward declaring classes and protocols where appropriate to avoid import cycles and using the framework/system header notation for imports occuring in .h files. 
* Perhaps controversially, decomposing ASRangeControllerUpdateRangeProtocol+Beta.h such that the categories on various classes are defined in the classes themselves since that's where the implementation of those categories is provided.
* Updating unit tests and import other headers the tests took for granted. The tests could probably import the umbrella header and not have to worry about this.
* Updating the "Life without Cocoapods" sample to build and run dependent on ASDK as a static library.
* Added a "Life With Frameworks" sample app to build and run dependent on ASDK as a framework, proving the framework targets work.
 2016-07-07 15:12:19 +10:00
Adlai Holler c62a4d3e79 [ASCollectionView] Greatly Improve Cell Node Resizing (#1853) 
* [ASCollectionView] Initial pass at reducing double-sided animations

* [ASCollectionView] Always suppress animation during node size requery

* [ASCollectionView] Rejigger the invalidation logic to support animated size changes

* [ASCollectionView] Remove unused header

* [ASCollectionView] Change comment

* [ASDataController] Remove unused variable

* [ASCollectionView] When relayout animated due to cell size change, wait until next layout pass

* [ASCollectionView] Invalidate layout synchronously

* [ASCollectionView] Only read the layout object once

* [ASCollectionView] When size changes, wait for requery before layout

* [ASCollectionView] Sort of go back to using an empty update to handle node resizing

* [ASCollectionView] Remove unused constant

* [ASCollectionView] Address PR comments

* [ASCollectionView] Prevent nested [super performBatchUpdates:] calls
 2016-07-06 14:13:52 -07:00
Kiel Gillard f7b7bcebeb * Make the "Life Without Cocoapods" sample build and run. 
* Properly reference headers within implementation files to avoid import cycles and redeclaration warnings.
 2016-07-06 16:58:13 +10:00
Kiel Gillard 9eed54491e Copy header files using the Copy Files phase rather than the Headers phase since this is how static libraries are expected to expose their headers to clients. 2016-07-06 16:26:01 +10:00
Hannah Trosi f6d30b668d add comments to deprecated getter methods, remove extraneous if statements 2016-07-05 21:30:09 -07:00
Hannah Troisi edd656f321 update cocoapod stats 2016-07-05 18:48:15 -07:00
Hannah Trosi 3994f2089c [ASCellNode] Final revisions to behavior of setSelected: & setHighlighted: 2016-07-05 17:47:00 -07:00
Gareth Reese b9b002354a [ASVideoNode] Only seek to beginning when auto repeating 2016-07-05 13:27:53 +01:00
Hannah Troisi 682ddcfe51 [AsyncDisplayKit+Utilities.h] Convenience methods for creating resizable circles & rounded rects. (#1811) 
* [AsyncDisplayKit+Utilities.h] UIImage category for performant (optionally rounded) flat color stretchable images

* treat clear background color as no background color (D99117)

* add borderWidth

* add several shorter methods per Scott's comment

* rename files and add to AsyncDisplayKit.h

* fix xcode project file

* update commentse
 2016-07-04 16:34:16 -07:00
Hannah Troisi 3763df1f06 [Example] Resolved ASTextNode bugs (test app to reproduce issues, do regression testing) (#1803) 
* [Examples] text node known inconsistencies with UILabel

* addressed @appleguy's comments
 2016-07-04 14:48:31 -07:00
Michael Schneider c20f452dca Remove check for [UIDevice systemVersion] check if running on iOS 7 (#1843) 2016-07-03 21:47:35 -07:00
Michael Schneider 9de014f179 Change applySubnodeTransition to startTransition 2016-07-03 14:38:26 -07:00
Michael Schneider bf6fbd173d Address first comments 2016-07-03 13:33:23 -07:00
Hannah Trosi 61d7c093a1 Merge branch 'master' into selectionBug 2016-07-02 11:50:19 -07:00
Hannah Trosi d8b3878a59 Merge remote-tracking branch 'facebook/master' 2016-07-02 11:47:06 -07:00
Hannah Trosi 3080ee33cf Revert "update from master/" 
This reverts commit d7fde61e16.
 2016-07-02 11:45:40 -07:00
Michael Schneider 52a34db884 Add pending state for range mode in ASTableNode and ASCollectionNode 2016-07-02 10:27:52 -07:00
Adlai Holler d8c0253321 Merge pull request #1830 from maicki/FixUnbalancedEndBatchUpdatesCalls 
[ASDataController] Prevent calling endUpdatesAnimated:completion: in an unbalanced way
 2016-07-02 10:19:27 -07:00
Michael Schneider 9be2f1db4e Prevent calling endUpdatesAnimated:completion: in an unbalanced way 2016-07-02 10:17:09 -07:00
Adlai Holler 5d7f3b4293 Merge pull request #1819 from kielgillard/master 
[ASDisplayNodeExtras] Collect subnodes passing the test
 2016-07-02 08:55:51 -07:00
Adlai Holler 4d67b44944 Merge pull request #1808 from maicki/MSCacheSelectorFlagsNetworkImageNode 
[ASNetworkImage] Use flags to cache instead of instance variables for caching respond to selector calls
 2016-07-02 08:39:59 -07:00
Adlai Holler f4ccb93969 Merge pull request #1788 from gazreese/ASVideoNode-overwrittenplaceholder 
[ASVideoNode] issue #1782 Placeholder images are replaced by blanks during loading
 2016-07-02 08:30:38 -07:00