GitHub/Texture
1
0
Fork 0
mirror of https://github.com/TextureGroup/Texture.git synced 2026-04-07 19:17:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,590 Commits 371 Branches 222 Tags
AHTextNodeProblem
Commit Graph
4590 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Adlai Holler 2e3da9bc92 Merge pull request #1903 from nguyenhuy/ASButtonNode_updateTitle 
[ASButtonNode] Correctly compare and update its title
 2016-07-12 11:34:22 -07:00
Michael Schneider 84029d133f Merge pull request #1902 from maicki/MSFixLayoutTriggerFromSubnodeNotHappening 
[ASDisplayNode] Fix setNeedsLayout triggered from subnode will not trigger relayout
 2016-07-12 11:28:14 -07:00
Michael Schneider dc2255d5d8 Fix setNeedsLayout triggered from subnode will not trigger relayout 2016-07-12 09:26:40 -07:00
Huy Nguyen 4b331be1e8 Correctly compare and update title of ASButtonNode 2016-07-12 21:25:22 +07:00
George A 396583dbaa [ASMapNode] Protected showAnnotationsOptions with a lock. 2016-07-12 08:01:17 +02:00
Adlai Holler 6b44b5ac05 [ASTableView] Add retainedLayer a la collection view (#1896) 2016-07-11 20:22:45 -07:00
Michael Schneider 7f4737217e Change from MutexLocker / MutexUnlocker to lock() and unlock() directly on property lock (#1900) 
For performance reasons change to directly lock and unlock calls on the property lock instance
 2016-07-11 17:04:47 -07:00
Michael Schneider 93ee42db57 Remove assert in visibleStateDidChange: in ASCellNode (#1899) 
This assertion is failing in some apps and will be enabled soon.
 2016-07-11 17:04:20 -07:00
Michael Schneider 137c70647d Merge pull request #1892 from rcancro/finalLayoutableSetChildren 
[ASLayoutSpec] Final layoutable set children
 2016-07-11 14:31:35 -07:00
Michael Schneider 255e75a9be Merge pull request #1893 from eJamesLin/fix_example_Multiplex_image_path 
[Examples] fix image paths in example_extra/Multiplex
 2016-07-11 14:20:10 -07:00
George A 41e26374e3 Removed debugging messages from ASMapNode's sample, they are no longer needed. 2016-07-11 20:52:48 +02:00
George A f9629beabb [ASMapNode] Defaulting userInteractionEnabled to YES. 2016-07-11 20:48:12 +02:00
Hannah Troisi 488db475f4 Update GITHUB_RULES.md 2016-07-11 11:22:11 -07:00
CJ Lin f8e294bc23 fix image paths in example_extra/Multiplex 2016-07-12 01:36:41 +08:00
ricky 0696ea87b7 fixed trait example 2016-07-11 09:59:22 -07:00
ricky 57ece0f46e [ASLayoutSpec] Bug where finalLayoutable was not being called for setChildren 2016-07-11 09:54:03 -07:00
George A 69ca67b578 Code cleaning and fixes based on code review. 2016-07-11 10:43:19 +02:00
Scott Goodson 012c927cd8 [ASLayout] Small optimization to eliminate one method call in an extremely hot codepath. 
This was observed with quantitative profiling results.  We have some opportunities to micro-optimize the layout objects.
 2016-07-10 23:02:39 -07:00
Hannah Troisi a8f01fb13b Merge pull request #1887 from facebook/fixASDKgram 
Remove UIKit call from -init!
 2016-07-10 21:19:14 -07:00
Hannah Trosi 2317e17c53 Remove UIKit call from -init!1 2016-07-10 21:17:32 -07:00
Hannah Troisi 1d93dbc0b3 Add files via upload 2016-07-10 20:12:36 -07:00
Hannah Troisi cf010176b4 Update .gitignore 2016-07-10 19:06:40 -07:00
Hannah Trosi bd6e85e59d Remove old (original website) files from repository 2016-07-10 19:03:34 -07:00
Hannah Troisi b9c9e6be5b Update README.md 2016-07-10 18:59:07 -07:00
appleguy a9e3eacfe5 [ASCellNode] Add gating for -convertRect: call upon invisibility notification for iOS 7 & 8 edge case. (#1881) 
* [ASCellNode] Add gating for -convertRect: call upon invisibility notification for iOS 7 & 8 edge case.

This should resolve https://github.com/facebook/AsyncDisplayKit/issues/1659, which corresponds to this
Fabric log for Pinterest: https://fabric.io/pinterest6/ios/apps/com.pinterest.enterprise/issues/5776fbfeffcdc042501a5f20/sessions/c178e977614b4ebab853084847fb241
8

* [ASCellNode] Additional improvements to visibilityDidChange: gating.
 2016-07-10 16:01:55 -07:00
Hannah Trosi 5856bd3b59 [Cocoapods] Update podspec with 1.9.81 1.9.81 2016-07-10 12:53:44 -07:00
Flo 2e65339f33 [ASVideoNode, ASVideoPlayerNode] Add video composition and audio mix capabilities (#1800) 
* [ASVideoNode] Add delegate method called when the currentItem is set.

* [ASVideoNode] Add videoComposition and audioMix properties to the ASVideoNode.

* [ASVideoPlayerNode] Add new initialiser with videoComposition and audioMix, and forward new delegate method.

* [ASVideoPlayerNode] Forward missing ASVideoNodeDelegate methods.
 2016-07-10 11:32:21 -07:00
Hannah Troisi 10447998af [ASMapNode] use ASDisplayNode base class lock (#1879) 
* [ASVideoPlayerNode] Use ASDisplayNode base class lock for subclass property syncrhonization, fix retain cycles

* [ASMapNode] Use ASDisplayNode base class lock instead of subclass lock
 2016-07-10 00:30:37 -07:00
Scott Goodson bf9c142765 Revert "[ASTextNode] Fix text node truncation (#1863)" 
This reverts commit 6238e5edbd.

We will re-apply this change, but there are some early signs of performance impacts that need to be investigated.
 2016-07-09 23:54:43 -07:00
Scott Goodson d83f319fe3 Revert "Use textStorageCreationBlock for resetting the text storage (#1874)" 
This reverts commit d646d3c753.
 2016-07-09 23:54:28 -07:00
Hannah Troisi ff7a586eba [ASVideoPlayerNode] Use ASDisplayNode base class lock for subclass property syncrhonization, fix retain cycles (#1878) 2016-07-09 23:51:49 -07:00
Scott Goodson 1d07759c9e [ASDisplayNode+AsyncDisplay] Add locking for _flags (although write-once-on-init, this quiets the Thread Sanitizer). 2016-07-09 23:50:40 -07:00
Eric Horacek 3efd01a781 [ASCollectionDataController] Repopulate deleted supplementary nodes if necessary (#1773) 
* Repopulate deleted supplementary nodes if necessary

Fixes 1771

* Fix warning
 2016-07-09 22:46:29 -07:00
Hannah Troisi f39c2ce7e3 [ASTextNode, ASImageNode, ASVideoNode] Use ASDisplayNode base class lock for subclass property synchronization (#1877) 
* [ASTextNode, ASVideoNode] Use ASDisplayNode base class lock for subclass property synchronization

* fix headers to match master

* address @appleguy, @maicki comments

* import header

* Swap lock in ASNetworkImageNode as well

* remove invalid comment

* more cleanup of locks
 2016-07-09 22:08:34 -07:00
Flo 131dd25de3 [ASNetworkImageNode] Check that data is not nil before loading the animated image. (#1849) 2016-07-09 21:19:57 -07:00
appleguy dc12042589 [ASDisplayNode] Do not start measurement for a transition if we have never been provided a constrainedSize. (#1844) 2016-07-09 21:16:29 -07:00
appleguy 3b2af7eb6d [Build] Remove Unused Imports across all of AsyncDisplayKit. This uses a feature of AppCode. (#1875) 
Details on the tool are here: https://www.jetbrains.com/help/idea/2016.1/optimizing-imports.html
 2016-07-09 17:20:59 -07:00
Michael Schneider e7e2672472 Move imageLock in braces for getting drawing parameters (#1876) 2016-07-09 17:02:05 -07:00
Michael Schneider d646d3c753 Use textStorageCreationBlock for resetting the text storage (#1874) 2016-07-09 16:43:18 -07:00
Scott Goodson 48311aee96 [Build] Fix build issue caused by an #import change. 2016-07-09 16:09:35 -07:00
gazreese 01ba38d818 [ASVideoPlayerNode] Ensure activity indicator view is transparent (#1852) 2016-07-09 16:00:48 -07:00
Scott Goodson d8d20fd87c Merge branch 'kielgillard-master' 2016-07-09 15:44:50 -07:00
Scott Goodson f0ff9c108d Merge branch 'master' of git://github.com/kielgillard/AsyncDisplayKit into kielgillard-master 2016-07-09 15:44:31 -07:00
Michael Schneider 6238e5edbd [ASTextNode] Fix text node truncation (#1863) 
* Before truncate a text storage in ASTextKitContext reset the text storage to original value

* Fix ASTextNode tests

We should pass in the constrained size in both cases and the sizes should be the same. We adjust the calculated size in ASTextNode to be a bit narrower in the second case if we truncate again with the calculated size as constrained size it will truncate more and the resulting size will shrink.
 2016-07-09 15:40:31 -07:00
Adlai Holler 38fab7cd94 Merge pull request #1816 from hannahmbanana/selectionBug 
[ASCellNode] Fix selection / highlight implementation
 2016-07-08 15:48:22 -07:00
Adlai Holler 0f589d7e2b Merge pull request #1847 from gazreese/ASVideoNode-no-auto-seek 
[ASVideoNode] Only seek to beginning when auto repeating
 2016-07-08 15:45:17 -07:00
Adlai Holler a2d4dc5888 Merge pull request #1839 from maicki/MSAsyncMeasure 
[ASDisplayNode] Allow measure always be off the main thread
 2016-07-08 15:41:05 -07:00
Adlai Holler 09069584cc Merge pull request #1871 from maicki/MSMoveDeallocASImgeNode 
[ASImageNode] Move dealloc method from ASImageNode+AnimatedImage category to ASImageNode
 2016-07-08 15:20:06 -07:00
Adlai Holler 7995b6e3da Merge pull request #1872 from rcancro/containerSizeBug_upstream 
[ASEnvironmentTraitCollection] Fixed bug where containerSize wasn't being saved
 2016-07-08 15:19:38 -07:00
ricky fe61c3e3ab [ASEnvironmentTraitCollection] Fixed bug where containerSize wasn't being saved 
Summary:
The old assignment of `self.node.environmentTraitCollection.containerSize = windowSize;` doesn't because the struct creates a copy and then assigns `windowSize` to that copy.

Also realized that we need to create a new `ASEnvironmentTraitCollection` in `willTransitionToTraitCollection:withTransitionCoordinator`:. If we only update in `viewWillTransitionToSize:` we will only update the `containerSize` value in `self.environmentTraitCollection` as we don't have the new trait collection yet.

Differential Revision: https://phabricator.pinadmin.com/D101807
 2016-07-08 15:00:50 -07:00