GitHub/Texture
1
0
Fork 0
mirror of https://github.com/TextureGroup/Texture.git synced 2026-04-07 19:17:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

ASDimensionMake to be more lenient #trivial (#382)

Browse Source 
* ASDimensionMake to be more lenient

Don't throw assertion when the string is invalid

* Fix unit test
This commit is contained in:
Huy Nguyen
2017-06-30 13:21:51 -07:00
committed by Garrett Moon
parent 928bc9f8ff
commit 7dce48174e
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Layout/ASDimension.mm
-1
View File
@@ -47,7 +47,6 @@ ASOVERLOADABLE ASDimension ASDimensionMake(NSString *dimension)
}
}
ASDisplayNodeCAssert(NO, @"Parsing dimension failed for: %@", dimension);
return ASDimensionAuto;
}
Tests/ASDimensionTests.mm
+1 -1
View File
@@ -29,7 +29,7 @@
{
XCTAssertNoThrow(ASDimensionMake(ASDimensionUnitAuto, 0));
XCTAssertThrows(ASDimensionMake(ASDimensionUnitAuto, 100));
XCTAssertThrows(ASDimensionMake(@""));
ASXCTAssertEqualDimensions(ASDimensionAuto, ASDimensionMake(@""));
ASXCTAssertEqualDimensions(ASDimensionAuto, ASDimensionMake(@"auto"));
}