GitHub/Texture
1
0
Fork 0
mirror of https://github.com/TextureGroup/Texture.git synced 2026-04-07 19:17:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

use lock to avoid crash when image might be changed during the trait collection change (#1651)

Browse Source
This commit is contained in:
vovasty
2019-08-30 12:45:58 -07:00
committed by GitHub
parent 0cd5561fd6
commit 4d6532ccc8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/ASImageNode.mm
+2 -2
View File
@@ -756,6 +756,7 @@ static ASWeakMap<ASImageNodeContentsKey *, UIImage *> *cache = nil;
[super asyncTraitCollectionDidChangeWithPreviousTraitCollection:previousTraitCollection];
if (AS_AVAILABLE_IOS_TVOS(12, 10)) {
__instanceLock__.lock();
// update image if userInterfaceStyle was changed (dark mode)
if (_image != nil && self.primitiveTraitCollection.userInterfaceStyle != previousTraitCollection.userInterfaceStyle) {
UITraitCollection *tc = [UITraitCollection traitCollectionWithUserInterfaceStyle:self.primitiveTraitCollection.userInterfaceStyle];
@@ -764,9 +765,8 @@ static ASWeakMap<ASImageNodeContentsKey *, UIImage *> *cache = nil;
if ( updatedImage != nil ) {
_image = updatedImage;
}
// trigger needs display anyway, cause image might be dynamic itself (e.g. dynamic tint color)
[self setNeedsDisplay];
}
__instanceLock__.unlock();
}
}