Commit Graph

2506 Commits

Author SHA1 Message Date
Samuel Susla 4f1cb5f2b7 add new test case 2017-03-25 10:59:02 +00:00
Samuel Susla abd5dd781a use sourceKitten to convert indices 2017-03-25 09:38:06 +00:00
Samuel Susla 6fb7275642 use shorter syntax 2017-03-21 23:01:16 +01:00
Samuel Susla 48c85d134b Add two trailing spaces 2017-03-21 13:25:57 +01:00
Samuel Susla eb75ff52e4 add tests for mandatoryComma 2017-03-21 10:45:35 +01:00
Samuel Susla edf4e8cc4d take unicode characters into account 2017-03-21 10:09:56 +01:00
Samuel Susla 5386722ca8 add corrections to rule description 2017-03-18 11:39:47 +01:00
Samuel Susla 29f3b7dbb3 add change to CHANGELOG.md 2017-03-01 09:25:56 +01:00
Samuel Susla bde2307141 add autocorrect support for mandatory comma 2017-03-01 09:03:55 +01:00
Samuel Susla 29359bbad5 add trailing comma autocorrect 2017-02-26 21:57:27 +01:00
JP Simard 29a404aa6b Merge pull request #1317 from BalestraPatrick/patch-1
Fix dead link in CONTRIBUTING.md
2017-02-17 11:39:04 -08:00
Patrick Balestra fdb46dcb87 Update CONTRIBUTING.md
Fix dead link and deprecated rule name
2017-02-17 20:37:01 +01:00
JP Simard e829e8222b Merge pull request #1287 from marcelofabri/implicit-getter-more-variables
Accept global and local variables in `implicit_getter` rule
2017-02-14 19:46:57 -08:00
Marcelo Fabri 754887d342 Accept global and local variables in implicit_getter rule 2017-02-14 12:55:20 -02:00
JP Simard b8f02c4e62 Merge pull request #1246 from marcelofabri/redundant_discardable_let
Add redundant_discardable_let rule
2017-02-10 12:16:52 -08:00
JP Simard d3c5f83e8d Merge pull request #1303 from realm/jp-scheme-arguments
set 'swiftlint' scheme's arguments to 'lint --no-cache'
2017-02-10 11:54:12 -08:00
JP Simard 9ad1b842e8 set 'swiftlint' scheme's arguments to 'lint --no-cache'
since the cache is per-version and the version number is
only bumped for releases, meaning that during development
the cache is likely to be incorrect.
2017-02-10 11:52:13 -08:00
Marcelo Fabri 0abc114895 Add redundant_discardable_let rule
Fixes #1232
2017-02-10 11:46:13 -08:00
Marcelo Fabri f90b25e2e1 Refactor elements to not be optional 2017-02-09 17:59:31 -08:00
JP Simard 99f6430838 perform union merges on CHANGELOG.md
this should resolve conflicts more sensibly

See https://about.gitlab.com/2015/02/10/gitlab-reduced-merge-conflicts-by-90-percent-with-changelog-placeholders/
for details
2017-02-09 17:11:45 -08:00
JP Simard d8a1fe7dc1 Merge pull request #1253 from marcelofabri/bugfix_1216
Fix closure_end_indentation false positive
2017-02-09 17:08:57 -08:00
Marcelo Fabri 55457ceeae Fix closure_end_indentation false positive
Fixes #1216
2017-02-09 17:07:41 -08:00
JP Simard ce40e4e6de Merge pull request #1285 from marcelofabri/unused_enumerated_index
unused_enumerated should check if only index is used
2017-02-09 17:04:47 -08:00
Marcelo Fabri b26bb95d25 unused_enumerated should check if only index is used
Fixes #1278
2017-02-09 17:03:15 -08:00
JP Simard dfde20a3f1 Merge pull request #1286 from marcelofabri/switch_case_newline_ast
Reimplement switch_case_on_newline as an ASTRule
2017-02-09 16:42:32 -08:00
JP Simard 3c26c9304e changelog updates 2017-02-09 16:39:46 -08:00
Marcelo Fabri d5b0d1b208 Reimplement switch_case_on_newline as an ASTRule
Fixes #1268
2017-02-09 16:37:26 -08:00
JP Simard 944a989994 Merge pull request #954 from marcelofabri/identifier-rule
variable_name rule should extend to all identifiers
2017-02-09 16:35:45 -08:00
JP Simard a2ec02cb78 replace uses of 'variable_name' with 'identifier_name' in markdown files 2017-02-09 16:14:49 -08:00
JP Simard fa3ab00183 fix merge 2017-02-09 15:53:16 -08:00
JP Simard 337ec41d54 move changelog entry to appropriate section 2017-02-09 15:50:47 -08:00
JP Simard 8c4bfcc58d Merge branch 'master' into identifier-rule
* master: (44 commits)
  make valid_docs rule opt-in
  update LineLengthConfiguration.consoleDescription after #1264
  small refactoring after #1264
  fix for_where violation in CompilerProtocolInitRule.swift
  Add for_where rule
  explicitly set podspec dependency versions
  Add changelog entry
  Fix existing violations
  Navigate substructure even for different kinds
  Small style changes
  Modified so that kinds(forByteOffset:) does not require a separate filter() setup of the results
  Changes from PR feedback. Long comments following code in a line will now trigger,  configuration will now fail if invalud value types are set for options
  Fix false positive on large_tuple when using generics inside a tuple
  fix wording in changelog
  disable docs rules in Swift 2.3 and later
  Fix deadlock when stderr fills up OS buffer
  small Danger/oss-check improvements
  Fix links
  Fix cleanup
  Always use Xcode reporter on oss-check
  ...
2017-02-09 15:50:06 -08:00
JP Simard 35ce34d919 make valid_docs rule opt-in 2017-02-09 15:15:30 -08:00
JP Simard 811e11a237 Merge pull request #1300 from realm/jp-1264-fixes
refactor and fix a few things after #1264
2017-02-09 15:07:13 -08:00
JP Simard a10156b5eb update LineLengthConfiguration.consoleDescription after #1264 2017-02-09 14:42:10 -08:00
JP Simard 69f885cf08 small refactoring after #1264 2017-02-09 14:42:09 -08:00
JP Simard 7ab9855831 fix for_where violation in CompilerProtocolInitRule.swift 2017-02-09 14:42:09 -08:00
Marcelo Fabri f0c8fba3b6 Add for_where rule
Fixes #1228
2017-02-09 13:43:58 -08:00
JP Simard be9f92f47c Merge pull request #1248 from marcelofabri/bugfix_1237
Navigate substructure even for different kinds on ASTRule
2017-02-09 12:52:35 -08:00
JP Simard 6903a92b3b Merge pull request #1297 from realm/jp-explicit-podspec-versions
explicitly set podspec dependency versions
2017-02-09 11:31:20 -08:00
JP Simard 3414df11b4 explicitly set podspec dependency versions 2017-02-09 11:28:55 -08:00
Marcelo Fabri 1225d17eed Add changelog entry 2017-02-06 22:04:22 -02:00
Marcelo Fabri ecc3c85f68 Fix existing violations 2017-02-06 22:04:05 -02:00
Marcelo Fabri ac4ea29150 Navigate substructure even for different kinds 2017-02-06 22:04:05 -02:00
Marcelo Fabri ad10f81a44 Merge pull request #1259 from marcelofabri/bugfix_1257
Fix false positive on large_tuple when using generics inside a tuple
2017-02-06 22:01:33 -02:00
Marcelo Fabri 4ef01d1741 Merge pull request #1290 from marcelofabri/small-style
Small style changes after #1264
2017-02-06 22:00:58 -02:00
Marcelo Fabri 2300ae3daf Small style changes 2017-02-06 21:59:30 -02:00
Marcelo Fabri 56bbf12bda Merge pull request #1264 from mlwelles/line-length-rule-configurable
Changes for issue #598 to make line length rule configurable
2017-02-06 21:55:58 -02:00
Michael Welles 15a7a88297 Modified so that kinds(forByteOffset:) does not require a separate
filter() setup of the results
2017-02-06 15:58:45 -05:00
Michael Welles 7d48153d4a fixed merge conflicts 2017-02-06 15:38:19 -05:00