314da3dc8e
Remove unnecessary rule disabling
2017-06-15 06:08:38 +02:00
52ab08c3ae
Add missing two trailing spaces to CHANGELOG
2017-06-15 06:07:44 +02:00
e9b5abffff
Update LinuxMain file with new tests
2017-06-15 06:07:44 +02:00
52176fdcee
[CHANGELOG] Add ObjectLiteral config change
2017-06-15 06:07:44 +02:00
95a8b8137f
Remove basic ObjectLiteral rule verification
...
This removes the test from the collective test class.
There's a new ObjectLiteralRuleTests class instead.
2017-06-15 06:07:43 +02:00
be3b5daed2
Fix too long lines in tests
2017-06-15 06:07:43 +02:00
7d03a75caa
Use the new config options in implementation
2017-06-15 06:07:43 +02:00
e3c0d2295b
Fix non triggering example issues in tests
2017-06-15 06:07:43 +02:00
028d2b98a3
Add tests for ObjectLiteral rule with config
2017-06-15 06:07:43 +02:00
ad03a2f2d0
Add ObjectLiteralConfiguration with color/image options
...
This fixes #1587 by implementing the discussed option config.
2017-06-15 06:07:43 +02:00
95f2cf6226
Merge pull request #1623 from realm/mf-bugfix-1622
...
Fix `empty_count` false positive in words with "count"
2017-06-14 18:47:24 +02:00
6c9766d01c
Fix empty_count false positive in words with "count"
...
Fix #1622
2017-06-14 17:49:12 +02:00
9818d48d22
Merge pull request #1568 from marcelofabri/prefix-while
...
Use prefix(while:) instead of partioned
2017-06-14 13:11:54 +00:00
561653bcb2
Use prefix(while:) instead of partitioned(by:)
2017-06-14 14:33:04 +02:00
f0a6fbfe4a
Merge pull request #1621 from realm/mf-update-linux-main
...
Update LinuxMain.swift
2017-06-14 12:31:09 +00:00
772468638d
Update LinuxMain.swift
2017-06-14 14:22:41 +02:00
a4328e527e
Merge pull request #1603 from realm/jp-custom-rules-commands
...
Fix custom rules not working correctly with comment commands
2017-06-13 22:04:55 +00:00
4684237803
Add tests
2017-06-13 22:47:52 +02:00
81105b70db
fix custom rules not working correctly with comment commands
2017-06-13 22:47:52 +02:00
46307dabe1
Merge pull request #1604 from realm/jp-custom-config
...
Fix using incorrect config file
2017-06-13 20:47:23 +00:00
dbdc9f7788
Add a test for loading custom configuration
2017-06-13 21:41:48 +02:00
a6487db198
fix using incorrect config file ( fixes #1531 )
2017-06-13 21:32:56 +02:00
d8eae6ec23
Merge pull request #1620 from marcelofabri/continue-1584
...
Add missing triggering cases involving subscript in force_unwrapping
2017-06-13 19:27:30 +00:00
0c464072cd
Update CHANGELOG entry
2017-06-13 21:07:16 +02:00
729fab3ffe
Add missing triggering cases involving subscript in force_unwrapping rule
...
Additionally fixes false positives
Fixes : #614 , #977
2017-06-13 21:06:15 +02:00
25ae8d3027
Merge pull request #1619 from realm/mf-continue-1609
...
Fix crash in `unused_closure_parameter` rule
2017-06-13 18:31:08 +00:00
77588f0f29
PR feedback
2017-06-13 18:38:07 +02:00
c3fcdf58c3
UnusedClosureParameterRule Crash
...
- If closure parameter is unicode, it calculate length 1, but its real length is 3. So when running byteRangeToNSRange, it accured crash in String+SourceKitten.swift:131.
2017-06-13 18:38:07 +02:00
c08a1339c2
Merge pull request #1484 from marcelofabri/vertical_parameter_alignment_on_call
...
Vertical parameter alignment on call rule
2017-06-13 18:01:51 +02:00
64585a5845
Update Sourcery template and tests
2017-06-13 16:18:27 +02:00
fd231b607d
Fix existing violations
2017-06-13 16:12:58 +02:00
d123b47317
Add vertical_parameter_alignment_on_call rule
2017-06-13 16:12:58 +02:00
f8ca8640c3
changelog formatting edits
2017-06-02 16:46:42 -07:00
6712b5488d
Merge pull request #1592 from realm/jp-sourcery-master-rule-list
...
Use Sourcery to generate LinuxMain.swift & MasterRuleList.swift
2017-06-02 15:02:44 -07:00
e2ef118c09
Merge pull request #1602 from realm/jp-delete-xctest-bundle-linux
...
Fix `make docker_test` failure after running SwiftPM on Darwin
2017-06-02 14:52:44 -07:00
90ee3d377b
fix make docker_test failure after running SwiftPM on Darwin
...
SwiftPM on Darwin produces a `.xctest` _bundle_ (i.e. folder).
SwiftPM on Linux produces a `.xctest` _binary_ (i.e. file).
SwitPM on Linux exits unsuccessfully if it finds a folder at the `.xctest` location.
```
$ make docker_test
...
Linking ./.build/debug/SwiftLintPackageTests.xctest
/usr/bin/ld.gold: fatal error: ./.build/debug/SwiftLintPackageTests.xctest: open: Is a directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: link command failed with exit code 1 (use -v to see invocation)
<unknown>:0: error: build had 1 command failures
swift-test: error: exit(1): /usr/bin/swift-build-tool -f .build/debug.yaml test
make: *** [docker_test] Error 1
```
This change detects this scenario and pre-emptively deletes the `.xctest` folder if it exists.
2017-06-02 14:39:02 -07:00
922a867729
add 'Run Sourcery' build phase
...
only runs if Sourcery is installed.
2017-06-02 14:28:37 -07:00
f1417da079
preserve Sourcery comment header in make sourcery
2017-06-02 14:28:37 -07:00
9a81734081
use Sourcery to generate MasterRuleList.swift
2017-06-02 14:28:37 -07:00
25a92c4e03
automatically generate LinuxMain.swift using Sourcery
...
This adds 6 tests that were accidentally not being run on Linux:
* LineLengthConfigurationTests.testLineLengthConfigurationInitialiserSetsIgnoresComments
* LineLengthConfigurationTests.testLineLengthConfigurationInitialiserSetsIgnoresFunctionDeclarations
* LineLengthConfigurationTests.testLineLengthConfigurationThrowsOnBadConfigValues
* LineLengthRuleTests.testLineLengthWithIgnoreCommentsEnabled
* LineLengthRuleTests.testLineLengthWithIgnoreFunctionDeclarationsEnabled
* RegionTests.testSeveralRegionsFromSeveralCommands
2017-06-02 14:28:37 -07:00
b9bec52f11
use function syntax over closure syntax
2017-06-02 14:10:02 -07:00
90871bb2e2
Merge pull request #1575 from marcelofabri/extension_access_modifier
...
Add extension_access_modifier rule
2017-06-02 22:09:45 +02:00
332b51a4c2
Trigger violation on declarations with explicit ACL
2017-06-02 21:25:07 +02:00
d1c4502974
Fix issue in ExplicitTopLevelACLRule
2017-06-02 21:24:55 +02:00
441bece9da
Add extension_access_modifier rule
2017-06-02 21:24:55 +02:00
2ac58aa621
Merge pull request #1598 from realm/bugfix-1597
...
Fix false positive in empty_enum_arguments rule
2017-06-02 21:08:38 +02:00
2045780476
Merge pull request #1581 from marcelofabri/fix-1525
...
Don't trigger `discarded_notification_center_observer` when the observer is returned
2017-06-02 21:06:37 +02:00
7e256f4abe
Fix false positive in empty_enum_arguments rule
...
Fixes #1597
2017-06-02 13:27:56 +02:00
f23bdc00e0
warn not fail in Danger when changelog entry missing
2017-06-01 17:01:34 -07:00
2628c9e858
Merge pull request #1582 from nevil/ah-void-wrapped-in-paren
...
Match `(Void)` as return type in the `void_return` rule
2017-05-29 10:13:06 +02:00
Cihat Gündüz
Cihat Gündüz
Marcelo Fabri
Marcelo Fabri
Marcelo Fabri
JP Simard
Otávio Lima
변우식