GitHub/SwiftLint
1
0
Fork 0
mirror of https://github.com/realm/SwiftLint.git synced 2026-05-07 20:12:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use is instead of as for simple type checks

Browse Source
This commit is contained in:
Danny Mösch
2023-03-12 11:37:53 +01:00
parent a2facce70c
commit cf1e2e27dc
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/SwiftLintFramework/Rules/Style/PreferSelfInStaticReferencesRule.swift
+5 -5
View File
@@ -305,12 +305,12 @@ private class Visitor: ViolationsSyntaxVisitor {
override func visitPost(_ node: IdentifierExprSyntax) {
guard let parent = node.parent,
parent.as(SpecializeExprSyntax.self) == nil,
parent.as(DictionaryElementSyntax.self) == nil,
parent.as(ArrayElementSyntax.self) == nil else {
!parent.is(SpecializeExprSyntax.self),
!parent.is(DictionaryElementSyntax.self),
!parent.is(ArrayElementSyntax.self) else {
return
}
if parent.as(FunctionCallExprSyntax.self) != nil, case .likeClass(_, false) = parentDeclScopes.last {
if parent.is(FunctionCallExprSyntax.self), case .likeClass(_, false) = parentDeclScopes.last {
return
}
addViolation(on: node.identifier)
@@ -362,7 +362,7 @@ private class Visitor: ViolationsSyntaxVisitor {
}
override func visitPost(_ node: SimpleTypeIdentifierSyntax) {
if node.parent?.as(KeyPathExprSyntax.self) != nil {
if node.parent?.is(KeyPathExprSyntax.self) == true {
addViolation(on: node.name)
}
}