Fail in debug builds if a rule produces corrections while not being correctable (#5684)

2026-05-07 20:12:49 +00:00 · 2024-07-20 19:11:55 +02:00
parent cb0f5ab007
commit b63807de6d
1 changed files with 6 additions and 1 deletions
@@ -46,8 +46,13 @@ public extension SwiftSyntaxRule {
            return []
        }

-        return makeVisitor(file: file)
+        let violations = makeVisitor(file: file)
            .walk(tree: syntaxTree, handler: \.violations)
+        assert(
+            violations.allSatisfy { $0.correction == nil || self is any SwiftSyntaxCorrectableRule },
+            "\(Self.self) produced corrections without being correctable."
+        )
+        return violations
            .sorted()
            .map { makeViolation(file: file, violation: $0) }
    }