GitHub/SwiftLint
1
0
Fork 0
mirror of https://github.com/realm/SwiftLint.git synced 2026-06-06 20:18:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ValidIBInspectable rule implementation

Browse Source 
1. `NSNumber` is not IB-inspectable at all.
2. Explicitly typed `Optional`s and `ImplicitlyUnwrappedOptional`s aren't
   supported by `@IBInspectable`, reference type or not.
This commit is contained in:
Daniel Duan
2016-11-28 14:40:06 -08:00
parent e63c6ce417
commit 7d4e0aed94
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+3
View File
@@ -45,6 +45,9 @@
##### Bug Fixes
* Rule out a few invalid `@IBInspectable` cases in `valid_ibinspectable`.
[Daniel Duan](https://github.com/dduan)
* Fix a few edge cases where malformed `MARK:` comments wouldn't trigger a
violation.
[JP Simard](https://github.com/jpsim)
Source/SwiftLintFramework/Rules/ValidIBInspectableRule.swift
+5 -9
View File
@@ -24,8 +24,6 @@ public struct ValidIBInspectableRule: ASTRule, ConfigurationProviderRule {
"class Foo {\n @IBInspectable private var x: Int\n}\n",
"class Foo {\n @IBInspectable private var x: String?\n}\n",
"class Foo {\n @IBInspectable private var x: String!\n}\n",
"class Foo {\n @IBInspectable private var x: ImplicitlyUnwrappedOptional<String>\n}\n",
"class Foo {\n @IBInspectable private var x: Optional<String>\n}\n",
"class Foo {\n @IBInspectable private var count: Int = 0\n}\n",
"class Foo {\n private var notInspectable = 0\n}\n",
"class Foo {\n private let notInspectable: Int\n}\n"
@@ -37,7 +35,9 @@ public struct ValidIBInspectableRule: ASTRule, ConfigurationProviderRule {
"class Foo {\n @IBInspectable private var count: Int?\n}\n",
"class Foo {\n @IBInspectable private var count: Int!\n}\n",
"class Foo {\n @IBInspectable private var x: ImplicitlyUnwrappedOptional<Int>\n}\n",
"class Foo {\n @IBInspectable private var count: Optional<Int>\n}\n"
"class Foo {\n @IBInspectable private var count: Optional<Int>\n}\n",
"class Foo {\n @IBInspectable private var x: Optional<String>\n}\n",
"class Foo {\n @IBInspectable private var x: ImplicitlyUnwrappedOptional<String>\n}\n"
]
)
@@ -85,8 +85,7 @@ public struct ValidIBInspectableRule: ASTRule, ConfigurationProviderRule {
"UIColor",
"NSColor",
"UIImage",
"NSImage",
"NSNumber"
"NSImage"
]
let types = [
@@ -104,10 +103,7 @@ public struct ValidIBInspectableRule: ASTRule, ConfigurationProviderRule {
]
// It seems that only reference types can be used as ImplicitlyUnwrappedOptional or Optional
return referenceTypes.flatMap {
[$0, $0 + "!", $0 + "?",
"ImplicitlyUnwrappedOptional<\($0)>", "Optional<\($0)>"] + types
}
return referenceTypes.flatMap { [$0, $0 + "!", $0 + "?"] } + types
}
private func violation(dictionary: [String: SourceKitRepresentable],