feat: BUMP version 1.2.3

fix: Typos in README and method signature

CHANGELOG.md

@@ -1,6 +1,16 @@
 # Change Log
 All notable changes to this project will be documented in this file
 
+## [Typo (1.2.3)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.3)
+
+### Fixes
+
+- Fix typo in `SkeletonTableViewDataSource` protocol
+
+### Improvements
+
+- Now it takes in account the `UIStackView` to calculate the `SkeletonLayer` bounds (thanks @giantramen)
+
 ## [New face (1.2.2)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.2)
 
 ### New
@@ -8,7 +18,7 @@ All notable changes to this project will be documented in this file
 - Rebranding
 
 ### Bug fixes
-- Solved issue [#23](https://github.com/Juanpe/SkeletonView/issues/23). Problem with UIStackView . (thanks @giantramen )
+- Solved issue [#23](https://github.com/Juanpe/SkeletonView/issues/23). Problem with UIStackView. (thanks @giantramen)
 
 ## [State (1.2.1)](https://github.com/Juanpe/SkeletonView/releases/tag/1.2.1)
 

Example/ViewController.swift

@@ -136,7 +136,7 @@ extension ViewController: SkeletonTableViewDataSource {
         return 9
     }
     
-    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
         return "CellIdentifier"
     }
     

README.md

@@ -51,7 +51,7 @@ Enjoy it! 🙂
   * [Hierarchy](#-hierarchy)
 * [Documentation](#-documentation)
 * [Next steps](#-next-steps)
-* [Contributed](#-contributed)
+* [Contributing](#-contributing)
 * [Mentions](#-mentions)
 * [Author](#-author)
 * [License](#-license)
@@ -171,7 +171,7 @@ If you want to show the skeleton in a ```UITableView```, you need to conform to
 public protocol SkeletonTableViewDataSource: UITableViewDataSource {
     func numSections(in collectionSkeletonView: UITableView) -> Int
     func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection section: Int) -> Int
-    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
 }
 ```
 As you can see, this protocol inherits from ```UITableViewDataSource```, so you can replace this protocol with the skeleton protocol.
@@ -191,12 +191,12 @@ func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection s
 
 There is only one method you need to implement to let Skeleton know the cell identifier. This method doesn't have default implementation:
  ``` swift
- func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
+ func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
  ```
 
 **Example**
  ``` swift
- func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
+ func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
     return "CellIdentifier"
 }
  ```
@@ -313,7 +313,7 @@ view.showAnimatedGradientSkeleton(usingGradient: gradient, animation: animation)
 |------- | -------
 | .leftRight | ![](Assets/sliding_left_to_right.gif)
 | .rightLeft | ![](Assets/sliding_right_to_left.gif)
-| .topBottom | ![](Assets/sliding_top_to_bottom.gif)  
+| .topBottom | ![](Assets/sliding_top_to_bottom.gif)
 | .bottomTop | ![](Assets/sliding_bottom_to_top.gif)
 | .topLeftBottomRight | ![](Assets/sliding_topLeft_to_bottomRight.gif)
 | .bottomRightTopLeft | ![](Assets/sliding_bottomRight_to_topLeft.gif)
@@ -354,7 +354,7 @@ Coming soon...😅
 * [ ] Add animations when it shows/hides the skeletons
 * [ ] MacOS and WatchOS compatible
 
-## ❤️ Contributed
+## ❤️ Contributing
 This is an open source project, so feel free to contribute. How?
 - Open an [issue](https://github.com/Juanpe/SkeletonView/issues/new).
 - Send feedback via [email](mailto://juanpecatalan.com).

SkeletonView.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name         = "SkeletonView"
-  s.version      = "1.2.2"
+  s.version      = "1.2.3"
   s.summary      = "An elegant way to show users that something is happening and also prepare them to which contents he is waiting"
   s.description  = <<-DESC
   Today almost all apps have async processes, as API requests, long runing processes, etc. And while the processes are working, usually developers place a loading view to show users that something is going on.

Sources/Collections/SkeletonCollectionDataSource.swift

@@ -36,7 +36,7 @@ extension SkeletonCollectionDataSource: UITableViewDataSource {
     }
     
     func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
-        let cellIdentifier = originalTableViewDataSource?.collectionSkeletonView(tableView, cellIdenfierForRowAt: indexPath) ?? ""
+        let cellIdentifier = originalTableViewDataSource?.collectionSkeletonView(tableView, cellIdentifierForRowAt: indexPath) ?? ""
         let cell = tableView.dequeueReusableCell(withIdentifier: cellIdentifier, for: indexPath)
         return cell
     }

Sources/Collections/TableViews/SkeletonTableViewProtocols.swift

@@ -11,7 +11,7 @@ import UIKit
 public protocol SkeletonTableViewDataSource: UITableViewDataSource {
     func numSections(in collectionSkeletonView: UITableView) -> Int
     func collectionSkeletonView(_ skeletonView: UITableView, numberOfRowsInSection section: Int) -> Int
-    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdentifierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier
 }
 
 public extension SkeletonTableViewDataSource {
@@ -21,6 +21,13 @@ public extension SkeletonTableViewDataSource {
     }
     
     func numSections(in collectionSkeletonView: UITableView) -> Int { return 1 }
+
+    /// Keeping the misspelled version around until it can be deprecated
+    /// Right now, it just calls the new correctly spelled method and returns its result
+    @available(*, deprecated, renamed: "collectionSkeletonView(_:cellIdentifierForRowAt:)")
+    func collectionSkeletonView(_ skeletonView: UITableView, cellIdenfierForRowAt indexPath: IndexPath) -> ReusableCellIdentifier {
+        return collectionSkeletonView(skeletonView, cellIdentifierForRowAt: indexPath)
+    }
 }
 
 public protocol SkeletonTableViewDelegate: UITableViewDelegate {

Sources/Extensions/UIView+Frame.swift

@@ -12,6 +12,18 @@ import UIKit
 extension UIView {
     
     var maxBoundsEstimated: CGRect {
+        if let parentStackView = (superview as? UIStackView) {
+            var origin: CGPoint = .zero
+            switch parentStackView.alignment {
+            case .center:
+                origin.x = maxWidthEstimated / 2
+            case .trailing:
+                origin.x = maxWidthEstimated
+            default:
+                break
+            }
+            return CGRect(origin: origin, size: maxSizeEstimated)
+        }
         return CGRect(origin: .zero, size: maxSizeEstimated)
     }