Updated podspec and README for cocoapods.

Corrected logic for default menu width.
Merge pull request #261 from jonkykong/add-code-of-conduct-1-1
2017-09-26 23:46:56 -07:00 · 2017-09-26 23:42:32 -07:00 · 2017-09-21 13:41:10 -07:00 · 2017-09-21 13:40:46 -07:00 · 2017-09-21 13:31:08 -07:00 · 2017-09-21 04:49:43 -07:00
12 changed files with 214 additions and 100 deletions
@@ -1,5 +1,4 @@
-<!--- Provide a general summary of your changes in the Title above -->
-<!--- IF YOU DELETE OR IGNORE THIS TEMPLATE WHEN OPENING A NEW ISSUE, YOUR ISSUE WILL BE IGNORED -->
+<!--- IF YOU DELETE OR IGNORE THIS TEMPLATE YOUR ISSUE WILL BE IGNORED AND CLOSED -->
 ## New Issue Checklist
 <!--- Please complete all of the checks below before submitting a new issue (complete a check by marking it [x] with no spaces) -->
 I have read the [guidelines for contributing](https://github.com/jonkykong/SideMenu/blob/master/.github/CONTRIBUTING.md) and I understand:
@@ -0,0 +1,46 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at yo@massappeal.co. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/
@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="12121" systemVersion="16F73" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="yAA-s6-Bam">
+<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="13196" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="yAA-s6-Bam">
    <device id="retina4_7" orientation="portrait">
        <adaptation id="fullscreen"/>
    </device>
    <dependencies>
        <deployment identifier="iOS"/>
-        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="12089"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="13173"/>
        <capability name="Constraints to layout margins" minToolsVersion="6.0"/>
        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
    </dependencies>
@@ -15,7 +15,7 @@
            <objects>
                <navigationController id="yAA-s6-Bam" sceneMemberID="viewController">
                    <navigationBar key="navigationBar" contentMode="scaleToFill" barStyle="black" id="Bue-4e-bCJ">
-                        <rect key="frame" x="0.0" y="0.0" width="320" height="44"/>
+                        <rect key="frame" x="0.0" y="20" width="375" height="44"/>
                        <autoresizingMask key="autoresizingMask"/>
                        <gestureRecognizers/>
                        <color key="tintColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
@@ -42,7 +42,7 @@
                        <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                        <subviews>
                            <scrollView clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="LFJ-SB-Zp9">
-                                <rect key="frame" x="0.0" y="0.0" width="375" height="635"/>
+                                <rect key="frame" x="0.0" y="64" width="375" height="571"/>
                                <subviews>
                                    <view contentMode="scaleToFill" translatesAutoresizingMaskIntoConstraints="NO" id="DMn-tw-NTB">
                                        <rect key="frame" x="0.0" y="0.0" width="375" height="469"/>
@@ -205,9 +205,9 @@
                        </subviews>
                        <color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
                        <constraints>
-                            <constraint firstItem="LFJ-SB-Zp9" firstAttribute="top" secondItem="0gg-po-Ih1" secondAttribute="topMargin" id="0T7-Dc-CaB"/>
                            <constraint firstItem="LFJ-SB-Zp9" firstAttribute="leading" secondItem="0gg-po-Ih1" secondAttribute="leading" id="OsA-4z-Y7t"/>
                            <constraint firstItem="ma4-O6-wOT" firstAttribute="top" secondItem="LFJ-SB-Zp9" secondAttribute="bottom" constant="8" id="UUi-lo-0RA"/>
+                            <constraint firstItem="LFJ-SB-Zp9" firstAttribute="top" secondItem="Rm7-bv-OCN" secondAttribute="bottom" id="W6M-QX-I2w"/>
                            <constraint firstItem="ma4-O6-wOT" firstAttribute="centerX" secondItem="0gg-po-Ih1" secondAttribute="centerX" id="aia-PT-OH3"/>
                            <constraint firstItem="LW0-9z-RHu" firstAttribute="top" secondItem="ma4-O6-wOT" secondAttribute="bottom" constant="8" id="d5Q-Sj-0Xz"/>
                            <constraint firstItem="LFJ-SB-Zp9" firstAttribute="top" secondItem="Rm7-bv-OCN" secondAttribute="bottom" id="ssi-ps-a2k"/>
@@ -252,7 +252,6 @@
                <navigationController storyboardIdentifier="LeftMenuNavigationController" navigationBarHidden="YES" id="DuX-EW-0mP" customClass="UISideMenuNavigationController" customModule="SideMenu" sceneMemberID="viewController">
                    <navigationItem key="navigationItem" id="ipz-Lx-Wgf"/>
                    <navigationBar key="navigationBar" contentMode="scaleToFill" id="35F-wh-r6h">
-                        <rect key="frame" x="0.0" y="0.0" width="320" height="44"/>
                        <autoresizingMask key="autoresizingMask"/>
                    </navigationBar>
                    <userDefinedRuntimeAttributes>
@@ -387,7 +386,6 @@
            <objects>
                <navigationController storyboardIdentifier="RightMenuNavigationController" navigationBarHidden="YES" id="z7k-fk-pfc" customClass="UISideMenuNavigationController" customModule="SideMenu" sceneMemberID="viewController">
                    <navigationBar key="navigationBar" contentMode="scaleToFill" id="qOd-yQ-2i8">
-                        <rect key="frame" x="0.0" y="0.0" width="320" height="44"/>
                        <autoresizingMask key="autoresizingMask"/>
                    </navigationBar>
                    <connections>
@@ -589,7 +587,7 @@
                        <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                        <subviews>
                            <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="roundedRect" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="a17-pq-WAQ">
-                                <rect key="frame" x="0.0" y="0.0" width="375" height="667"/>
+                                <rect key="frame" x="0.0" y="20" width="375" height="647"/>
                                <state key="normal" title="Dismiss">
                                    <color key="titleColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
                                </state>
@@ -18,7 +18,7 @@

 open class SideMenuManager : NSObject {
    
-    @objc public enum MenuPushStyle : Int {
+    public enum MenuPushStyle : Int {
        case defaultBehavior,
        popWhenPossible,
        replace,
@@ -27,7 +27,7 @@ open class SideMenuManager : NSObject {
        subMenu
    }
    
-    @objc public enum MenuPresentMode : Int {
+    public enum MenuPresentMode : Int {
        case menuSlideIn,
        viewSlideOut,
        viewSlideInOut,
@@ -66,9 +66,13 @@ open class SideMenuManager : NSObject {
    
    /// Prevents the same view controller (or a view controller of the same class) from being pushed more than once. Defaults to true.
    open static var menuAllowPushOfSameClassTwice = true
-    
-    /// Width of the menu when presented on screen, showing the existing view controller in the remaining space. Default is 75% of the screen width.
-    open static var menuWidth: CGFloat = max(round(min((appScreenRect.width), (appScreenRect.height)) * 0.75), 240)
+
+    /**
+     Width of the menu when presented on screen, showing the existing view controller in the remaining space. Default is 75% of the screen width or 240 points, whichever is smaller.
+     
+     Note that each menu's width can be overridden using the `menuWidth` property on any `UISideMenuNavigationController` instance.
+     */
+    open static var menuWidth: CGFloat = min(round(min((appScreenRect.width), (appScreenRect.height)) * 0.75), 240)
    
    /// Duration of the animation when the menu is presented without gestures. Default is 0.35 seconds.
    open static var menuAnimationPresentDuration: Double = 0.35
@@ -76,8 +80,8 @@ open class SideMenuManager : NSObject {
    /// Duration of the animation when the menu is dismissed without gestures. Default is 0.35 seconds.
    open static var menuAnimationDismissDuration: Double = 0.35
    
-    /// Duration of the remaining animation when the menu is partially dismissed with gestures. Default is 0.2 seconds.
-    open static var menuAnimationCompleteGestureDuration: Double = 0.20
+    /// Duration of the remaining animation when the menu is partially dismissed with gestures. Default is 0.35 seconds.
+    open static var menuAnimationCompleteGestureDuration: Double = 0.35
    
    /// Amount to fade the existing view controller when the menu is presented. Default is 0 for no fade. Set to 1 to fade completely.
    open static var menuAnimationFadeStrength: CGFloat = 0
@@ -14,8 +14,22 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
    fileprivate var interactive = false
    fileprivate static weak var originalSuperview: UIView?
    fileprivate static weak var activeGesture: UIGestureRecognizer?
-    fileprivate static var switchMenus = false
-    
+    fileprivate static var switchMenus = false {
+        didSet {
+            if switchMenus {
+                singleton.cancel()
+            }
+        }
+    }
+    fileprivate static var menuWidth: CGFloat {
+        get {
+            let overriddenWidth = viewControllerForMenu?.menuWidth ?? 0
+            if overriddenWidth > CGFloat.ulpOfOne {
+                return overriddenWidth
+            }
+            return SideMenuManager.menuWidth
+        }
+    }
    internal static let singleton = SideMenuTransition()
    internal static var presentDirection: UIRectEdge = .left
    internal static weak var tapView: UIView? {
@@ -39,11 +53,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
                return
            }
            
-            if let menuShrinkBackgroundColor = SideMenuManager.menuAnimationBackgroundColor {
-                statusBarView.backgroundColor = menuShrinkBackgroundColor
-            } else {
-                statusBarView.backgroundColor = UIColor.black
-            }
+            statusBarView.backgroundColor = SideMenuManager.menuAnimationBackgroundColor ?? UIColor.black
            statusBarView.isUserInteractionEnabled = false
        }
    }
@@ -89,17 +99,17 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        return viewController
    }
    
-    internal class func handlePresentMenuLeftScreenEdge(_ edge: UIScreenEdgePanGestureRecognizer) {
+    @objc internal class func handlePresentMenuLeftScreenEdge(_ edge: UIScreenEdgePanGestureRecognizer) {
        SideMenuTransition.presentDirection = .left
        handlePresentMenuPan(edge)
    }
    
-    internal class func handlePresentMenuRightScreenEdge(_ edge: UIScreenEdgePanGestureRecognizer) {
+    @objc internal class func handlePresentMenuRightScreenEdge(_ edge: UIScreenEdgePanGestureRecognizer) {
        SideMenuTransition.presentDirection = .right
        handlePresentMenuPan(edge)
    }
    
-    internal class func handlePresentMenuPan(_ pan: UIPanGestureRecognizer) {
+    @objc internal class func handlePresentMenuPan(_ pan: UIPanGestureRecognizer) {
        if activeGesture == nil {
            activeGesture = pan
        } else if pan != activeGesture {
@@ -139,7 +149,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        }
        
        let direction: CGFloat = SideMenuTransition.presentDirection == .left ? 1 : -1
-        let distance = translation.x / SideMenuManager.menuWidth
+        let distance = translation.x / menuWidth
        // now lets deal with different states that the gesture recognizer sends
        switch (pan.state) {
        case .began, .changed:
@@ -148,11 +158,9 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
            } else if distance > 0 && SideMenuTransition.presentDirection == .right && SideMenuManager.menuLeftNavigationController != nil {
                SideMenuTransition.presentDirection = .left
                switchMenus = true
-                singleton.cancel()
            } else if distance < 0 && SideMenuTransition.presentDirection == .left && SideMenuManager.menuRightNavigationController != nil {
                SideMenuTransition.presentDirection = .right
                switchMenus = true
-                singleton.cancel()
            } else {
                singleton.update(min(distance * direction, 1))
            }
@@ -173,7 +181,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        }
    }
    
-    internal class func handleHideMenuPan(_ pan: UIPanGestureRecognizer) {
+    @objc internal class func handleHideMenuPan(_ pan: UIPanGestureRecognizer) {
        if activeGesture == nil {
            activeGesture = pan
        } else if pan != activeGesture {
@@ -184,7 +192,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        
        let translation = pan.translation(in: pan.view!)
        let direction:CGFloat = SideMenuTransition.presentDirection == .left ? -1 : 1
-        let distance = translation.x / SideMenuManager.menuWidth * direction
+        let distance = translation.x / menuWidth * direction
        
        switch (pan.state) {
            
@@ -210,7 +218,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        }
    }
    
-    internal class func handleHideMenuTap(_ tap: UITapGestureRecognizer) {
+    @objc internal class func handleHideMenuTap(_ tap: UITapGestureRecognizer) {
        presentingViewControllerForMenu?.dismiss(animated: true, completion: nil)
    }
    
@@ -225,7 +233,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        mainViewController.view.frame.origin.y = 0
        menuView.transform = .identity
        menuView.frame.origin.y = 0
-        menuView.frame.size.width = SideMenuManager.menuWidth
+        menuView.frame.size.width = menuWidth
        menuView.frame.size.height = mainViewController.view.frame.height // in case status bar height changed
        var statusBarFrame = UIApplication.shared.statusBarFrame
        let statusBarOffset = SideMenuManager.appScreenRect.size.height - mainViewController.view.frame.maxY
@@ -241,7 +249,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
            
        case .viewSlideOut:
            menuView.alpha = 1 - SideMenuManager.menuAnimationFadeStrength
-            menuView.frame.origin.x = SideMenuTransition.presentDirection == .left ? 0 : mainViewController.view.frame.width - SideMenuManager.menuWidth
+            menuView.frame.origin.x = SideMenuTransition.presentDirection == .left ? 0 : mainViewController.view.frame.width - menuWidth
            mainViewController.view.frame.origin.x = 0
            menuView.transform = CGAffineTransform(scaleX: SideMenuManager.menuAnimationTransformScaleFactor, y: SideMenuManager.menuAnimationTransformScaleFactor)
            
@@ -256,7 +264,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
            
        case .menuDissolveIn:
            menuView.alpha = 0
-            menuView.frame.origin.x = SideMenuTransition.presentDirection == .left ? 0 : mainViewController.view.frame.width - SideMenuManager.menuWidth
+            menuView.frame.origin.x = SideMenuTransition.presentDirection == .left ? 0 : mainViewController.view.frame.width - menuWidth
            mainViewController.view.frame.origin.x = 0
        }
    }
@@ -290,9 +298,9 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        
        menuView.alpha = 1
        menuView.transform = .identity
-        menuView.frame.size.width = SideMenuManager.menuWidth
+        menuView.frame.size.width = menuWidth
        let size = SideMenuManager.appScreenRect.size
-        menuView.frame.origin.x = SideMenuTransition.presentDirection == .left ? 0 : size.width - SideMenuManager.menuWidth
+        menuView.frame.origin.x = SideMenuTransition.presentDirection == .left ? 0 : size.width - menuWidth
        mainViewController.view.transform = .identity
        mainViewController.view.frame.size.width = size.width
        let statusBarOffset = size.height - menuView.bounds.height
@@ -365,7 +373,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition {
        }
    }
    
-    internal func handleNotification(notification: NSNotification) {
+    @objc internal func handleNotification(notification: NSNotification) {
        guard let mainViewController = SideMenuTransition.presentingViewControllerForMenu,
            let menuViewController = SideMenuTransition.viewControllerForMenu,
            menuViewController.presentedViewController == nil && menuViewController.presentingViewController != nil else {
@@ -512,7 +520,7 @@ extension SideMenuTransition: UIViewControllerAnimatedTransitioning {
        let duration = transitionDuration(using: transitionContext)
        if interactive {
            UIView.animate(withDuration: duration,
-                           delay: 0,
+                           delay: duration, // HACK: If zero, the animation briefly flashes in iOS 11. UIViewPropertyAnimators (iOS 10+) may resolve this.
                           options: .curveLinear,
                           animations: {
                            animate()
@@ -541,6 +549,13 @@ extension SideMenuTransition: UIViewControllerAnimatedTransitioning {
        return presenting ? SideMenuManager.menuAnimationPresentDuration : SideMenuManager.menuAnimationDismissDuration
    }
    
+    open override func update(_ percentComplete: CGFloat) {
+        guard !SideMenuTransition.switchMenus else {
+            return
+        }
+        
+        super.update(percentComplete)
+    }
 }

 extension SideMenuTransition: UIViewControllerTransitioningDelegate {
@@ -9,6 +9,9 @@ import UIKit

 open class UISideMenuNavigationController: UINavigationController {
    
+    /// Width of the menu when presented on screen, showing the existing view controller in the remaining space. Default is zero. When zero, `SideMenuManager.menuWidth` is used.
+    @IBInspectable open var menuWidth: CGFloat = 0
+    
    internal var originalMenuBackgroundColor: UIColor?
    
    open override func awakeFromNib() {
@@ -85,16 +88,18 @@ open class UISideMenuNavigationController: UINavigationController {
                }
            }
            
-            // We're presenting a view controller from the menu, so we need to hide the menu so it isn't showing when the presented view is dismissed.
-            UIView.animate(withDuration: SideMenuManager.menuAnimationDismissDuration,
-                           delay: 0,
-                           usingSpringWithDamping: SideMenuManager.menuAnimationUsingSpringWithDamping,
-                           initialSpringVelocity: SideMenuManager.menuAnimationInitialSpringVelocity,
-                           options: SideMenuManager.menuAnimationOptions,
-                           animations: {
-                            SideMenuTransition.hideMenuStart()
-            }) { (finished) -> Void in
-                self.view.isHidden = true
+            if SideMenuManager.menuDismissOnPush {
+                // We're presenting a view controller from the menu, so we need to hide the menu so it isn't showing when the presented view is dismissed.
+                UIView.animate(withDuration: SideMenuManager.menuAnimationDismissDuration,
+                               delay: 0,
+                               usingSpringWithDamping: SideMenuManager.menuAnimationUsingSpringWithDamping,
+                               initialSpringVelocity: SideMenuManager.menuAnimationInitialSpringVelocity,
+                               options: SideMenuManager.menuAnimationOptions,
+                               animations: {
+                                SideMenuTransition.hideMenuStart()
+                }) { (finished) -> Void in
+                    self.view.isHidden = true
+                }
            }
        }
    }
@@ -102,8 +107,17 @@ open class UISideMenuNavigationController: UINavigationController {
    override open func viewDidDisappear(_ animated: Bool) {
        super.viewDidDisappear(animated)
        
-        // Hack: force selection to get cleared on UITableViewControllers when reappearing using custom transitions
-        visibleViewController?.viewWillAppear(false)
+        // Clear selecton on UITableViewControllers when reappearing using custom transitions
+        guard let tableViewController = topViewController as? UITableViewController,
+            let tableView = tableViewController.tableView,
+            let indexPaths = tableView.indexPathsForSelectedRows,
+            tableViewController.clearsSelectionOnViewWillAppear else {
+            return
+        }
+        
+        for indexPath in indexPaths {
+            tableView.deselectRow(at: indexPath, animated: false)
+        }
    }
    
    override open func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {
@@ -122,20 +136,6 @@ open class UISideMenuNavigationController: UINavigationController {
        }
    }
    
-    override open func prepare(for segue: UIStoryboardSegue, sender: Any?) {
-        if let presentingViewController = presentingViewController {
-            presentingViewController.prepare(for: segue, sender: sender)
-        }
-    }
-    
-    override open func shouldPerformSegue(withIdentifier identifier: String, sender: Any?) -> Bool {
-        if let presentingViewController = presentingViewController {
-            return presentingViewController.shouldPerformSegue(withIdentifier: identifier, sender: sender)
-        }
-        
-        return super.shouldPerformSegue(withIdentifier: identifier, sender: sender)
-    }
-    
    override open func pushViewController(_ viewController: UIViewController, animated: Bool) {
        guard viewControllers.count > 0 && SideMenuManager.menuPushStyle != .subMenu else {
            // NOTE: pushViewController is called by init(rootViewController: UIViewController)
@@ -144,9 +144,11 @@ open class UISideMenuNavigationController: UINavigationController {
            return
        }

+        let splitViewController = presentingViewController as? UISplitViewController
        let tabBarController = presentingViewController as? UITabBarController
-        guard let navigationController = (tabBarController?.selectedViewController ?? presentingViewController) as? UINavigationController else {
-            print("SideMenu Warning: attempt to push a View Controller from \(String(describing: presentingViewController.self)) where its navigationController == nil. It must be embedded in a Navigation Controller for this to work.")
+        let potentialNavigationController = (splitViewController?.viewControllers.first ?? tabBarController?.selectedViewController) ?? presentingViewController
+        guard let navigationController = potentialNavigationController as? UINavigationController else {
+            print("SideMenu Warning: attempt to push a View Controller from \(String(describing: potentialNavigationController.self)) where its navigationController == nil. It must be embedded in a Navigation Controller for this to work.")
            return
        }
        
@@ -14,6 +14,11 @@ open class UITableViewVibrantCell: UITableViewCell {
    fileprivate var vibrancySelectedBackgroundView:UIVisualEffectView = UIVisualEffectView()
    fileprivate var defaultSelectedBackgroundView:UIView?
    
+    // For registering with UITableView without subclassing otherwise dequeuing instance of the cell causes an exception
+    public override init(style: UITableViewCellStyle, reuseIdentifier: String?) {
+        super.init(style: style, reuseIdentifier: reuseIdentifier)
+    }
+    
    required public init?(coder aDecoder: NSCoder) {
        super.init(coder: aDecoder)
        
@@ -328,7 +328,7 @@
 			isa = PBXProject;
 			attributes = {
 				LastSwiftUpdateCheck = 0730;
-				LastUpgradeCheck = 0700;
+				LastUpgradeCheck = 0900;
 			};
 			buildConfigurationList = 2D8E8EC45A3A1A1D94AE762CB5028504 /* Build configuration list for PBXProject "Pods" */;
 			compatibilityVersion = "Xcode 3.2";
@@ -405,20 +405,30 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
+				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
+				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGNING_REQUIRED = NO;
 				COPY_PHASE_STRIP = NO;
+				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
 				GCC_DYNAMIC_NO_PIC = NO;
+				GCC_NO_COMMON_BLOCKS = YES;
 				GCC_OPTIMIZATION_LEVEL = 0;
 				GCC_PREPROCESSOR_DEFINITIONS = (
 					"POD_CONFIGURATION_DEBUG=1",
@@ -466,7 +476,7 @@
 				SDKROOT = iphoneos;
 				SKIP_INSTALL = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 				VERSIONING_SYSTEM = "apple-generic";
 				VERSION_INFO_PREFIX = "";
@@ -482,19 +492,29 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
+				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
+				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGNING_REQUIRED = NO;
 				COPY_PHASE_STRIP = YES;
 				ENABLE_NS_ASSERTIONS = NO;
+				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
+				GCC_NO_COMMON_BLOCKS = YES;
 				GCC_PREPROCESSOR_DEFINITIONS = (
 					"POD_CONFIGURATION_RELEASE=1",
 					"$(inherited)",
@@ -508,6 +528,7 @@
 				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
 				PROVISIONING_PROFILE_SPECIFIER = NO_SIGNING/;
 				STRIP_INSTALLED_PRODUCT = NO;
+				SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
 				SYMROOT = "${SRCROOT}/../build";
 				VALIDATE_PRODUCT = YES;
 			};
@@ -517,6 +538,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 3324698B7EF536D06111969551D7A984 /* Pods-Example.debug.xcconfig */;
 			buildSettings = {
+				ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
 				"CODE_SIGN_IDENTITY[sdk=appletvos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=watchos*]" = "";
@@ -553,6 +575,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = E84078875951590B4A5503E807E1791E /* Pods-Example.release.xcconfig */;
 			buildSettings = {
+				ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
 				"CODE_SIGN_IDENTITY[sdk=appletvos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=watchos*]" = "";
@@ -588,6 +611,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 7CAC7C8AA53EBC987714BAC240E7DE89 /* Pods-Example-ExampleTests.debug.xcconfig */;
 			buildSettings = {
+				ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
 				"CODE_SIGN_IDENTITY[sdk=appletvos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=watchos*]" = "";
@@ -624,6 +648,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 36CF7D6DA1B99FEA132A604D0BF8FB58 /* Pods-Example-ExampleTests.release.xcconfig */;
 			buildSettings = {
+				ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
 				"CODE_SIGN_IDENTITY[sdk=appletvos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
 				"CODE_SIGN_IDENTITY[sdk=watchos*]" = "";
@@ -680,7 +705,7 @@
 				PRODUCT_NAME = SideMenu;
 				SDKROOT = iphoneos;
 				SKIP_INSTALL = YES;
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
 				VERSIONING_SYSTEM = "apple-generic";
 				VERSION_INFO_PREFIX = "";
@@ -4,25 +4,25 @@
 [![License](https://img.shields.io/cocoapods/l/SideMenu.svg?style=flat)](http://cocoapods.org/pods/SideMenu)
 [![Platform](https://img.shields.io/cocoapods/p/SideMenu.svg?style=flat)](http://cocoapods.org/pods/SideMenu)

-### If you like SideMenu, give it a ★ at the top right of this page.
+### If you like SideMenu, give it a ★ at the top right of its [GitHub](https://github.com/jonkykong/SideMenu) page.
 #### Using SideMenu in your app? [Send](mailto:yo@massappeal.co?subject=SideMenu%20in%20action!) me a link to your app in the app store!

 > Hi, I'm Jon Kent and I am an iOS designer, developer, and mobile strategist. I love coffee and play the drums.
 > * [**Hire me**](mailto:yo@massappeal.co?subject=Let's%20build%20something%20amazing) to help you make cool stuff. *Note: If you're having a problem with SideMenu, please open an [issue](https://github.com/jonkykong/SideMenu/issues/new) and do not email me.*
-> * [Website](http://massappeal.co).
+> * Check out my [website](http://massappeal.co) to see some of my other projects.
 > * Building and maintaining this free library takes time. Help keep me awake and buy me a coffee ☕️ via [PayPal](https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=contact%40jonkent%2eme&lc=US&currency_code=USD&bn=PP%2dDonationsBF%3abtn_donateCC_LG%2egif%3aNonHosted).

 ## Overview

 SideMenu is a simple and versatile side menu control written in Swift.
- * **It can be implemented in storyboard without a single line of [code](#code-less-storyboard-implementation).**
- * Four standard animation styles to choose from (there's even a parallax effect if you want to get weird).
- * Highly customizable without needing to write tons of custom code.
- * Supports continuous swiping between side menus on boths sides in a single gesture.
- * Global menu configuration. Set-up once and be done for all screens.
- * Menus can be presented and dismissed the same as any other view controller since this control uses [custom transitions](https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/CustomizingtheTransitionAnimations.html).
- * Animations use your view controllers, not snapshots.
- * Properly handles screen rotation and in-call status bar height changes.
+- [x] **It can be implemented in storyboard without a single line of [code](#code-less-storyboard-implementation).**
+- [x] Four standard animation styles to choose from (there's even a parallax effect if you want to get weird).
+- [x] Highly customizable without needing to write tons of custom code.
+- [x] Supports continuous swiping between side menus on boths sides in a single gesture.
+- [x] Global menu configuration. Set-up once and be done for all screens.
+- [x] Menus can be presented and dismissed the same as any other view controller since this control uses [custom transitions](https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/CustomizingtheTransitionAnimations.html).
+- [x] Animations use your view controllers, not snapshots.
+- [x] Properly handles screen rotation and in-call status bar height changes.

 Check out the example project to see it in action!
 ### Preview Samples
@@ -31,7 +31,7 @@ Check out the example project to see it in action!
 | ![](etc/SlideOut.gif) | ![](etc/SlideIn.gif) | ![](etc/Dissolve.gif) | ![](etc/InOut.gif) |

 ## Requirements
- * iOS 8 or higher
+- [x] iOS 8 or higher.

 ## Installation
 ### CocoaPods
@@ -51,8 +51,8 @@ use_frameworks!

 pod 'SideMenu'

-# For Swift 2.3 (no longer maintained), use:
-# pod 'SideMenu', '~> 1.2.1'
+# For Swift 3 (no longer maintained), use:
+# pod 'SideMenu', '~> 2.3.4'
 ```

 Then, run the following command:
@@ -123,9 +123,6 @@ present(SideMenuManager.menuLeftNavigationController!, animated: true, completio

 // Similarly, to dismiss a menu programmatically, you would do this:
 dismiss(animated: true, completion: nil)
-
-// For Swift 2.3 (no longer maintained), use:
-// presentViewController(SideMenuManager.menuLeftNavigationController!, animated: true, completion: nil)
 ```
 That's it.
 ### Customization
@@ -158,14 +155,21 @@ open static var menuPresentMode: MenuPresentMode = .viewSlideOut
 /// Prevents the same view controller (or a view controller of the same class) from being pushed more than once. Defaults to true.
 open static var menuAllowPushOfSameClassTwice = true

-/// Width of the menu when presented on screen, showing the existing view controller in the remaining space. Default is 75% of the screen width.
+/**
+Width of the menu when presented on screen, showing the existing view controller in the remaining space. Default is 75% of the screen width.
+
+Note that each menu's width can be overridden using the `menuWidth` property on any `UISideMenuNavigationController` instance.
+*/
 open static var menuWidth: CGFloat = max(round(min((appScreenRect.width), (appScreenRect.height)) * 0.75), 240)

 /// Duration of the animation when the menu is presented without gestures. Default is 0.35 seconds.
-open static var menuAnimationPresentDuration = 0.35
+open static var menuAnimationPresentDuration: Double = 0.35

 /// Duration of the animation when the menu is dismissed without gestures. Default is 0.35 seconds.
-open static var menuAnimationDismissDuration = 0.35
+open static var menuAnimationDismissDuration: Double = 0.35
+
+/// Duration of the remaining animation when the menu is partially dismissed with gestures. Default is 0.35 seconds.
+open static var menuAnimationCompleteGestureDuration: Double = 0.35

 /// Amount to fade the existing view controller when the menu is presented. Default is 0 for no fade. Set to 1 to fade completely.
 open static var menuAnimationFadeStrength: CGFloat = 0
@@ -8,7 +8,7 @@

 Pod::Spec.new do |s|
  s.name             = "SideMenu"
-  s.version          = "2.3.3"
+  s.version          = "3.0.2"
  s.summary          = "Simple side menu control for iOS in Swift inspired by Facebook. Right and Left sides. No coding required."

 # This description is used to generate tags and improve search results.
@@ -279,21 +279,23 @@
 			isa = PBXProject;
 			attributes = {
 				LastSwiftUpdateCheck = 0800;
-				LastUpgradeCheck = 0830;
+				LastUpgradeCheck = 0900;
 				ORGANIZATIONNAME = jonkykong;
 				TargetAttributes = {
 					7B48A0D21DCB2487002990A1 = {
 						CreatedOnToolsVersion = 8.0;
+						LastSwiftMigration = 0900;
 						ProvisioningStyle = Automatic;
 					};
 					7B48A0E51DCB2487002990A1 = {
 						CreatedOnToolsVersion = 8.0;
+						LastSwiftMigration = 0900;
 						ProvisioningStyle = Automatic;
 						TestTargetID = 7B48A0D21DCB2487002990A1;
 					};
 					7B9DC9031DC6E8C1000D4007 = {
 						CreatedOnToolsVersion = 8.0;
-						LastSwiftMigration = 0820;
+						LastSwiftMigration = 0900;
 						ProvisioningStyle = Automatic;
 					};
 				};
@@ -493,7 +495,7 @@
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
 				PRODUCT_BUNDLE_IDENTIFIER = com.jonkykong.Example;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 			};
 			name = Debug;
 		};
@@ -507,7 +509,7 @@
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
 				PRODUCT_BUNDLE_IDENTIFIER = com.jonkykong.Example;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 			};
 			name = Release;
 		};
@@ -521,7 +523,7 @@
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
 				PRODUCT_BUNDLE_IDENTIFIER = com.jonkykong.ExampleTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Example.app/Example";
 			};
 			name = Debug;
@@ -536,7 +538,7 @@
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
 				PRODUCT_BUNDLE_IDENTIFIER = com.jonkykong.ExampleTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Example.app/Example";
 			};
 			name = Release;
@@ -550,7 +552,9 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
@@ -558,7 +562,11 @@
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_SUSPICIOUS_MOVES = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
@@ -604,7 +612,9 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
@@ -612,7 +622,11 @@
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_SUSPICIOUS_MOVES = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
@@ -660,7 +674,7 @@
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SKIP_INSTALL = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 			};
 			name = Debug;
 		};
@@ -681,7 +695,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = com.jonkykong.SideMenu;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SKIP_INSTALL = YES;
-				SWIFT_VERSION = 3.0;
+				SWIFT_VERSION = 4.0;
 			};
 			name = Release;
 		};
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "0830"
+   LastUpgradeVersion = "0900"
   version = "1.3">
   <BuildAction
      parallelizeBuildables = "YES"
@@ -26,6 +26,7 @@
      buildConfiguration = "Debug"
      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      language = ""
      shouldUseLaunchSchemeArgsEnv = "YES">
      <Testables>
      </Testables>
@@ -36,6 +37,7 @@
      buildConfiguration = "Debug"
      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      language = ""
      launchStyle = "0"
      useCustomWorkingDirectory = "NO"
      ignoresPersistentStateOnLaunch = "NO"
Author	SHA1	Message	Date
jonkykong	bf241ec554	Updated podspec and README for cocoapods.	2017-09-26 23:46:56 -07:00
jonkykong	d867a67899	Corrected logic for default menu width.	2017-09-26 23:42:32 -07:00
Jon Kent	80213f5e88	Merge pull request #261 from jonkykong/add-code-of-conduct-1-1 Create CODE_OF_CONDUCT.md	2017-09-21 13:41:10 -07:00
Jon Kent	66cc6cad35	Create CODE_OF_CONDUCT.md	2017-09-21 13:40:46 -07:00
Jon Kent	db97060777	Update README.md	2017-09-21 13:31:08 -07:00
Jon Kent	4d32054356	Update README.md	2017-09-21 04:49:43 -07:00
jonkykong	432dfe988f	Updated README for Github.	2017-09-21 04:47:27 -07:00
jonkykong	1e8f091bb0	Merge tag '3.0.1' * tag '3.0.1': Updated podspec. Fixed hack to more specific logic.	2017-09-21 04:41:45 -07:00
jonkykong	f2df2e28d8	Updated podspec.	2017-09-21 04:41:11 -07:00
jonkykong	b6a2466dec	Fixed hack to more specific logic.	2017-09-21 04:40:42 -07:00
jonkykong	8bbe75d5c7	Merge tag '3.0.0' * tag '3.0.0': Updated podspec. Additional Swift4 support updates. Fix for Swift 4 and version 2.3.4	2017-09-21 04:25:21 -07:00
jonkykong	ad462962fd	Updated podspec.	2017-09-21 04:23:19 -07:00
jonkykong	6ed444f433	Merge branch 'pr/253' into 3.0.0 * pr/253: Additional Swift4 support updates. Fix for Swift 4 and version 2.3.4	2017-09-21 04:12:50 -07:00
jonkykong	a65e26cb47	Additional Swift4 support updates.	2017-09-21 02:59:40 -07:00
jonkykong	94610771b4	Merge tag '2.3.4' * tag '2.3.4': Updated README and podspec. Added comment. Changed menuAnimationCompleteGestureDuration default. Changing individual menu width properties in favor of a property on UISideMenuNavigationController. Refactor. Formatting. Support for UISplitViewControllers when pushing view controllers. These methods will never be called as they are handled by the topViewController. Neglected to use menuDismissOnPush switch in code. Fixes to maintain iOS 11 animation smoothness. Refactor. Changed MainViewController's scrollview to align to the topLayoutGuide. Add missing designated initialiser to UITableViewVibrantCell Set right menu width equal half of left menu width in example Add supporting of different left and right menu width	2017-09-21 02:04:58 -07:00
jonkykong	5599796e9d	Updated README and podspec.	2017-09-21 02:04:06 -07:00
jonkykong	33449c84a0	Merge branch 'pr/248' into 2.3.4 * pr/248: Added comment. Add missing designated initialiser to UITableViewVibrantCell	2017-09-21 01:53:02 -07:00
jonkykong	458b246013	Added comment.	2017-09-21 01:52:44 -07:00
jonkykong	a58a170979	Changed menuAnimationCompleteGestureDuration default.	2017-09-21 01:35:46 -07:00
jonkykong	e4c43569de	Merge branch 'pr/228' into 2.3.4 * pr/228: Changing individual menu width properties in favor of a property on UISideMenuNavigationController. Set right menu width equal half of left menu width in example Add supporting of different left and right menu width # Conflicts: # Pod/Classes/SideMenuTransition.swift	2017-09-21 01:34:34 -07:00
jonkykong	966e1c9976	Changing individual menu width properties in favor of a property on UISideMenuNavigationController.	2017-09-21 01:30:58 -07:00
jonkykong	1241215e53	Refactor.	2017-09-20 23:25:19 -07:00
jonkykong	09070849d8	Formatting.	2017-09-20 22:54:04 -07:00
jonkykong	8705078fa5	Support for UISplitViewControllers when pushing view controllers.	2017-09-20 22:51:40 -07:00
jonkykong	48a39b4573	These methods will never be called as they are handled by the topViewController.	2017-09-20 22:50:23 -07:00
jonkykong	3611a6f5b8	Neglected to use menuDismissOnPush switch in code.	2017-09-20 22:49:30 -07:00
jonkykong	701d482714	Fixes to maintain iOS 11 animation smoothness.	2017-09-20 22:48:39 -07:00
jonkykong	9574c37479	Refactor.	2017-09-20 22:48:14 -07:00
jonkykong	52faf9a7e1	Changed MainViewController's scrollview to align to the topLayoutGuide.	2017-09-20 22:47:56 -07:00
Ranjithkumar Matheswaran	05a3659255	Fix for Swift 4 and version 2.3.4	2017-08-31 18:30:48 +05:30
Mark Woollard	ef0c5fceed	Add missing designated initialiser to UITableViewVibrantCell So cell can be registered with UITableView without subclassing for simple use cases. Without this initialiser dequeuing instance of the cell will cause a crash.	2017-08-18 10:36:38 +01:00
Alex Kozin	eab7e274e8	Set right menu width equal half of left menu width in example	2017-07-20 18:16:59 +07:00
Alex Kozin	f9ec208e36	Add supporting of different left and right menu width	2017-07-20 18:16:01 +07:00
Jon Kent	6b9607fc9a	Update README.md	2017-07-02 12:33:44 -07:00
jonkykong	8ad4b3a4d9	Revert README for Github.	2017-06-30 16:56:34 -07:00
jonkykong	b0357d3f54	Merge tag '2.3.3' * tag '2.3.3': Updated podspec and README. Added menuDismissOnPush property. Fix for single menu setups losing ability to swipe menu if wrong side is swiped.	2017-06-30 16:51:36 -07:00
Jon Kent	2e54a9d21a	Create ISSUE_TEMPLATE.md	2017-06-08 01:45:53 -07:00