Update README for Cocoapods.

* tag '2.1.4':
  Silence warning.
  Update README for Cocoapods.
  Update podspec.
  Fix for multiple gestures causing crashes when presenting or dismissing menu. SideMenuTransition is due for a refactoring of logic to simplify that I don’t have time for now.
  Update to Launch Screen.
  Say “SideMenu” instead of “Example” in demo project.

.github/ISSUE_TEMPLATE.md

@@ -1,5 +1,5 @@
 <!--- Provide a general summary of your changes in the Title above -->
-
+<!--- IF YOU DELETE OR IGNORE THIS TEMPLATE WHEN OPENING A NEW ISSUE, YOUR ISSUE WILL BE IGNORED -->
 ## New Issue Checklist
 <!--- Please complete all of the checks below before submitting a new issue -->
 I have read the [guidelines for contributing](https://github.com/jonkykong/SideMenu/blob/master/.github/CONTRIBUTING.md) and I understand:

Example/Info.plist

@@ -4,6 +4,8 @@
 <dict>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>en</string>
+	<key>CFBundleDisplayName</key>
+	<string>SideMenu</string>
 	<key>CFBundleExecutable</key>
 	<string>$(EXECUTABLE_NAME)</string>
 	<key>CFBundleIdentifier</key>

Example/Launch Screen.storyboard

@@ -1,7 +1,11 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="11134" systemVersion="15F34" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" launchScreen="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="01J-lp-oVM">
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="11762" systemVersion="16C67" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" launchScreen="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="01J-lp-oVM">
+    <device id="retina4_7" orientation="portrait">
+        <adaptation id="fullscreen"/>
+    </device>
     <dependencies>
-        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="11106"/>
+        <deployment identifier="iOS"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="11757"/>
         <capability name="Constraints with non-1.0 multipliers" minToolsVersion="5.1"/>
         <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
     </dependencies>
@@ -18,12 +22,14 @@
                         <rect key="frame" x="0.0" y="0.0" width="375" height="667"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
-                            <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="  Copyright © 2016 jonkykong. All rights reserved." textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="obG-Y5-kRd">
+                            <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="  Copyright © 2016 Jon Kent. All rights reserved." textAlignment="center" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" minimumFontSize="9" translatesAutoresizingMaskIntoConstraints="NO" id="obG-Y5-kRd">
+                                <rect key="frame" x="20" y="626.5" width="335" height="21"/>
                                 <fontDescription key="fontDescription" type="system" pointSize="17"/>
                                 <color key="textColor" red="0.0" green="0.0" blue="0.0" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
                                 <nil key="highlightedColor"/>
                             </label>
                             <label opaque="NO" clipsSubviews="YES" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="SideMenu" textAlignment="center" lineBreakMode="middleTruncation" baselineAdjustment="alignBaselines" minimumFontSize="18" translatesAutoresizingMaskIntoConstraints="NO" id="GJd-Yh-RWb">
+                                <rect key="frame" x="20" y="202" width="335" height="43"/>
                                 <fontDescription key="fontDescription" type="boldSystem" pointSize="36"/>
                                 <color key="textColor" red="0.0" green="0.0" blue="0.0" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
                                 <nil key="highlightedColor"/>

Pod/Classes/SideMenuTransition.swift

@@ -17,8 +17,35 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition, UIViewContr
     
     internal static let singleton = SideMenuTransition()
     internal static var presentDirection: UIRectEdge = .left;
-    internal static weak var tapView: UIView?
-    internal static weak var statusBarView: UIView?
+    internal static weak var tapView: UIView? {
+        didSet {
+            guard let tapView = tapView else {
+                return
+            }
+            
+            tapView.autoresizingMask = [.flexibleHeight, .flexibleWidth]
+            let exitPanGesture = UIPanGestureRecognizer()
+            exitPanGesture.addTarget(SideMenuTransition.self, action:#selector(SideMenuTransition.handleHideMenuPan(_:)))
+            let exitTapGesture = UITapGestureRecognizer()
+            exitTapGesture.addTarget(SideMenuTransition.self, action: #selector(SideMenuTransition.handleHideMenuTap(_:)))
+            tapView.addGestureRecognizer(exitPanGesture)
+            tapView.addGestureRecognizer(exitTapGesture)
+        }
+    }
+    internal static weak var statusBarView: UIView? {
+        didSet {
+            guard let statusBarView = statusBarView else {
+                return
+            }
+            
+            if let menuShrinkBackgroundColor = SideMenuManager.menuAnimationBackgroundColor {
+                statusBarView.backgroundColor = menuShrinkBackgroundColor
+            } else {
+                statusBarView.backgroundColor = UIColor.black
+            }
+            statusBarView.isUserInteractionEnabled = false
+        }
+    }
     
     // prevent instantiation
     fileprivate override init() {}
@@ -154,7 +181,9 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition, UIViewContr
     internal class func hideMenuStart() {
         NotificationCenter.default.removeObserver(SideMenuTransition.singleton)
         guard let mainViewController = SideMenuTransition.viewControllerForPresentedMenu,
-            let menuView = SideMenuTransition.presentDirection == .left ? SideMenuManager.menuLeftNavigationController?.view : SideMenuManager.menuRightNavigationController?.view else {return}
+            let menuView = SideMenuTransition.presentDirection == .left ? SideMenuManager.menuLeftNavigationController?.view : SideMenuManager.menuRightNavigationController?.view else {
+                return
+        }
       
         menuView.transform = CGAffineTransform.identity
         mainViewController.view.transform = CGAffineTransform.identity
@@ -292,67 +321,45 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition, UIViewContr
         
         // get reference to our fromView, toView and the container view that we should perform the transition in
         let container = transitionContext.containerView
+        // prevent any other menu gestures from firing
+        container.isUserInteractionEnabled = false
+        
         if let menuBackgroundColor = SideMenuManager.menuAnimationBackgroundColor {
             container.backgroundColor = menuBackgroundColor
         }
         
-        // create a tuple of our screens
-        let screens : (from:UIViewController, to:UIViewController) = (transitionContext.viewController(forKey: UITransitionContextViewControllerKey.from)!, transitionContext.viewController(forKey: UITransitionContextViewControllerKey.to)!)
+        let fromViewController = transitionContext.viewController(forKey: UITransitionContextViewControllerKey.from)!
+        let toViewController = transitionContext.viewController(forKey: UITransitionContextViewControllerKey.to)!
         
         // assign references to our menu view controller and the 'bottom' view controller from the tuple
         // remember that our menuViewController will alternate between the from and to view controller depending if we're presenting or dismissing
-        let menuViewController = (!presenting ? screens.from : screens.to)
-        let topViewController = !presenting ? screens.to : screens.from
+        let menuViewController = presenting ? toViewController : fromViewController
+        let topViewController = presenting ? fromViewController : toViewController
         
-        let menuView = menuViewController.view
-        let topView = topViewController.view
+        let menuView = menuViewController.view!
+        let topView = topViewController.view!
         
         // prepare menu items to slide in
         if presenting {
-            var tapView: UIView?
-            if !SideMenuManager.menuPresentingViewControllerUserInteractionEnabled {
-                tapView = UIView()
-                tapView!.autoresizingMask = [.flexibleHeight, .flexibleWidth]
-                let exitPanGesture = UIPanGestureRecognizer()
-                exitPanGesture.addTarget(SideMenuTransition.self, action:#selector(SideMenuTransition.handleHideMenuPan(_:)))
-                let exitTapGesture = UITapGestureRecognizer()
-                exitTapGesture.addTarget(SideMenuTransition.self, action: #selector(SideMenuTransition.handleHideMenuTap(_:)))
-                tapView!.addGestureRecognizer(exitPanGesture)
-                tapView!.addGestureRecognizer(exitTapGesture)
-                SideMenuTransition.tapView = tapView
-            }
-            
-            SideMenuTransition.originalSuperview = topView?.superview
+            SideMenuTransition.originalSuperview = topView.superview
             
             // add the both views to our view controller
             switch SideMenuManager.menuPresentMode {
             case .viewSlideOut, .viewSlideInOut:
-                container.addSubview(menuView!)
-                container.addSubview(topView!)
-                if let tapView = tapView {
-                    topView?.addSubview(tapView)
-                }
+                container.addSubview(menuView)
+                container.addSubview(topView)
             case .menuSlideIn, .menuDissolveIn:
-                container.addSubview(topView!)
-                if let tapView = tapView {
-                    container.addSubview(tapView)
-                }
-                container.addSubview(menuView!)
+                container.addSubview(topView)
+                container.addSubview(menuView)
             }
-            
+
             if SideMenuManager.menuFadeStatusBar {
-                let blackBar = UIView()
-                if let menuShrinkBackgroundColor = SideMenuManager.menuAnimationBackgroundColor {
-                    blackBar.backgroundColor = menuShrinkBackgroundColor
-                } else {
-                    blackBar.backgroundColor = UIColor.black
-                }
-                blackBar.isUserInteractionEnabled = false
-                container.addSubview(blackBar)
-                SideMenuTransition.statusBarView = blackBar
+                let statusBarView = UIView()
+                SideMenuTransition.statusBarView = statusBarView
+                container.addSubview(statusBarView)
             }
             
-            SideMenuTransition.hideMenuStart() // offstage for interactive
+            SideMenuTransition.hideMenuStart()
         }
         
         // perform the animation!
@@ -360,12 +367,14 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition, UIViewContr
         let options: UIViewAnimationOptions = interactive ? .curveLinear : UIViewAnimationOptions()
         UIView.animate(withDuration: duration, delay: 0, options: options, animations: { () -> Void in
             if self.presenting {
-                SideMenuTransition.presentMenuStart() // onstage items: slide in
+                SideMenuTransition.presentMenuStart()
             } else {
                 SideMenuTransition.hideMenuStart()
             }
-            menuView?.isUserInteractionEnabled = false
         }) { (finished) -> Void in
+            
+            container.isUserInteractionEnabled = true
+            
             // tell our transitionContext object that we've finished animating
             if transitionContext.transitionWasCancelled {
                 let viewControllerForPresentedMenu = SideMenuTransition.viewControllerForPresentedMenu
@@ -375,7 +384,6 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition, UIViewContr
                 } else {
                     SideMenuTransition.presentMenuComplete()
                 }
-                menuView?.isUserInteractionEnabled = true
                 
                 transitionContext.completeTransition(false)
                 
@@ -389,13 +397,18 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition, UIViewContr
             
             if self.presenting {
                 SideMenuTransition.presentMenuComplete()
-                menuView?.isUserInteractionEnabled = true
+                if !SideMenuManager.menuPresentingViewControllerUserInteractionEnabled {
+                    let tapView = UIView()
+                    topView.addSubview(tapView)
+                    tapView.frame = topView.bounds
+                    SideMenuTransition.tapView = tapView
+                }
                 transitionContext.completeTransition(true)
                 switch SideMenuManager.menuPresentMode {
                 case .viewSlideOut, .viewSlideInOut:
-                    container.addSubview(topView!)
+                    container.addSubview(topView)
                 case .menuSlideIn, .menuDissolveIn:
-                    container.insertSubview(topView!, at: 0)
+                    container.insertSubview(topView, at: 0)
                 }
                 if let statusBarView = SideMenuTransition.statusBarView {
                     container.bringSubview(toFront: statusBarView)
@@ -406,7 +419,7 @@ open class SideMenuTransition: UIPercentDrivenInteractiveTransition, UIViewContr
             
             SideMenuTransition.hideMenuComplete()
             transitionContext.completeTransition(true)
-            menuView?.removeFromSuperview()
+            menuView.removeFromSuperview()
         }
     }
     

Pod/Classes/UISideMenuNavigationController.swift

@@ -125,9 +125,10 @@ open class UISideMenuNavigationController: UINavigationController {
             super.pushViewController(viewController, animated: animated)
             return
         }
-        
-        guard let presentingViewController = presentingViewController as? UINavigationController else {
-            print("SideMenu Warning: attempt to push a View Controller from \(self.presentingViewController.self) where its navigationController == nil. It must be embedded in a Navigation Controller for this to work.")
+
+        let tabBarController = presentingViewController as? UITabBarController
+        guard let navigationController = (tabBarController?.selectedViewController ?? presentingViewController) as? UINavigationController else {
+            print("SideMenu Warning: attempt to push a View Controller from \(presentingViewController.self) where its navigationController == nil. It must be embedded in a Navigation Controller for this to work.")
             return
         }
         
@@ -144,9 +145,9 @@ open class UISideMenuNavigationController: UINavigationController {
         })
         
         if SideMenuManager.menuAllowPopIfPossible {
-            for subViewController in presentingViewController.viewControllers {
+            for subViewController in navigationController.viewControllers {
                 if type(of: subViewController) == type(of: viewController) {
-                    presentingViewController.popToViewController(subViewController, animated: animated)
+                    navigationController.popToViewController(subViewController, animated: animated)
                     CATransaction.commit()
                     return
                 }
@@ -154,20 +155,20 @@ open class UISideMenuNavigationController: UINavigationController {
         }
         
         if SideMenuManager.menuReplaceOnPush {
-            var viewControllers = presentingViewController.viewControllers
+            var viewControllers = navigationController.viewControllers
             viewControllers.removeLast()
             viewControllers.append(viewController)
-            presentingViewController.setViewControllers(viewControllers, animated: animated)
+            navigationController.setViewControllers(viewControllers, animated: animated)
             CATransaction.commit()
             return
         }
         
-        if let lastViewController = presentingViewController.viewControllers.last, !SideMenuManager.menuAllowPushOfSameClassTwice && type(of: lastViewController) == type(of: viewController) {
+        if let lastViewController = navigationController.viewControllers.last, !SideMenuManager.menuAllowPushOfSameClassTwice && type(of: lastViewController) == type(of: viewController) {
             CATransaction.commit()
             return
         }
         
-        presentingViewController.pushViewController(viewController, animated: animated)
+        navigationController.pushViewController(viewController, animated: animated)
         CATransaction.commit()
     }
 }

README.md

@@ -4,10 +4,9 @@
 [![License](https://img.shields.io/cocoapods/l/SideMenu.svg?style=flat)](http://cocoapods.org/pods/SideMenu)
 [![Platform](https://img.shields.io/cocoapods/p/SideMenu.svg?style=flat)](http://cocoapods.org/pods/SideMenu)
 
-## Shameless Plugs
 ### If you like SideMenu, give it a ★ at the top right of its [GitHub](https://github.com/jonkykong/SideMenu) page.
 
-My name is Jon Kent and I'm a freelance iOS designer, developer, and mobile strategist. I love coffee and play the drums. [**Hire me**](mailto:contact@jonkent.me?subject=Let's build something amazing.) to help you make cool stuff. I also have a [website](http://jonkent.me).
+My name is Jon Kent and I'm a freelance iOS designer, developer, and mobile strategist. I love coffee and play the drums. [**Hire me**](mailto:contact@jonkent.me?subject=Let's build something amazing.) to help you make cool stuff. I also have a [website](http://jonkent.me). *Note: If you're having a problem with SideMenu, please open an [issue](https://github.com/jonkykong/SideMenu/issues/new) and do not email me.*
 
 ## Overview
 

SideMenu.podspec

@@ -8,7 +8,7 @@
 
 Pod::Spec.new do |s|
   s.name             = "SideMenu"
-  s.version          = "2.1.2"
+  s.version          = "2.1.5"
   s.summary          = "Simple side menu control for iOS in Swift inspired by Facebook. Right and Left sides. No coding required."
 
 # This description is used to generate tags and improve search results.