Add default implementation for 'ended' property

Gemfile

@@ -5,6 +5,6 @@ gem 'danger', '4.0.4'
 gem 'xcode-install', '2.1.0'
 gem 'xcpretty-json-formatter', '0.1.0'
 gem 'danger-xcode_summary', '0.1.0'
-gem 'nokogiri', '1.10.8'
+gem 'nokogiri', '1.8.5'
 plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
 eval(File.read(plugins_path), binding) if File.exist?(plugins_path)

Gemfile.lock

@@ -51,6 +51,7 @@ GEM
     cocoapods-try (1.1.0)
     colored (1.2)
     colored2 (3.1.2)
+    colorize (0.8.1)
     commander-fastlane (4.4.6)
       highline (~> 1.7.2)
     concurrent-ruby (1.1.5)
@@ -79,7 +80,7 @@ GEM
     dotenv (2.7.4)
     emoji_regex (1.0.1)
     escape (0.0.4)
-    excon (0.73.0)
+    excon (0.64.0)
     faraday (0.15.4)
       multipart-post (>= 1.2, < 3)
     faraday-cookie_jar (0.0.6)
@@ -127,6 +128,10 @@ GEM
       xcodeproj (>= 1.6.0, < 2.0.0)
       xcpretty (~> 0.3.0)
       xcpretty-travis-formatter (>= 0.0.3)
+    fastlane-plugin-pretty_junit (0.1.1)
+      colorize
+      nokogiri
+      terminal-table
     fourflusher (2.3.1)
     fuzzy_match (2.0.4)
     gh_inspector (1.1.3)
@@ -169,7 +174,7 @@ GEM
       mime-types-data (~> 3.2015)
     mime-types-data (3.2019.0331)
     mini_magick (4.5.1)
-    mini_portile2 (2.4.0)
+    mini_portile2 (2.3.0)
     minitest (5.11.3)
     molinillo (0.6.6)
     multi_json (1.13.1)
@@ -179,8 +184,8 @@ GEM
     nap (1.1.0)
     naturally (2.2.0)
     netrc (0.11.0)
-    nokogiri (1.10.8)
-      mini_portile2 (~> 2.4.0)
+    nokogiri (1.8.5)
+      mini_portile2 (~> 2.3.0)
     octokit (4.13.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
@@ -248,7 +253,8 @@ DEPENDENCIES
   danger (= 4.0.4)
   danger-xcode_summary (= 0.1.0)
   fastlane (= 2.114.0)
-  nokogiri (= 1.10.8)
+  fastlane-plugin-pretty_junit
+  nokogiri (= 1.8.5)
   xcode-install (= 2.1.0)
   xcpretty-json-formatter (= 0.1.0)
 

README.md

@@ -1,5 +1,3 @@
-⚠️⚠️⚠️ This library has been deprecated and will be removed in the future. ⚠️⚠️⚠️
-
 # PlayerKit
 
 [![CI Status](http://img.shields.io/travis/ghking/PlayerKit.svg?style=flat)](https://travis-ci.org/vimeo/PlayerKit)

Sources/Player.swift

@@ -80,6 +80,12 @@ public enum PlayerError: Int {
     func pause()
 }
 
+public extension Player {
+    var ended: Bool {
+        return self.time >= self.duration
+    }
+}
+
 // MARK: Identity Protocols
 
 /// A player that adopts the ProvidesView protocol is capable of providing a view to be added to a view hierarchy.

Sources/RegularPlayer.swift

@@ -119,10 +119,6 @@ extension AVMediaSelectionOption: TextTrackMetadata {
         return self.player.rate > 0
     }
     
-    public var ended: Bool {
-        return self.time >= self.duration
-    }
-    
     public var error: NSError? {
         return self.player.errorForPlayerOrItem
     }