mirror of
https://github.com/MessageKit/MessageKit.git
synced 2026-02-06 19:03:19 +00:00
Merge branch 'master' into patch-1
This commit is contained in:
Jakub Kašpar
+9
-9
@@ -262,7 +262,7 @@ The changelog for `MessageKit`. Also see the [releases](https://github.com/Messa
|
||||
|
||||
### Fixed
|
||||
|
||||
- **Breaking Change** Fixed typo of `scrollsToBottomOnKeybordBeginsEditing` to `scrollsToBottomOnKeyboardBeginsEditing`.
|
||||
- **Breaking Change** Fixed typo of `scrollsToBottomOnKeyboardBeginsEditing` to `scrollsToBottomOnKeyboardBeginsEditing`.
|
||||
[#856](https://github.com/MessageKit/MessageKit/pull/856) by [@p-petrenko](https://github.com/p-petrenko)
|
||||
|
||||
- Fixed a bug that prevented `MessageLabel` from laying out properly when contained by superviews using autolayout.
|
||||
@@ -414,7 +414,7 @@ You must now set this font explicitly through the `emojiMessageSizeCalculator` o
|
||||
- **Breaking Change** Removed the `showsDateHeaderAfterTimeInterval` property of `MessagesCollectionView`.
|
||||
[#615](https://github.com/MessageKit/MessageKit/pull/615) by [@SD10](https://github.com/sd10).
|
||||
|
||||
- **Breaking Change** Removed the `reuseIdentifer` method from `MessageCollectionViewCell`, `TextMessageCell`,
|
||||
- **Breaking Change** Removed the `reuseIdentifier` method from `MessageCollectionViewCell`, `TextMessageCell`,
|
||||
`LocationMessageCell`, `MediaMessageCell`, and `MessageContentCell`.
|
||||
[#615](https://github.com/MessageKit/MessageKit/pull/615) by [@SD10](https://github.com/sd10).
|
||||
|
||||
@@ -620,8 +620,8 @@ typed as `MessageLabel` and are now regular `UILabel`s.
|
||||
|
||||
### Fixed
|
||||
|
||||
- **Breaking Change** Fixed all instances of misspelled `inital` property. `Avatar.inital` has changed to `Avatar.initial`
|
||||
and the initializer has changed from `public init(image: UIImage? = nil, initals: String = "?")` to `public init(image: UIImage? = nil, initials: String = "?")`.
|
||||
- **Breaking Change** Fixed all instances of misspelled `initial` property. `Avatar.initial` has changed to `Avatar.initial`
|
||||
and the initializer has changed from `public init(image: UIImage? = nil, initials: String = "?")` to `public init(image: UIImage? = nil, initials: String = "?")`.
|
||||
[#298](https://github.com/MessageKit/MessageKit/issues/298) by [@sidmclaughlin](https://github.com/sidmclaughlin).
|
||||
|
||||
- Fixed `MessageInputBar`'s `translucent` functionality.
|
||||
@@ -654,7 +654,7 @@ moved their methods into the `MessagesLayoutDelegate` protocol.
|
||||
- Fixed `contentInset.top` adjustment of the `MessagesCollectionView` on iOS versions less than 11 where it was found that messages appeared under the navigation var
|
||||
[#334](https://github.com/MessageKit/MessageKit/pull/334) by [@nathantannar4](https://github.com/nathantannar4).
|
||||
|
||||
- Fixed `cellbottomLabel` origin X for the `.messageLeading` alignment and
|
||||
- Fixed `cellBottomLabel` origin X for the `.messageLeading` alignment and
|
||||
origin Y so that the `cellBottomLabel` is always under the `MessageContainerView`.
|
||||
[#326](https://github.com/MessageKit/MessageKit/pull/326) by [@SD10](https://github.com/sd10).
|
||||
|
||||
@@ -674,7 +674,7 @@ origin Y so that the `cellBottomLabel` is always under the `MessageContainerView
|
||||
- Fixed a bug that caused a race condition to be met when invalidating the `intrinsicContentSize` of the `MessageInputBar` which froze the app during a "Select" or "Select All" long press
|
||||
[#313](https://github.com/MessageKit/MessageKit/pull/313) by [@zhongwuzw](https://github.com/nathantannar4).
|
||||
|
||||
- Fixed a bug that the `placeholderLabel` `subview` of `InputTextView` leads to ambiguous content size because of uncorrect `Auto Layout`.
|
||||
- Fixed a bug that the `placeholderLabel` `subview` of `InputTextView` leads to ambiguous content size because of incorrect `Auto Layout`.
|
||||
[#310](https://github.com/MessageKit/MessageKit/pull/310) by [@zhongwuzw](https://github.com/zhongwuzw).
|
||||
|
||||
- Fixed a bug that the `leftStackView`、`rightStackView` `subview` of `MessageInputBar` leads to ambiguous `Auto Layout` issue because of typo.
|
||||
@@ -710,7 +710,7 @@ origin Y so that the `cellBottomLabel` is always under the `MessageContainerView
|
||||
|
||||
### Fixed
|
||||
|
||||
- Fixed a bug that prevented the `textAllignment` property of `InputTextView`'s `placeholderLabel` from having noticable differences when changed to `.center` or `.right`.
|
||||
- Fixed a bug that prevented the `textAlignment` property of `InputTextView`'s `placeholderLabel` from having noticeable differences when changed to `.center` or `.right`.
|
||||
[#262](https://github.com/MessageKit/MessageKit/pull/262) by [@nathantannar4](https://github.com/nathantannar4).
|
||||
|
||||
- Initial `contentInset.bottom` reference changed from `messageInputBar` to `inputAccessoryView` to allow custom `inputAccessoryView`'s that don't break the initial layout.
|
||||
@@ -741,7 +741,7 @@ when `extendedLayoutIncludesOpaqueBars` is `true`.
|
||||
- **Breaking Change** `.emoji(String)` case to `MessageData` enum.
|
||||
[#222](https://github.com/MessageKit/MessageKit/pull/222) by [@SirArkimdes](https://github.com/SirArkimedes).
|
||||
|
||||
- **Breaking Change** `TextMessageDisplayDelegate` to handle `enabledDetecors(for:at:in)` and moves `textColor(for:at:in)` to this namespace.
|
||||
- **Breaking Change** `TextMessageDisplayDelegate` to handle `enabledDetectors(for:at:in)` and moves `textColor(for:at:in)` to this namespace.
|
||||
[#230](https://github.com/MessageKit/MessageKit/pull/230) by [@SD10](https://github.com/sd10)
|
||||
|
||||
- `LocationMessageDisplayDelegate` to customize a location messages appearance and add a `MKAnnotationView` to location message snapshots.
|
||||
@@ -759,7 +759,7 @@ when `extendedLayoutIncludesOpaqueBars` is `true`.
|
||||
- `scrollsToBottomOnKeyboardDidBeginEditing` property to automatically scroll to the bottom of `MessagesCollectionView` when the keyboard begins editing.
|
||||
[#217](https://github.com/MessageKit/MessageKit/pull/217) by [@SD10](https://github.com/SD10).
|
||||
|
||||
- `additionalTopContentInset` property to `MessagesColectionViewController` to allow users to account for extra subviews.
|
||||
- `additionalTopContentInset` property to `MessagesCollectionViewController` to allow users to account for extra subviews.
|
||||
[#218](https://github.com/MessageKit/MessageKit/pull/218) by [@SD10](https://github.com/SD10).
|
||||
|
||||
- `messagePadding(for:at:in)` method to `MessagesLayoutDelegate` to dynamically set padding around `MessageContainerView`.
|
||||
|
||||
@@ -43,11 +43,11 @@ Here you can find the general guidelines for maintaining the Changelog (or addin
|
||||
|
||||
### Fixed
|
||||
|
||||
- Fixed a bug that prevented the `textAllignment` property of `InputTextView`'s `placeholderLabel` from having noticable differences when changed to `.center` or `.right`.
|
||||
- Fixed a bug that prevented the `textAlignment` property of `InputTextView`'s `placeholderLabel` from having noticeable differences when changed to `.center` or `.right`.
|
||||
[#262](https://github.com/MessageKit/MessageKit/pull/262) by [@nathantannar4](https://github.com/nathantannar4).
|
||||
|
||||
### Removed
|
||||
|
||||
- **Breaking Change** Removed `additionalTopContentInset` property of `MessagesViewController` because this is no longer necessary
|
||||
when `extendedLayoutIncludesOpaqueBars` is `true`.
|
||||
[#250](https://github.com/MessageKit/MessageKit/pull/250) by [@SD10](https://github.com/SD10).
|
||||
[#250](https://github.com/MessageKit/MessageKit/pull/250) by [@SD10](https://github.com/SD10).
|
||||
|
||||
@@ -108,4 +108,4 @@ func didTapMessage(in cell: MessageCollectionViewCell) {
|
||||
|
||||
## Animations are laggy/Scrolling is not smooth/General poor performance
|
||||
|
||||
In general, if you're experiencing performance issues, you should look through the implementation of your MessageKit delegate methods like `currentSender()`, etc to find any expensive/blocking method calls or operations. Some delegate methods are called many times per message rendered and thus if their implementations are not efficient then performance can significantly degrade. Avoid doing blocking activities like syncronous database lookups, keychain access, networking, etc. in your MessageKit delegate methods. You should instead cache what you need.
|
||||
In general, if you're experiencing performance issues, you should look through the implementation of your MessageKit delegate methods like `currentSender()`, etc to find any expensive/blocking method calls or operations. Some delegate methods are called many times per message rendered and thus if their implementations are not efficient then performance can significantly degrade. Avoid doing blocking activities like synchronous database lookups, keychain access, networking, etc. in your MessageKit delegate methods. You should instead cache what you need.
|
||||
|
||||
@@ -72,7 +72,7 @@ open class BasicAudioController: NSObject, AVAudioPlayerDelegate {
|
||||
|
||||
/// Used to configure the audio cell UI:
|
||||
/// 1. play button selected state;
|
||||
/// 2. progresssView progress;
|
||||
/// 2. progressView progress;
|
||||
/// 3. durationLabel text;
|
||||
///
|
||||
/// - Parameters:
|
||||
@@ -116,7 +116,7 @@ open class BasicAudioController: NSObject, AVAudioPlayerDelegate {
|
||||
startProgressTimer()
|
||||
audioCell.delegate?.didStartAudio(in: audioCell)
|
||||
default:
|
||||
print("BasicAudioPlayer failed play sound becasue given message kind is not Audio")
|
||||
print("BasicAudioPlayer failed play sound because given message kind is not Audio")
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -149,7 +149,7 @@ public class Lorem {
|
||||
}
|
||||
|
||||
/**
|
||||
Generate a string of random paragrahs.
|
||||
Generate a string of random paragraphs.
|
||||
- parameter nbParagraphs: The number of paragraphs to generate.
|
||||
- returns: Returns a string of random paragraphs.
|
||||
*/
|
||||
|
||||
@@ -48,7 +48,7 @@ final class AutocompleteExampleViewController: ChatViewController {
|
||||
return manager
|
||||
}()
|
||||
|
||||
var hastagAutocompletes: [AutocompleteCompletion] = {
|
||||
var hashtagAutocompletes: [AutocompleteCompletion] = {
|
||||
var array: [AutocompleteCompletion] = []
|
||||
for _ in 1...100 {
|
||||
array.append(AutocompleteCompletion(text: Lorem.word(), context: nil))
|
||||
@@ -235,7 +235,7 @@ extension AutocompleteExampleViewController: AutocompleteManagerDelegate, Autoco
|
||||
context: ["id": user.senderId])
|
||||
}
|
||||
} else if prefix == "#" {
|
||||
return hastagAutocompletes + asyncCompletions
|
||||
return hashtagAutocompletes + asyncCompletions
|
||||
}
|
||||
return []
|
||||
}
|
||||
|
||||
@@ -109,7 +109,7 @@ final internal class LaunchViewController: UITableViewController {
|
||||
guard let url = URL(string: "https://github.com/orgs/MessageKit/teams/contributors/members") else { return }
|
||||
openURL(url)
|
||||
default:
|
||||
assertionFailure("You need to impliment the action for this cell: \(cell)")
|
||||
assertionFailure("You need to implement the action for this cell: \(cell)")
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
@@ -104,7 +104,7 @@ This structure will allow you to create a layout that suits your needs as you ca
|
||||
<img src="https://raw.githubusercontent.com/MessageKit/MessageKit/master/Assets/InputBarAccessoryViewLayout.png" title="InputBarAccessoryViewLayout">
|
||||
</p>
|
||||
|
||||
The `MessageInputBar`, derrived from [InputBarAccessoryView](https://github.com/nathantannar4/InputBarAccessoryView) is a flexible and robust way of creating any kind of input layout you wish. It is self-sizing which means as the user types it will grow to fill available space. It is centered around the `middleContentView` which by default holds the `InputTextView`. This is surrounded by `InputStackView`'s that will also grow in high based on the needs of their subviews `intrinsicContentSize`. See the [Example](https://github.com/MessageKit/MessageKit/tree/master/Example) project for examples on how to taylor the layout for your own needs.
|
||||
The `MessageInputBar`, derived from [InputBarAccessoryView](https://github.com/nathantannar4/InputBarAccessoryView) is a flexible and robust way of creating any kind of input layout you wish. It is self-sizing which means as the user types it will grow to fill available space. It is centered around the `middleContentView` which by default holds the `InputTextView`. This is surrounded by `InputStackView`'s that will also grow in high based on the needs of their subviews `intrinsicContentSize`. See the [Example](https://github.com/MessageKit/MessageKit/tree/master/Example) project for examples on how to tailor the layout for your own needs.
|
||||
|
||||
### Guides
|
||||
|
||||
|
||||
Reference in New Issue
Block a user