GitHub/MailCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed a nasty memory leaks where mailmessage structs weren't getting properly freed

Browse Source
This commit is contained in:
mronge@mronges-macbook-pro-15.local
2007-07-13 01:32:35 -07:00
parent 68716b264b
commit dff56d7d66
3 changed files with 28 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/CTCoreFolder.m
+5 -2
View File
@@ -358,8 +358,11 @@
[messages addObject:msgObject];
[msgObject release];
}
if ( msgList != NULL )
carray_free(msgList->msg_tab); //I am only freeing the message array because the messages themselves are in use
if ( msgList != NULL ) {
//I am only freeing the message array because the messages themselves are in use
carray_free(msgList->msg_tab);
free(msgList);
}
return messages;
}
Source/CTCoreMessage.m
+1 -1
View File
@@ -58,7 +58,7 @@
- (void)dealloc {
//TODO mailmessage_free?
if (myMessage != NULL)
mailmessage_flush(myMessage);
mailmessage_free(myMessage);
if (myFields != NULL)
mailimf_single_fields_free(myFields);
[myParsedMIME release];
main.m
+22 -16
View File
@@ -10,15 +10,21 @@ int main( int argc, char *argv[ ] )
{
NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
// CTCoreAccount *account = [[CTCoreAccount alloc] init];
CTCoreAccount *account = [[CTCoreAccount alloc] init];
CTCoreFolder *folder;
// CTCoreFolder *inbox, *newFolder, *archive;
// CTCoreMessage *msgOne;
//
// [account connectToServer:@"mail.theronge.com" port:143 connectionType:CONNECTION_TYPE_PLAIN
// authType:IMAP_AUTH_TYPE_PLAIN login:@"mronge" password:@""];
//
// inbox = [account folderWithPath:@"INBOX"];
// //NSLog(@"%@", [inbox messageListFromUID:nil]);
[account connectToServer:@"mail.theronge.com" port:143 connectionType:CONNECTION_TYPE_STARTTLS
authType:IMAP_AUTH_TYPE_PLAIN login:@"mronge" password:@""];
folder = [account folderWithPath:@"INBOX"];
NSLog(@"%@", [folder messageObjectsFromUID:nil]);
// CTCoreMessage *msg;
// NSEnumerator *enumer = [set objectEnumerator];
// while ((msg == [enumer nextObject])) {
//
// }
// //NSLog(@"%@", [inbox messageObjectsFromIndex:500 toIndex:600]);
//
// msgOne = [inbox messageWithUID:@"1146070022-553"];
@@ -71,21 +77,21 @@ int main( int argc, char *argv[ ] )
/* GMAIL Test */
MailCoreEnableLogging();
CTCoreMessage *msgOne = [[CTCoreMessage alloc] init];
[msgOne setTo:[NSSet setWithObject:[CTCoreAddress addressWithName:@"Bob" email:@"mronge@theronge.com"]]];
[msgOne setFrom:[NSSet setWithObject:[CTCoreAddress addressWithName:@"test" email:@"test@test.com"]]];
[msgOne setBody:@"Test"];
[msgOne setSubject:@"Subject"];
[CTSMTPConnection sendMessage:msgOne server:@"mail.theronge.com" username:@"mronge" password:@"" port:25 useTLS:YES shouldAuth:YES];
// MailCoreEnableLogging();
//
// CTCoreMessage *msgOne = [[CTCoreMessage alloc] init];
// [msgOne setTo:[NSSet setWithObject:[CTCoreAddress addressWithName:@"Bob" email:@"mronge@theronge.com"]]];
// [msgOne setFrom:[NSSet setWithObject:[CTCoreAddress addressWithName:@"test" email:@"test@test.com"]]];
// [msgOne setBody:@"Test"];
// [msgOne setSubject:@"Subject"];
// [CTSMTPConnection sendMessage:msgOne server:@"mail.theronge.com" username:@"mronge" password:@"" port:25 useTLS:YES shouldAuth:YES];
//[CTSMTPConnection sendMessage:msgOne server:@"mail.dls.net" username:@"" password:@"" port:25 useTLS:NO shouldAuth:NO];
//[archive disconnect];
//[account disconnect];
//[account release];
while(1) {}
[pool release];
while(1) {}
return 0;
}