4.1.0

Fixes #53

LaunchAtLogin.xcodeproj/project.pbxproj

@@ -398,7 +398,7 @@
 					"@executable_path/../Frameworks",
 					"@loader_path/Frameworks",
 				);
-				MARKETING_VERSION = 4.0.0;
+				MARKETING_VERSION = 4.1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = com.sindresorhus.LaunchAtLogin;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -428,7 +428,7 @@
 					"@executable_path/../Frameworks",
 					"@loader_path/Frameworks",
 				);
-				MARKETING_VERSION = 4.0.0;
+				MARKETING_VERSION = 4.1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = com.sindresorhus.LaunchAtLogin;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -443,6 +443,7 @@
 				CODE_SIGN_IDENTITY = "-";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
+				CURRENT_PROJECT_VERSION = 2;
 				DEVELOPMENT_TEAM = "";
 				ENABLE_HARDENED_RUNTIME = YES;
 				INFOPLIST_FILE = Sources/LaunchAtLoginHelper/Info.plist;
@@ -450,6 +451,7 @@
 					"$(inherited)",
 					"@executable_path/../Frameworks",
 				);
+				MARKETING_VERSION = 1.0.1;
 				PRODUCT_BUNDLE_IDENTIFIER = com.sindresorhus.LaunchAtLoginHelper;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -464,6 +466,7 @@
 				CODE_SIGN_IDENTITY = "-";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
+				CURRENT_PROJECT_VERSION = 2;
 				DEVELOPMENT_TEAM = "";
 				ENABLE_HARDENED_RUNTIME = YES;
 				INFOPLIST_FILE = Sources/LaunchAtLoginHelper/Info.plist;
@@ -471,6 +474,7 @@
 					"$(inherited)",
 					"@executable_path/../Frameworks",
 				);
+				MARKETING_VERSION = 1.0.1;
 				PRODUCT_BUNDLE_IDENTIFIER = com.sindresorhus.LaunchAtLoginHelper;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				PROVISIONING_PROFILE_SPECIFIER = "";

Sources/LaunchAtLogin/LaunchAtLogin.swift

@@ -9,19 +9,19 @@ public enum LaunchAtLogin {
 	public static let observable = Observable()
 
 	@available(macOS 10.15, *)
-	private static var _publisher = CurrentValueSubject<Bool, Never>(isEnabled)
+	private static let _publisher = CurrentValueSubject<Bool, Never>(isEnabled)
 	@available(macOS 10.15, *)
-	public static var publisher = _publisher.eraseToAnyPublisher()
+	public static let publisher = _publisher.eraseToAnyPublisher()
 
 	private static let id = "\(Bundle.main.bundleIdentifier!)-LaunchAtLoginHelper"
 
 	public static var isEnabled: Bool {
 		get {
-			guard let jobs = (SMCopyAllJobDictionaries(kSMDomainUserLaunchd).takeRetainedValue() as? [[String: AnyObject]]) else {
+			guard let jobs = (SMCopyAllJobDictionaries(kSMDomainUserLaunchd)?.takeRetainedValue() as? [[String: AnyObject]]) else {
 				return false
 			}
 
-			let job = jobs.first { $0["Label"] as! String == id }
+			let job = jobs.first { ($0["Label"] as? String) == id }
 
 			return job?["OnDemand"] as? Bool ?? false
 		}

Sources/LaunchAtLogin/copy-helper-swiftpm.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
-HELPER_CHECKSUM="6eaaced9173120f82ef98452b2d8cb3705c12db39d4286c70c4f5bb6b67a5e43"
-HELPER_CHECKSUM_RUNTIME="c5a48f5ba681088aa7922b79f2f1b55a1a006904b8de378790eb0e8b0ac66234"
+HELPER_CHECKSUM="0a3d09438fb595802d554ce0a7c4ba8e1d2d91d5170362adc965da82e70d74cb"
+HELPER_CHECKSUM_RUNTIME="98ef556b490e02f4084a11d8a07c33a880177a9816b355885a11f58c95876d62"
 
 verlte() {
 	[ "$1" = "`echo -e "$1\n$2" | sort -V | head -n1`" ]
@@ -39,11 +39,12 @@ unzip "$helper_path" -d "$login_items/"
 defaults write "$login_helper_path/Contents/Info" CFBundleIdentifier -string "$PRODUCT_BUNDLE_IDENTIFIER-LaunchAtLoginHelper"
 
 if [[ -n $CODE_SIGN_ENTITLEMENTS ]]; then
-	codesign --force --entitlements="$package_resources_path/LaunchAtLogin.entitlements" --options=runtime --sign="$EXPANDED_CODE_SIGN_IDENTITY_NAME" "$login_helper_path"
+	codesign --force --entitlements="$package_resources_path/LaunchAtLogin.entitlements" --deep --options=runtime --sign="$EXPANDED_CODE_SIGN_IDENTITY_NAME" "$login_helper_path"
 else
-	codesign --force --options=runtime --sign="$EXPANDED_CODE_SIGN_IDENTITY_NAME" "$helper_path"
+	codesign --force --deep --options=runtime --sign="$EXPANDED_CODE_SIGN_IDENTITY_NAME" "$helper_path"
 fi
 
-if [[ $CONFIGURATION == "Release" ]]; then
+# If this is being built for multiple architectures, assume it is a release build and we should clean up.
+if [[ $ONLY_ACTIVE_ARCH == "NO" ]]; then
 	rm -rf "$contents_path/Resources/LaunchAtLogin_LaunchAtLogin.bundle"
 fi

Sources/LaunchAtLogin/copy-helper.sh

@@ -16,7 +16,8 @@ else
 	codesign --force --options=runtime --sign="$EXPANDED_CODE_SIGN_IDENTITY_NAME" "$helper_path"
 fi
 
-if [[ $CONFIGURATION == "Release" ]]; then
+# If this is being built for multiple architectures, assume it is a release build and we should clean up.
+if [[ $ONLY_ACTIVE_ARCH == "NO" ]]; then
 	rm -rf "$origin_helper_path"
 	rm "$(dirname "$origin_helper_path")/copy-helper.sh"
 	rm "$(dirname "$origin_helper_path")/LaunchAtLogin.entitlements"

Sources/LaunchAtLoginHelper/Info.plist

@@ -11,11 +11,13 @@
 	<key>CFBundleName</key>
 	<string>$(PRODUCT_NAME)</string>
 	<key>CFBundlePackageType</key>
-	<string>APPL</string>
+	<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0.0</string>
+	<string>$(MARKETING_VERSION)</string>
 	<key>CFBundleVersion</key>
-	<string>1</string>
+	<string>$(CURRENT_PROJECT_VERSION)</string>
+	<key>ITSAppUsesNonExemptEncryption</key>
+	<false/>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSBackgroundOnly</key>

Sources/LaunchAtLoginHelper/main.swift

@@ -1,13 +1,14 @@
-import Cocoa
+import AppKit
+
+// TODO: When targeting macOS 11, convert this to use `App` protocol and remove `NSPrincipalClass` in Info.plist.
 
 final class AppDelegate: NSObject, NSApplicationDelegate {
 	func applicationDidFinishLaunching(_ notification: Notification) {
-		let bundleId = Bundle.main.bundleIdentifier!
-		// TODO: Make this more strict by only replacing at the end
-		let mainBundleId = bundleId.replacingOccurrences(of: "-LaunchAtLoginHelper", with: "")
+		let bundleIdentifier = Bundle.main.bundleIdentifier!
+		let mainBundleIdentifier = bundleIdentifier.replacingOccurrences(of: #"-LaunchAtLoginHelper$"#, with: "", options: .regularExpression)
 
-		// Ensure the app is not already running
-		guard NSRunningApplication.runningApplications(withBundleIdentifier: mainBundleId).isEmpty else {
+		// Ensures the app is not already running.
+		guard NSRunningApplication.runningApplications(withBundleIdentifier: mainBundleIdentifier).isEmpty else {
 			NSApp.terminate(nil)
 			return
 		}

maintaining.md

@@ -0,0 +1,9 @@
+# Maintaining
+
+## Rebuild helper binaries
+
+1. If it's the non-`with-runtime` ZIP, set the target to macOS 10.14.4 first.
+2. Set build configuration to “Release”.
+3. Build the binary.
+4. Find the binary in “Products” in the sidebar, ZIP it, and overwrite the existing ZIP file in the source directory.
+5. Run `shasum -a 256 filename.zip` on the ZIP file and copy the hash into “copy-helper-swiftpm.sh”.

readme.md

@@ -16,11 +16,7 @@ This package works with both sandboxed and non-sandboxed apps and it's App Store
 
 #### Swift Package Manager
 
-Xcode 12+ required.
-
-```
-.package(url: "https://github.com/sindresorhus/LaunchAtLogin", from: "4.0.0")
-```
+Add `https://github.com/sindresorhus/LaunchAtLogin` in the [“Swift Package Manager” tab in Xcode](https://developer.apple.com/documentation/xcode/adding_package_dependencies_to_your_app).
 
 #### Carthage
 
@@ -32,20 +28,26 @@ github "sindresorhus/LaunchAtLogin"
 
 ## Usage
 
-Add a new ["Run Script Phase"](http://stackoverflow.com/a/39633955/64949) **below** "Embed Frameworks" in "Build Phases" with the following:
-
 #### Swift Package Manager
 
+Add a new [“Run Script Phase”](http://stackoverflow.com/a/39633955/64949) **below** (not into) “Copy Bundle Resources” in “Build Phases” with the following:
+
 ```sh
 "${BUILT_PRODUCTS_DIR}/LaunchAtLogin_LaunchAtLogin.bundle/Contents/Resources/copy-helper-swiftpm.sh"
 ```
 
+*(I would name the run script `Copy “Launch at Login Helper”`)*
+
 #### Carthage
 
+Add a new [“Run Script Phase”](http://stackoverflow.com/a/39633955/64949) **below** (not into) “Embed Frameworks” in “Build Phases” with the following:
+
 ```sh
 "${PROJECT_DIR}/Carthage/Build/Mac/LaunchAtLogin.framework/Resources/copy-helper.sh"
 ```
 
+*(I would name the run script `Copy “Launch at Login Helper”`)*
+
 ### Use it in your app
 
 No need to store any state to UserDefaults.
@@ -143,7 +145,7 @@ final class ViewController: NSViewController {
 
 ## How does it work?
 
-The framework bundles the helper app needed to launch your app and copies it into your app at build time.
+The package bundles the helper app needed to launch your app and copies it into your app at build time.
 
 ## FAQ
 
@@ -186,12 +188,18 @@ Some helpful Stack Overflow answers:
 
 #### Can you support CocoaPods?
 
-CocoaPods used to be supported, but [it did not work well](https://github.com/sindresorhus/LaunchAtLogin/issues/22) and there was no easy way to fix it, so support was dropped. Even though you mainly use CocoaPods, you can still use Carthage just for this package without any problems.
+CocoaPods used to be supported, but [it did not work well](https://github.com/sindresorhus/LaunchAtLogin/issues/22) and there was no easy way to fix it, so support was dropped. Even though you mainly use CocoaPods, you can still use Swift Package Manager just for this package without any problems.
 
 #### I'm getting a `'SMCopyAllJobDictionaries' was deprecated in OS X 10.10` warning
 
 Apple deprecated that API without providing an alternative. Apple engineers have [stated that it's still the preferred API to use](https://github.com/alexzielenski/StartAtLoginController/issues/12#issuecomment-307525807). I plan to use it as long as it's available. There are workarounds I can implement if Apple ever removes the API, so rest assured, this module will be made to work even then. If you want to see this resolved, submit a [Feedback Assistant](https://feedbackassistant.apple.com) report with [the following text](https://github.com/feedback-assistant/reports/issues/16). There's unfortunately still [no way to suppress warnings in Swift](https://stackoverflow.com/a/32861678/64949).
 
+#### I can't see the `LaunchAtLogin.bundle` in my debug build or I get a notarization error for developer ID distribution
+
+As discussed [here](https://github.com/sindresorhus/LaunchAtLogin/issues/50), this package tries to determine if you're making a release or debug build and clean up its install accordingly. If your debug build is missing the bundle or, conversely, your release build has the bundle and it causes a code signing error, that means this has failed.
+
+The script's determination is based on the “Build Active Architecture Only” flag in build settings. If this is set to `YES`, then the script will package LaunchAtLogin for a debug build. You must set this flag to `NO` if you plan on distributing the build with codesigning.
+
 ## Related
 
 - [Defaults](https://github.com/sindresorhus/Defaults) - Swifty and modern UserDefaults