GitHub/GameNetworkingSockets
1
0
Fork 0
mirror of https://github.com/ValveSoftware/GameNetworkingSockets.git synced 2026-05-29 16:20:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix dangling pointer bug

Browse Source 
If there is more than one STUN server and the name is
shorter than std::string small string optimization size.

(cherry picked from commit b88a52c206)
This commit is contained in:
Fletcher Dunn
2026-05-22 22:22:02 -07:00
parent fb89e13c67
commit d038acf945
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/steamnetworkingsockets/clientlib/steamnetworkingsockets_p2p_ice.cpp
+4 -1
View File
@@ -134,8 +134,11 @@ void CSteamNetworkConnectionP2P::CheckInitICE()
server.append( pszAddress );
vecStunServers.push_back( std::move( server ) );
vecStunServersPsz.push_back( vecStunServers.rbegin()->c_str() );
}
// Build the pointer array after vecStunServers is fully populated;
// doing it inside the loop would produce dangling pointers on reallocation.
for ( const std::string &s: vecStunServers )
vecStunServersPsz.push_back( s.c_str() );
}
if ( vecStunServers.empty() )
SpewWarningGroup( LogLevel_P2PRendezvous(), "[%s] Reflexive candidates enabled by P2P_Transport_ICE_Enable, but P2P_STUN_ServerList is empty\n", GetDescription() );