GitHub/GameNetworkingSockets
1
0
Fork 0
mirror of https://github.com/ValveSoftware/GameNetworkingSockets.git synced 2026-05-29 16:20:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Small optimization in SteamNetworkingMessagesSession::CheckConnection

Browse Source 
Move check to see if we are idle to be inside the (rarely true) if()
branch where we use it.  This could become a bit more important in
the future if SNP_BHasAnyBufferedRecvData() becomes more expensive
when lanes are added.

P4:6806855
This commit is contained in:
Fletcher Dunn
2021-10-04 12:18:09 -07:00
parent 547c0e11bf
commit b3ea9223e7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/steamnetworkingsockets/clientlib/csteamnetworkingmessages.cpp
+3 -3
View File
@@ -800,9 +800,6 @@ void SteamNetworkingMessagesSession::CheckConnection( SteamNetworkingMicrosecond
UpdateConnectionInfo();
bool bIdle = !m_pConnection->SNP_BHasAnyBufferedRecvData()
&& !m_pConnection->SNP_BHasAnyUnackedSentReliableData();
// Safety check in case the connection got nuked without going thorugh an expected terminal state
if ( !m_pConnection->BStateIsActive() )
{
@@ -818,6 +815,9 @@ void SteamNetworkingMessagesSession::CheckConnection( SteamNetworkingMicrosecond
// Check if the connection died
if ( m_lastConnectionInfo.m_eState == k_ESteamNetworkingConnectionState_ProblemDetectedLocally || m_lastConnectionInfo.m_eState == k_ESteamNetworkingConnectionState_ClosedByPeer )
{
bool bIdle = !m_pConnection->SNP_BHasAnyBufferedRecvData()
&& !m_pConnection->SNP_BHasAnyUnackedSentReliableData();
SpewVerbose( "[%s] messages session %s: %d %s\n",
m_lastConnectionInfo.m_szConnectionDescription,
m_lastConnectionInfo.m_eState == k_ESteamNetworkingConnectionState_ProblemDetectedLocally ? "problem detected locally" : "closed by peer",