GitHub/GameNetworkingSockets
1
0
Fork 0
mirror of https://github.com/ValveSoftware/GameNetworkingSockets.git synced 2026-05-29 16:20:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug classifying P2P failure reason

Browse Source 
Just because we did not gather any reflexive address that was enabled, that
we failed to STUN.

"Failed to gather any" is ambiguous English.  We really meant "we did not gather
any".

Also, if we have a public IPv4 address, it could be that we did not STUN,
because the STUN server told us that our address was already public, and so
was not gathered as an additional address.
This commit is contained in:
Fletcher Dunn
2020-07-03 15:35:15 -07:00
parent 9b52cfd975
commit 9dd1e35a05
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/steamnetworkingsockets/clientlib/steamnetworkingsockets_p2p.cpp
+1 -1
View File
@@ -432,7 +432,7 @@ void CSteamNetworkConnectionP2P::GuessICEFailureReason( ESteamNetConnectionEnd &
}
// We failed to STUN?
if ( nFailedToGatherTypes & k_EICECandidate_Any_Reflexive )
if ( ( nAllowedTypes & k_EICECandidate_Any_Reflexive ) != 0 && ( nGatheredTypes & (k_EICECandidate_Any_Reflexive|k_EICECandidate_IPv4_HostPublic) ) == 0 )
{
if ( m_connectionConfig.m_P2P_STUN_ServerList.Get().empty() )
{