GitHub/GameNetworkingSockets
1
0
Fork 0
mirror of https://github.com/ValveSoftware/GameNetworkingSockets.git synced 2026-05-29 16:20:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Greatly increase warning thresholds in tsan

Browse Source 
(cherry picked from commit 41283275b6)
This commit is contained in:
Fletcher Dunn
2026-05-03 22:54:39 -07:00
parent ca3f372696
commit 817833a40e
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/steamnetworkingsockets/clientlib/steamnetworkingsockets_lowlevel.cpp
+13 -2
View File
@@ -122,8 +122,13 @@ static Lock<RecursiveTimedMutexImpl> s_mutexGlobalLock( "global", 0, LockDebugIn
#if STEAMNETWORKINGSOCKETS_LOCK_DEBUG_LEVEL > 0
// By default, complain if we hold the lock for more than this long
// By default, complain if we hold the lock for more than this long.
// TSan adds 10-20x overhead so the threshold is scaled up accordingly.
#ifdef __SANITIZE_THREAD__
constexpr SteamNetworkingMicroseconds k_usecDefaultLongLockHeldWarningThreshold = 5*1000*20;
#else
constexpr SteamNetworkingMicroseconds k_usecDefaultLongLockHeldWarningThreshold = 5*1000;
#endif
// Debug the locks active on the cu
struct ThreadLockDebugInfo
@@ -2870,7 +2875,13 @@ static bool PollRawUDPSockets( int nMaxTimeoutMS, bool bManualPoll )
SteamNetworkingMicroseconds usecElapsedWaitingForLock = SteamNetworkingSockets_GetLocalTimestamp() - usecStartedLocking;
// Hm, if another thread indicated that they expected to hold the lock for a while,
// perhaps we should ignore this assert?
AssertMsg1( usecElapsedWaitingForLock < 50*1000 || Plat_IsInDebugSession(),
// TSan adds 10-20x overhead so the threshold is scaled up accordingly.
#ifdef __SANITIZE_THREAD__
constexpr SteamNetworkingMicroseconds k_usecServiceThreadLockWaitWarning = 50*1000*20;
#else
constexpr SteamNetworkingMicroseconds k_usecServiceThreadLockWaitWarning = 50*1000;
#endif
AssertMsg1( usecElapsedWaitingForLock < k_usecServiceThreadLockWaitWarning || Plat_IsInDebugSession(),
"SteamnetworkingSockets service thread waited %dms for lock! This directly adds to network latency! It could be a bug, but it's usually caused by general performance problem such as thread starvation or a debug output handler taking too long.", int( usecElapsedWaitingForLock/1000 ) );
}
#endif