Compare commits

...

27 Commits

Author SHA1 Message Date
Ilya Puchka 4f3bc1e498 Merge branch 'master' into release/7.0.1 2018-11-19 20:35:40 +00:00
Ilya Puchka 8dcb136ff0 fixed typos 2018-11-19 20:34:56 +00:00
Ilya Puchka 88d02af706 bump version to 7.0.1 2018-11-19 20:32:40 +00:00
Ilya Puchka a8777c067e Allow to disabled/enable auto injection for container or single definition. fixes #214, resolves #212 2018-11-19 00:03:15 +00:00
Ilya Puchka db40e8580c Added test for regression SR-8878 2018-11-19 00:03:15 +00:00
Ilya Puchka 334fb384a5 Update README.md 2018-11-18 23:54:49 +00:00
Ilya Puchka 54e1db2232 Merge pull request #207 from AliSoftware/develop
Release 7.0.0
2018-09-22 23:31:41 +03:00
Ilya Puchka c5c6bd2821 Merge branch 'master' into develop 2018-09-22 23:20:46 +03:00
Ilya Puchka 593129c63e update cocoapods on travis 2018-09-22 20:47:45 +01:00
Ilya Puchka 9a8d919a13 bump xcode and swift version on travis 2018-09-22 20:16:49 +01:00
Ilya Puchka 17a2d64361 bumped version to 7.0.0 2018-09-22 20:16:49 +01:00
Ilya Puchka 27037c2dd7 fix indentation in some docs 2018-09-22 20:01:16 +01:00
Ilya Puchka bd253f4b0a bump xcode and swift version on travis 2018-09-22 19:48:10 +01:00
Ilya Puchka 882b2a2031 bumped version to 7.0 2018-09-22 19:25:18 +01:00
Ilya Puchka 6a14c1f96d updated CHANGELOG 2018-09-22 19:24:00 +01:00
Ilya Puchka f60e322445 bumped swift version, removed unneded IUO tests 2018-09-22 19:19:45 +01:00
Ilya Puchka 77f6fde2fa Merge branch 'swift42' into develop 2018-09-22 19:16:27 +01:00
Ilya Puchka a8f7a2972a silence warning 2018-09-22 19:15:43 +01:00
Ilya Puchka ce9088afc7 fix reusing optionals 2018-09-22 18:47:34 +01:00
Ilya Puchka ef563c65ba fix build error on mac with SPM 2018-09-19 16:46:31 +03:00
Ilya Puchka 90ff39c720 fix build error on mac with SPM 2018-09-19 15:13:22 +03:00
Ilya Puchka e45dbd634f Merge with DipUI (#206)
* merge with DipUI
2018-09-19 15:02:26 +03:00
Bruno Virlet f81c267c61 Disable gathering code coverage (#198)
This causes issues whenn linking as a static library using Carthage
2018-07-25 18:10:51 +01:00
Michele Gruppioni d5b07b1916 Removed extension of ImplicitlyUnwrappedOptional (#191)
* Removed extension of ImplicitlyUnwrappedOptional

It was deprecated and has been removed in swift 4.2

* Added Swift Version Check
2018-07-13 11:43:40 +01:00
Ilya Puchka 33993df68a disable test coverage 2018-06-06 21:08:44 +01:00
Ilya Puchka dadb68862a fixed getting resolved instances 2018-06-06 01:15:08 +01:00
Ilya Puchka 2e53aa8ae2 Merge pull request #190 from AliSoftware/develop
Release 6.1
2018-04-28 20:24:35 +01:00
27 changed files with 959 additions and 115 deletions
+1 -1
View File
@@ -1 +1 @@
4.1
4.2
+5 -6
View File
@@ -7,11 +7,12 @@ matrix:
- set -o pipefail && xcodebuild test -workspace Dip.xcworkspace -scheme Dip -sdk macosx -destination 'platform=macOS,arch=x86_64' ONLY_ACTIVE_ARCH=NO | xcpretty -c
- pod spec lint --allow-warnings
- carthage build --no-skip-current
- swift package clean && swift build && swift test
os: osx
osx_image: xcode9.3
osx_image: xcode10
language: objective-c
before_install:
- gem install cocoapods --version 1.1.0.rc.2 --no-document
- gem install cocoapods --version 1.6.0.beta.1 --no-document
- script:
- swift package clean && swift build && swift test
os: linux
@@ -21,13 +22,11 @@ matrix:
before_install:
- wget -q -O - https://swift.org/keys/all-keys.asc | gpg --import -
- cd ..
- export SWIFT_VERSION=swift-4.1-RELEASE
- wget https://swift.org/builds/swift-4.1-release/ubuntu1404/$SWIFT_VERSION/$SWIFT_VERSION-ubuntu14.04.tar.gz
- export SWIFT_VERSION=swift-4.2-RELEASE
- wget https://swift.org/builds/swift-4.2-release/ubuntu1404/$SWIFT_VERSION/$SWIFT_VERSION-ubuntu14.04.tar.gz
- tar xzf $SWIFT_VERSION-ubuntu14.04.tar.gz
- export PATH="${PWD}/${SWIFT_VERSION}-ubuntu14.04/usr/bin:${PATH}"
- cd Dip
- script:
- swift package clean && swift build && swift test
notifications:
email: false
+13 -2
View File
@@ -1,9 +1,20 @@
# CHANGELOG
## 7.0.1
* Added a workaround for Swift 4.2 regression related to retaining weak properties ([#214](https://github.com/AliSoftware/Dip/issues/214)).
For that auto-injection can be disabled or enabled for the whole container or individula registrations.
## 7.0.0
* Swift 4.2 support.
* Fixed some issues when reusing instances previously resolved as optionals.
* Dip-UI is now part of Dip.
## 6.1
* Swift 4.1 support
* Fixed crashes resolving singletons using collaborating containers
* Swift 4.1 support.
* Fixed crashes resolving singletons using collaborating containers.
[#179](https://github.com/AliSoftware/Dip/pull/179), [@trimmurrti](https://github.com/trimmurrti)
[#182](https://github.com/AliSoftware/Dip/pull/182), [@tapsandswipes](https://github.com/tapsandswipes)
+1 -1
View File
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "Dip"
s.version = "6.1"
s.version = "7.0.1"
s.summary = "Dependency Injection for Swift made easy."
s.description = <<-DESC
+47 -2
View File
@@ -31,6 +31,8 @@
09FC480F1DAA9CAF00566AA8 /* Register.swift in Sources */ = {isa = PBXBuildFile; fileRef = 09FC480C1DAA9CAF00566AA8 /* Register.swift */; };
09FC48181DAAA53100566AA8 /* DipError.swift in Sources */ = {isa = PBXBuildFile; fileRef = 09FC48161DAAA53100566AA8 /* DipError.swift */; };
09FC481E1DAAA8F900566AA8 /* ComponentScope.swift in Sources */ = {isa = PBXBuildFile; fileRef = 09FC481C1DAAA8F900566AA8 /* ComponentScope.swift */; };
63937A6A21524C0B00AEE75A /* StoryboardInstantiatable.swift in Sources */ = {isa = PBXBuildFile; fileRef = 63937A6921524C0B00AEE75A /* StoryboardInstantiatable.swift */; };
63937A6F21524DA300AEE75A /* DipUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 63937A6B21524DA200AEE75A /* DipUITests.swift */; };
/* End PBXBuildFile section */
/* Begin PBXContainerItemProxy section */
@@ -71,6 +73,11 @@
09FC480C1DAA9CAF00566AA8 /* Register.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = Register.swift; path = ../../Sources/Register.swift; sourceTree = "<group>"; };
09FC48161DAAA53100566AA8 /* DipError.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = DipError.swift; path = ../../Sources/DipError.swift; sourceTree = "<group>"; };
09FC481C1DAAA8F900566AA8 /* ComponentScope.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = ComponentScope.swift; path = ../../Sources/ComponentScope.swift; sourceTree = "<group>"; };
63937A6921524C0B00AEE75A /* StoryboardInstantiatable.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = StoryboardInstantiatable.swift; path = ../../Sources/StoryboardInstantiatable.swift; sourceTree = "<group>"; };
63937A6B21524DA200AEE75A /* DipUITests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = DipUITests.swift; path = ../../Tests/DipTests/DipUITests.swift; sourceTree = "<group>"; };
63937A6C21524DA200AEE75A /* NSStoryboard.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; path = NSStoryboard.storyboard; sourceTree = "<group>"; };
63937A6D21524DA300AEE75A /* TVStoryboard.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; path = TVStoryboard.storyboard; sourceTree = "<group>"; };
63937A6E21524DA300AEE75A /* UIStoryboard.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; path = UIStoryboard.storyboard; sourceTree = "<group>"; };
/* End PBXFileReference section */
/* Begin PBXFrameworksBuildPhase section */
@@ -108,6 +115,7 @@
095F829B1D043B41008CD706 /* TypeForwarding.swift */,
0982AF0B1C5183A000B62463 /* Utils.swift */,
09871B401DAA6BF300B40B91 /* Compatibility.swift */,
63937A6921524C0B00AEE75A /* StoryboardInstantiatable.swift */,
0919F4CB1C16417000DC3B10 /* Info.plist */,
);
path = Dip;
@@ -125,6 +133,10 @@
09BD350A1D84E30D00B33E53 /* RuntimeArgumentsTests.swift */,
09BD350B1D84E30D00B33E53 /* ThreadSafetyTests.swift */,
09BD350C1D84E30D00B33E53 /* TypeForwardingTests.swift */,
63937A6B21524DA200AEE75A /* DipUITests.swift */,
63937A6C21524DA200AEE75A /* NSStoryboard.storyboard */,
63937A6D21524DA300AEE75A /* TVStoryboard.storyboard */,
63937A6E21524DA300AEE75A /* UIStoryboard.storyboard */,
09BD350D1D84E30D00B33E53 /* Utils.swift */,
0919F4D11C16417000DC3B10 /* Info.plist */,
);
@@ -189,6 +201,7 @@
buildPhases = (
0903B35D1C161543002241C1 /* Sources */,
0903B35E1C161543002241C1 /* Frameworks */,
63937A7721524E3B00AEE75A /* ShellScript */,
0903B35F1C161543002241C1 /* Resources */,
);
buildRules = (
@@ -256,6 +269,26 @@
};
/* End PBXResourcesBuildPhase section */
/* Begin PBXShellScriptBuildPhase section */
63937A7721524E3B00AEE75A /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputFileListPaths = (
);
inputPaths = (
);
outputFileListPaths = (
);
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "echo \"${SRCROOT}/DipTests/${STORYBOARD_NAME_PREFIX}Storyboard.storyboard\"\nibtool --compilation-directory \"${TARGET_TEMP_DIR}\" \"${SRCROOT}/DipTests/${STORYBOARD_NAME_PREFIX}Storyboard.storyboard\"\nibtool --link \"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}\" \"${TARGET_TEMP_DIR}/${STORYBOARD_NAME_PREFIX}Storyboard.storyboardc\"\n";
};
/* End PBXShellScriptBuildPhase section */
/* Begin PBXSourcesBuildPhase section */
0903B3531C161543002241C1 /* Sources */ = {
isa = PBXSourcesBuildPhase;
@@ -265,6 +298,7 @@
0982AF0C1C5183A000B62463 /* Utils.swift in Sources */,
0919F4D51C16417B00DC3B10 /* Definition.swift in Sources */,
09FC481E1DAAA8F900566AA8 /* ComponentScope.swift in Sources */,
63937A6A21524C0B00AEE75A /* StoryboardInstantiatable.swift in Sources */,
09B036001C5D2B83001EA5B7 /* AutoWiring.swift in Sources */,
0919F4D41C16417B00DC3B10 /* Dip.swift in Sources */,
09FC480F1DAA9CAF00566AA8 /* Register.swift in Sources */,
@@ -282,6 +316,7 @@
files = (
09BD35141D84E30D00B33E53 /* RuntimeArgumentsTests.swift in Sources */,
09BD35151D84E30D00B33E53 /* ThreadSafetyTests.swift in Sources */,
63937A6F21524DA300AEE75A /* DipUITests.swift in Sources */,
09BD35121D84E30D00B33E53 /* DefinitionTests.swift in Sources */,
09BD350F1D84E30D00B33E53 /* AutoWiringTests.swift in Sources */,
09BD35111D84E30D00B33E53 /* ContextTests.swift in Sources */,
@@ -325,6 +360,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.alisoftware.Dip;
PRODUCT_NAME = Dip;
SKIP_INSTALL = YES;
SWIFT_VERSION = 4.2;
};
name = Debug;
};
@@ -344,6 +380,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.alisoftware.Dip;
PRODUCT_NAME = Dip;
SKIP_INSTALL = YES;
SWIFT_VERSION = 4.2;
};
name = Release;
};
@@ -359,7 +396,13 @@
MACOSX_DEPLOYMENT_TARGET = 10.10;
PRODUCT_BUNDLE_IDENTIFIER = com.alisoftware.DipTests;
PRODUCT_NAME = "$(TARGET_NAME)";
STORYBOARD_NAME_PREFIX = NS;
"STORYBOARD_NAME_PREFIX[sdk=appletvos*]" = TV;
"STORYBOARD_NAME_PREFIX[sdk=appletvsimulator*]" = TV;
"STORYBOARD_NAME_PREFIX[sdk=iphoneos*]" = UI;
"STORYBOARD_NAME_PREFIX[sdk=iphonesimulator*]" = UI;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 4.2;
};
name = Debug;
};
@@ -375,6 +418,8 @@
MACOSX_DEPLOYMENT_TARGET = 10.10;
PRODUCT_BUNDLE_IDENTIFIER = com.alisoftware.DipTests;
PRODUCT_NAME = "$(TARGET_NAME)";
STORYBOARD_NAME_PREFIX = "";
SWIFT_VERSION = 4.2;
};
name = Release;
};
@@ -407,7 +452,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 6.1;
CURRENT_PROJECT_VERSION = 7.0.1;
DEBUG_INFORMATION_FORMAT = dwarf;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
@@ -470,7 +515,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 6.1;
CURRENT_PROJECT_VERSION = 7.0.1;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -40,7 +40,6 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
codeCoverageEnabled = "YES"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
+1 -1
View File
@@ -9,7 +9,7 @@
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.1</string>
<string>7.0.1</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
+1 -1
View File
@@ -9,7 +9,7 @@
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.1</string>
<string>7.0.1</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
+54
View File
@@ -0,0 +1,54 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.Cocoa.Storyboard.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES">
<dependencies>
<plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="14313.18"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<scenes>
<!--Dip View Controller-->
<scene sceneID="adI-oe-5KL">
<objects>
<viewController storyboardIdentifier="DipViewController" id="fzZ-tH-vfC" customClass="DipViewController" customModule="DipTests" sceneMemberID="viewController">
<view key="view" id="vso-jO-9Ex">
<rect key="frame" x="0.0" y="0.0" width="450" height="300"/>
<autoresizingMask key="autoresizingMask"/>
</view>
<userDefinedRuntimeAttributes>
<userDefinedRuntimeAttribute type="string" keyPath="dipTag" value="vc"/>
</userDefinedRuntimeAttributes>
</viewController>
<customObject id="wjM-mL-nmG" userLabel="First Responder" customClass="NSResponder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="311" y="339"/>
</scene>
<!--Nil Tag View Controller-->
<scene sceneID="OhX-tC-zpS">
<objects>
<viewController storyboardIdentifier="NilTagViewController" id="35S-Ec-qEA" customClass="NilTagViewController" customModule="DipTests" sceneMemberID="viewController">
<view key="view" id="y58-K4-cDZ">
<rect key="frame" x="0.0" y="0.0" width="450" height="300"/>
<autoresizingMask key="autoresizingMask"/>
</view>
<userDefinedRuntimeAttributes>
<userDefinedRuntimeAttribute type="nil" keyPath="dipTag"/>
</userDefinedRuntimeAttributes>
</viewController>
<customObject id="pvf-jv-8Cj" userLabel="First Responder" customClass="NSResponder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="874" y="339"/>
</scene>
<!--View Controller-->
<scene sceneID="Rwu-gt-fAa">
<objects>
<viewController storyboardIdentifier="ViewController" id="tne-ER-mvb" sceneMemberID="viewController">
<view key="view" id="Kwe-OO-w0D">
<rect key="frame" x="0.0" y="0.0" width="450" height="300"/>
<autoresizingMask key="autoresizingMask"/>
</view>
</viewController>
<customObject id="0u1-hv-ZtW" userLabel="First Responder" customClass="NSResponder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="311" y="729"/>
</scene>
</scenes>
</document>
+75
View File
@@ -0,0 +1,75 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder.AppleTV.Storyboard" version="3.0" toolsVersion="14313.18" targetRuntime="AppleTV" propertyAccessControl="none" useAutolayout="YES" colorMatched="YES" initialViewController="ctX-Lj-Yrr">
<device id="appleTV" orientation="landscape">
<adaptation id="light"/>
</device>
<dependencies>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="14283.14"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<scenes>
<!--Dip View Controller-->
<scene sceneID="0jz-eb-APg">
<objects>
<viewController storyboardIdentifier="DipViewController" id="ctX-Lj-Yrr" customClass="DipViewController" customModule="DipTests" sceneMemberID="viewController">
<layoutGuides>
<viewControllerLayoutGuide type="top" id="TrC-Rh-efi"/>
<viewControllerLayoutGuide type="bottom" id="arQ-XW-qWa"/>
</layoutGuides>
<view key="view" contentMode="scaleToFill" id="syn-UA-YGd">
<rect key="frame" x="0.0" y="0.0" width="200" height="100"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
</view>
<freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
<size key="freeformSize" width="200" height="100"/>
<userDefinedRuntimeAttributes>
<userDefinedRuntimeAttribute type="string" keyPath="dipTag" value="vc"/>
</userDefinedRuntimeAttributes>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="mq6-CB-g6V" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="563" y="-228"/>
</scene>
<!--View Controller-->
<scene sceneID="gDU-un-krd">
<objects>
<viewController storyboardIdentifier="ViewController" id="UwR-h2-tgS" sceneMemberID="viewController">
<layoutGuides>
<viewControllerLayoutGuide type="top" id="qKG-R0-Nkp"/>
<viewControllerLayoutGuide type="bottom" id="vP4-Si-HAL"/>
</layoutGuides>
<view key="view" contentMode="scaleToFill" id="r35-FI-kgS">
<rect key="frame" x="0.0" y="0.0" width="200" height="100"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
</view>
<freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
<size key="freeformSize" width="200" height="100"/>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="AIY-qB-Dbe" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="563" y="-16"/>
</scene>
<!--Nil Tag View Controller-->
<scene sceneID="PiH-4i-Txa">
<objects>
<viewController storyboardIdentifier="NilTagViewController" id="ZLb-1s-1ne" customClass="NilTagViewController" customModule="DipTests" sceneMemberID="viewController">
<layoutGuides>
<viewControllerLayoutGuide type="top" id="arU-Ca-km8"/>
<viewControllerLayoutGuide type="bottom" id="jw1-4B-Xlt"/>
</layoutGuides>
<view key="view" contentMode="scaleToFill" id="NMo-Oi-l7H">
<rect key="frame" x="0.0" y="0.0" width="200" height="100"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
</view>
<freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
<size key="freeformSize" width="200" height="100"/>
<userDefinedRuntimeAttributes>
<userDefinedRuntimeAttribute type="nil" keyPath="dipTag"/>
</userDefinedRuntimeAttributes>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="Cid-Yu-0N6" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="821" y="-228"/>
</scene>
</scenes>
</document>
+78
View File
@@ -0,0 +1,78 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="5AO-J3-7R4">
<device id="retina4_7" orientation="portrait">
<adaptation id="fullscreen"/>
</device>
<dependencies>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="14283.14"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<scenes>
<!--View Controller-->
<scene sceneID="Ole-tM-Q3l">
<objects>
<viewController storyboardIdentifier="ViewController" id="ehZ-7Y-MeO" sceneMemberID="viewController">
<layoutGuides>
<viewControllerLayoutGuide type="top" id="bZ0-tI-Yi9"/>
<viewControllerLayoutGuide type="bottom" id="UX3-8G-Z4L"/>
</layoutGuides>
<view key="view" contentMode="scaleToFill" id="Jmi-i3-vAY">
<rect key="frame" x="0.0" y="0.0" width="200" height="100"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
</view>
<freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
<size key="freeformSize" width="200" height="100"/>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="H12-WL-igv" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="646" y="461"/>
</scene>
<!--Dip View Controller-->
<scene sceneID="Lgf-SY-hfd">
<objects>
<viewController storyboardIdentifier="DipViewController" id="5AO-J3-7R4" userLabel="Dip View Controller" customClass="DipViewController" customModule="DipTests" sceneMemberID="viewController">
<layoutGuides>
<viewControllerLayoutGuide type="top" id="JYl-DM-U2W"/>
<viewControllerLayoutGuide type="bottom" id="Xg8-gz-BQL"/>
</layoutGuides>
<view key="view" contentMode="scaleToFill" id="aU0-uz-rHf">
<rect key="frame" x="0.0" y="0.0" width="200" height="100"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
</view>
<freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
<size key="freeformSize" width="200" height="100"/>
<userDefinedRuntimeAttributes>
<userDefinedRuntimeAttribute type="string" keyPath="dipTag" value="vc"/>
</userDefinedRuntimeAttributes>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="4iF-mX-EX6" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="646" y="200"/>
</scene>
<!--Dip View Controller-->
<scene sceneID="AUA-qF-7ky">
<objects>
<viewController storyboardIdentifier="NilTagViewController" id="fFP-hb-OdS" userLabel="Dip View Controller" customClass="NilTagViewController" customModule="DipTests" sceneMemberID="viewController">
<layoutGuides>
<viewControllerLayoutGuide type="top" id="Sio-ii-jPl"/>
<viewControllerLayoutGuide type="bottom" id="bhs-zK-dln"/>
</layoutGuides>
<view key="view" contentMode="scaleToFill" id="4xq-UV-htt">
<rect key="frame" x="0.0" y="0.0" width="200" height="100"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
</view>
<freeformSimulatedSizeMetrics key="simulatedDestinationMetrics"/>
<size key="freeformSize" width="200" height="100"/>
<userDefinedRuntimeAttributes>
<userDefinedRuntimeAttribute type="nil" keyPath="dipTag"/>
</userDefinedRuntimeAttributes>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="xvW-k9-I9y" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="898" y="200"/>
</scene>
</scenes>
</document>
+4 -18
View File
@@ -5,8 +5,8 @@
[![Carthage Compatible](https://img.shields.io/badge/Carthage-compatible-4BC51D.svg?style=flat)](https://github.com/Carthage/Carthage)
[![License](https://img.shields.io/cocoapods/l/Dip.svg?style=flat)](http://cocoapods.org/pods/Dip)
[![Platform](https://img.shields.io/cocoapods/p/Dip.svg?style=flat)](http://cocoapods.org/pods/Dip)
[![Swift Version](https://img.shields.io/badge/Swift-3.0--3.1-F16D39.svg?style=flat)](https://developer.apple.com/swift)
[![Swift Version](https://img.shields.io/badge/Linux-3.0--3.1-4BC51D.svg?style=flat)](https://developer.apple.com/swift)
[![Swift Version](https://img.shields.io/badge/Swift-4.0--4.2-F16D39.svg?style=flat)](https://developer.apple.com/swift)
[![Swift Version](https://img.shields.io/badge/Linux-4.0--4.2-4BC51D.svg?style=flat)](https://developer.apple.com/swift)
![Animated Dipping GIF](cinnamon-pretzels-caramel-dipping.gif)
_Photo courtesy of [www.kevinandamanda.com](http://www.kevinandamanda.com/recipes/appetizer/homemade-soft-cinnamon-sugar-pretzel-bites-with-salted-caramel-dipping-sauce.html)_
@@ -19,7 +19,7 @@ It's aimed to be as simple as possible yet provide rich functionality usual for
* You start by creating `let container = DependencyContainer()` and **registering your dependencies, by associating a _protocol_ or _type_ to a `factory`** using `container.register { MyService() as Service }`.
* Then you can call `container.resolve() as Service` to **resolve an instance of _protocol_ or _type_** using that `DependencyContainer`.
* You can easily use Dip along with **Storyboards and Nibs** - checkout **[Dip-UI](https://github.com/AliSoftware/Dip-UI)** extensions. There is also a **[code generator](https://github.com/ilyapuchka/dipgen)** that can help to simplify registering new components.
* You can easily use Dip along with **Storyboards and Nibs** . There is also a **[code generator](https://github.com/ilyapuchka/dipgen)** that can help to simplify registering new components.
<details>
<summary>Basic usage</summary>
@@ -148,27 +148,13 @@ File an issue if you have any question. Pull requests are warmly welcome too.
## Installation
Since version 5.0.0 Dip is built with Swift 3.0. You can install Dip using your favorite dependency manager:
You can install Dip using your favorite dependency manager:
<details>
<summary>CocoaPods</summary>
`pod "Dip"`
To build for Swift 2.3 add this code to the bottom of your Podfile
```ruby
post_install do |installer|
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '2.3'
end
end
end
```
> You need at least 1.1.0.rc.2 version of CocoaPods.
</details>
<details>
+1 -1
View File
@@ -9,7 +9,7 @@
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.1</string>
<string>7.0.1</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
+1 -1
View File
@@ -9,7 +9,7 @@
<key>CFBundleIdentifier</key>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.1</string>
<string>7.0.1</string>
<key>CFBundleName</key>
<string>$(PRODUCT_NAME)</string>
<key>CFBundlePackageType</key>
+12 -12
View File
@@ -35,10 +35,10 @@ public enum ComponentScope {
```
container.register { ServiceImp() as Service }
container.register {
ServiceConsumerImp(
service1: try container.resolve() as Service
service2: try container.resolve() as Service
) as ServiceConsumer
ServiceConsumerImp(
service1: try container.resolve() as Service
service2: try container.resolve() as Service
) as ServiceConsumer
}
let consumer = container.resolve() as ServiceConsumer
consumer.service1 !== consumer.service2 //true
@@ -59,10 +59,10 @@ public enum ComponentScope {
```
container.register { ServiceImp() as Service }
container.register {
ServiceConsumerImp(
service1: try container.resolve() as Service
service2: try container.resolve() as Service
) as ServiceConsumer
ServiceConsumerImp(
service1: try container.resolve() as Service
service2: try container.resolve() as Service
) as ServiceConsumer
}
let consumer1 = container.resolve() as ServiceConsumer
let consumer2 = container.resolve() as ServiceConsumer
@@ -89,10 +89,10 @@ public enum ComponentScope {
```
container.register(.singleton) { ServiceImp() as Service }
container.register {
ServiceConsumerImp(
service1: try container.resolve() as Service
service2: try container.resolve() as Service
) as ServiceConsumer
ServiceConsumerImp(
service1: try container.resolve() as Service
service2: try container.resolve() as Service
) as ServiceConsumer
}
let consumer1 = container.resolve() as ServiceConsumer
let consumer2 = container.resolve() as ServiceConsumer
+15 -1
View File
@@ -80,6 +80,7 @@ public final class Definition<T, U>: DefinitionType {
let scope: ComponentScope
var weakFactory: ((Any) throws -> Any)!
var resolveProperties: ((DependencyContainer, Any) throws -> ())?
var autoInjectProperties: Bool?
init(scope: ComponentScope, factory: @escaping F) {
self.factory = factory
@@ -125,6 +126,18 @@ public final class Definition<T, U>: DefinitionType {
return self
}
/**
Whether container should perform properties auto-injection when resolving using this definition.
If called will override container configuration. Can be called together with `resolvingProperties`
to resolve properties that are not automatically injected.
- parameter shouldAutoInject: Whether container should perform properties auto-injection when resolving using this definition. Default is `true`.
*/
@discardableResult public func autoInjectingProperties(_ shouldAutoInject: Bool = true) -> Definition {
autoInjectProperties = shouldAutoInject
return self
}
/// Calls `resolveDependencies` block if it was set.
func resolveProperties(of instance: Any, container: DependencyContainer) throws {
guard let resolvedInstance = instance as? T else { return }
@@ -144,7 +157,7 @@ public final class Definition<T, U>: DefinitionType {
//MARK: - TypeForwardingDefinition
/// Types that can be resolved using this definition.
private(set) var implementingTypes: [Any.Type] = [(T?).self, (T!).self]
private(set) var implementingTypes: [Any.Type] = [(T?).self]
/// Return `true` if type can be resolved using this definition
func doesImplements(type aType: Any.Type) -> Bool {
@@ -204,6 +217,7 @@ protocol _Definition: AutoWiringDefinition, TypeForwardingDefinition {
var weakFactory: ((Any) throws -> Any)! { get }
func resolveProperties(of instance: Any, container: DependencyContainer) throws
var container: DependencyContainer? { get set }
var autoInjectProperties: Bool? { get }
}
//MARK: - Type Forwarding
+8 -4
View File
@@ -38,7 +38,8 @@ public final class DependencyContainer {
case String(StringLiteralType)
case Int(IntegerLiteralType)
}
var autoInjectProperties: Bool
internal(set) public var context: Context!
var definitions = [DefinitionKey: _Definition]()
var resolvedInstances = ResolvedInstances()
@@ -59,8 +60,10 @@ public final class DependencyContainer {
/**
Designated initializer for a DependencyContainer
- parameter configBlock: A configuration block in which you typically put all you `register` calls.
- Parameters:
- autoInjectProperties: Whether container should perform properties auto-injection. Default is `true`.
- configBlock: A configuration block in which you typically put all you `register` calls.
- note: The `configBlock` is simply called at the end of the `init` to let you configure everything.
It is only present for convenience to have a cleaner syntax when declaring and initializing
@@ -79,7 +82,8 @@ public final class DependencyContainer {
- returns: A new DependencyContainer.
*/
public init(configBlock: (DependencyContainer)->() = { _ in }) {
public init(autoInjectProperties: Bool = true, configBlock: (DependencyContainer)->() = { _ in }) {
self.autoInjectProperties = autoInjectProperties
configBlock(self)
}
+15 -10
View File
@@ -199,7 +199,7 @@ extension DependencyContainer {
That happens because when Optional is casted to Any Swift can not implicitly unwrap it with as operator.
As a workaround we detect boxing here and unwrap it so that we return not a box, but wrapped instance.
*/
if let box = resolvedInstance as? BoxType, let unboxed = box.unboxed as? T {
if let box = resolvedInstance as? BoxType, let unboxedAny = box.unboxed, let unboxed = unboxedAny as? T {
resolvedInstance = unboxed
}
@@ -217,8 +217,11 @@ extension DependencyContainer {
resolvedInstances.resolvableInstances.append(resolvable)
resolvable.resolveDependencies(self)
}
try autoInjectProperties(in: resolvedInstance)
let shouldAutoInject = definition.autoInjectProperties ?? self.autoInjectProperties
if shouldAutoInject {
try autoInjectProperties(in: resolvedInstance)
}
try definition.resolveProperties(of: resolvedInstance, container: self)
log(level: .Verbose, "Resolved type \(key.type) with \(resolvedInstance)")
@@ -227,7 +230,7 @@ extension DependencyContainer {
private func previouslyResolved<T>(for definition: _Definition, key: DefinitionKey) -> T? {
//first check if exact key was already resolved
if let previouslyResolved = resolvedInstances[key: key, inScope: definition.scope, context: context] as? T {
if let previouslyResolved: T = resolvedInstances[key: key, inScope: definition.scope, context: context] {
return previouslyResolved
}
//then check if any related type was already resolved
@@ -235,7 +238,7 @@ extension DependencyContainer {
DefinitionKey(type: $0, typeOfArguments: key.typeOfArguments, tag: key.tag)
})
for key in keys {
if let previouslyResolved = resolvedInstances[key: key, inScope: definition.scope, context: context] as? T {
if let previouslyResolved: T = resolvedInstances[key: key, inScope: definition.scope, context: context] {
return previouslyResolved
}
}
@@ -280,20 +283,22 @@ class ResolvedInstances {
}
var weakSingletons = [DefinitionKey: Any]()
subscript(key key: DefinitionKey, inScope scope: ComponentScope, context context: DependencyContainer.Context) -> Any? {
subscript<T>(key key: DefinitionKey, inScope scope: ComponentScope, context context: DependencyContainer.Context) -> T? {
get {
let instance: Any?
switch scope {
case .singleton, .eagerSingleton:
return context.inCollaboration ? sharedSingletons[key] : singletons[key]
instance = context.inCollaboration ? sharedSingletons[key] : singletons[key]
case .weakSingleton:
let singletons = context.inCollaboration ? sharedWeakSingletons : weakSingletons
if let boxed = singletons[key] as? WeakBoxType { return boxed.unboxed }
else { return singletons[key] }
if let boxed = singletons[key] as? WeakBoxType { instance = boxed.unboxed }
else { instance = singletons[key] }
case .shared:
return resolvedInstances[key]
instance = resolvedInstances[key]
case .unique:
return nil
}
return instance.flatMap { $0 as? T }
}
set {
switch scope {
+245
View File
@@ -0,0 +1,245 @@
//
// DipUI
//
// Copyright (c) 2016 Ilya Puchka <ilyapuchka@gmail.com>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
//
#if (canImport(UIKit) || canImport(AppKit) || canImport(WatchKit)) && !SWIFT_PACKAGE
extension DependencyContainer {
///Containers that will be used to resolve dependencies of instances, created by stroyboards.
static public var uiContainers: [DependencyContainer] = {
#if os(watchOS)
swizzleAwakeWithContext
#endif
return []
}()
/**
Resolves dependencies of passed in instance.
Use this method to resolve dependencies of object created by storyboard.
The type of the instance should be registered in the container.
You should call this method only from implementation of `didInstantiateFromStoryboard(_:tag:)`
of `StoryboardInstantiatable` protocol if you override its default implementation.
This method will do the same as `resolve(tag:) as T`, but instead of creating
a new intance with a registered factory it will use passed in instance as a resolved instance.
- parameters:
- instance: The object which dependencies should be resolved
- tag: An optional tag used to register the type (`T`) in the container
**Example**:
```swift
class ViewController: UIViewController, ServiceDelegate, StoryboardInstantiatable {
var service: Service?
func didInstantiateFromStoryboard(_ container: DependencyContainer, tag: DependencyContainer.Tag?) throws {
try container.resolveDependencies(of: self as ServiceDelegate, tag: "vc")
}
}
class ServiceImp: Service {
weak var delegate: ServiceDelegate?
}
container.register(tag: "vc") { ViewController() }
.resolvingProperties { container, controller in
controller.service = try container.resolve() as Service
controller.service.delegate = controller
}
container.register { ServiceImp() as Service }
```
- seealso: `register(_:type:tag:factory:)`, `didInstantiateFromStoryboard(_:tag:)`
*/
public func resolveDependencies<T>(of instance: T, tag: Tag? = nil) throws {
_ = try resolve(tag: tag) { (_: () throws -> T) in instance }
}
/**
Register storyboard type `T` which has to conform to `StoryboardInstantiatable` and associate it with an optional tag.
- parameters:
- type: Storyboard type to register definition for.
- tag: The arbitrary tag to associate this factory with. Pass `nil` to associate with any tag. Default value is `nil`.
- returns: A registered definition.
- note: This method will register concrete types. If you need to register
as abstract types you should use standard `register` method from Dip.
You should cast the factory return type to the protocol you want to
register it for (unless you want to register concrete type) or
provide `type` parameter.
- seealso: `Definition`, `ComponentScope`, `DependencyTagConvertible`
**Example**:
```swift
// Register MyViewController
container.register(storyboardType: MyViewController.self)
// or
container.register(tag: "myVC") { MyViewController() as MyViewControllerType }
```
*/
public func register<T: NSObject>(storyboardType type: T.Type, tag: DependencyTagConvertible? = nil) -> Dip.Definition<T, ()> where T: StoryboardInstantiatable {
return register(.unique, type: type, tag: tag, factory: { T() })
}
}
#if os(watchOS)
public protocol StoryboardInstantiatableType {}
#else
public typealias StoryboardInstantiatableType = NSObjectProtocol
#endif
public protocol StoryboardInstantiatable: StoryboardInstantiatableType {
/**
This method will be called if you set a `dipTag` attirbute on the object in a storyboard
that conforms to `StoryboardInstantiatable` protocol.
- parameters:
- tag: The tag value, that was set on the object in a storyboard
- container: The `DependencyContainer` associated with storyboards
The type that implements `StoryboardInstantiatable` protocol should be registered in `UIStoryboard.container`.
Default implementation of that method calls `resolveDependenciesOf(_:tag:)`
and pass it `self` instance and the tag.
Usually you will not need to override the default implementation of this method
if you registered the type of the instance as a concrete type in the container.
Then you only need to add conformance to `StoryboardInstantiatable`.
You may want to override it if you want to add custom logic before/after resolving dependencies
or you want to resolve the instance as implementation of some protocol which it conforms to.
- warning: This method will be called after `init?(coder:)` but before `awakeFromNib` method of `NSObject`.
On watchOS this method will be called before `awakeWithContext(_:)`.
**Example**:
```swift
extension MyViewController: SomeProtocol { ... }
extension MyViewController: StoryboardInstantiatable {
func didInstantiateFromStoryboard(_ container: DependencyContainer, tag: DependencyContainer.Tag) throws {
//resolve dependencies of the instance as SomeProtocol type
try container.resolveDependencies(of: self as SomeProtocol, tag: tag)
//do some additional setup here
}
}
```
*/
func didInstantiateFromStoryboard(_ container: DependencyContainer, tag: DependencyContainer.Tag?) throws
}
extension StoryboardInstantiatable {
public func didInstantiateFromStoryboard(_ container: DependencyContainer, tag: DependencyContainer.Tag?) throws {
try container.resolveDependencies(of: self, tag: tag)
}
}
#if os(iOS) || os(tvOS) || os(OSX)
#if os(iOS) || os(tvOS)
import UIKit
#elseif os(OSX)
import AppKit
#endif
let DipTagAssociatedObjectKey = UnsafeMutablePointer<Int8>.allocate(capacity: 1)
extension NSObject {
///A string tag that will be used to resolve dependencies of this instance
///if it implements `StoryboardInstantiatable` protocol.
@objc private(set) public var dipTag: String? {
get {
return objc_getAssociatedObject(self, DipTagAssociatedObjectKey) as? String
}
set {
objc_setAssociatedObject(self, DipTagAssociatedObjectKey, newValue, .OBJC_ASSOCIATION_COPY_NONATOMIC)
guard let instantiatable = self as? StoryboardInstantiatable else { return }
let tag = dipTag.map(DependencyContainer.Tag.String)
for (index, container) in DependencyContainer.uiContainers.enumerated() {
do {
log("Trying to resolve \(type(of: self)) with UI container at index \(index)")
try instantiatable.didInstantiateFromStoryboard(container, tag: tag)
log("Resolved \(type(of: self))")
return
} catch { }
}
}
}
}
func log(_ message: Any) {
if Dip.LogLevel.Errors.rawValue <= Dip.logLevel.rawValue {
Dip.logger(logLevel, message)
}
}
#else
import WatchKit
let swizzleAwakeWithContext: Void = {
let originalSelector = #selector(WKInterfaceController.awake(withContext:))
let swizzledSelector = #selector(WKInterfaceController.dip_awake(withContext:))
guard let originalMethod = class_getInstanceMethod(WKInterfaceController.self, originalSelector),
let swizzledMethod = class_getInstanceMethod(WKInterfaceController.self, swizzledSelector) else { return }
let didAddMethod = class_addMethod(WKInterfaceController.self, originalSelector, method_getImplementation(swizzledMethod), method_getTypeEncoding(swizzledMethod))
if didAddMethod {
class_replaceMethod(WKInterfaceController.self, swizzledSelector, method_getImplementation(originalMethod), method_getTypeEncoding(originalMethod))
} else {
method_exchangeImplementations(originalMethod, swizzledMethod)
}
}()
extension WKInterfaceController: StoryboardInstantiatableType {
@objc func dip_awake(withContext context: AnyObject?) {
defer { self.dip_awake(withContext: context) }
guard let instantiatable = self as? StoryboardInstantiatable else { return }
for container in DependencyContainer.uiContainers {
guard let _ = try? instantiatable.didInstantiateFromStoryboard(container, tag: nil) else { continue }
break
}
}
}
#endif
#endif
-5
View File
@@ -48,11 +48,6 @@ extension Optional: BoxType {
}
}
extension ImplicitlyUnwrappedOptional: BoxType {
var unboxed: Any? {
return self ?? nil
}
}
class Box<T> {
var unboxed: T
+42 -4
View File
@@ -26,7 +26,7 @@ import XCTest
@testable import Dip
private protocol Server: class {
weak var client: Client! {get}
var client: Client! {get}
var anotherClient: Client! {get set}
}
@@ -47,7 +47,7 @@ private class ServerImp: Server {
weak var anotherClient: Client!
weak var _optionalProperty = InjectedWeak<AnyObject>(required: false)
var _optionalProperty = InjectedWeak<AnyObject>(required: false)
}
private class ClientImp: Client {
@@ -109,7 +109,10 @@ class AutoInjectionTests: XCTestCase {
("testThatItResolvesTaggedAutoInjectedProperties", testThatItResolvesTaggedAutoInjectedProperties),
("testThatItPassesTagToAutoInjectedProperty", testThatItPassesTagToAutoInjectedProperty),
("testThatItDoesNotPassTagToAutoInjectedPropertyWithExplicitTag", testThatItDoesNotPassTagToAutoInjectedPropertyWithExplicitTag),
("testThatItAutoInjectsPropertyWithCollaboratingContainer", testThatItAutoInjectsPropertyWithCollaboratingContainer)
("testThatItAutoInjectsPropertyWithCollaboratingContainer", testThatItAutoInjectsPropertyWithCollaboratingContainer),
("testThatItDoesNotAutoInjectIfDisabled", testThatItDoesNotAutoInjectIfDisabledInDefinition),
("testThatItDoesNotAutoInjectIfDisabledInContainer", testThatItDoesNotAutoInjectIfDisabledInContainer),
("testThatItAutoInjectsWhenOverridenInDefinition", testThatItAutoInjectsWhenOverridenInDefinition),
]
}()
@@ -372,6 +375,41 @@ class AutoInjectionTests: XCTestCase {
let server = client.server
XCTAssertTrue(client === server?.client)
}
func testThatItDoesNotAutoInjectIfDisabledInDefinition() {
container.register { ServerImp() as Server }
container.register { ClientImp() as Client }
.autoInjectingProperties(false)
let client = try! container.resolve() as Client
let server = client.server
XCTAssertNil(server)
}
func testThatItDoesNotAutoInjectIfDisabledInContainer() {
let container = DependencyContainer(autoInjectProperties: false)
container.register { ServerImp() as Server }
container.register { ClientImp() as Client }
let client = try! container.resolve() as Client
let server = client.server
XCTAssertNil(server)
}
func testThatItAutoInjectsWhenOverridenInDefinition() {
let container = DependencyContainer(autoInjectProperties: false)
container.register { ServerImp() as Server }
container.register { ClientImp() as Client }
.autoInjectingProperties(true)
let client = try! container.resolve() as Client
let server = client.server
XCTAssertNotNil(server)
XCTAssertNil(server?.client)
}
}
-8
View File
@@ -467,17 +467,9 @@ class AutoWiringTests: XCTestCase {
AssertNoThrow(expression: resolved = try container.resolve() as AutoWiredClient?)
XCTAssertNotNil(resolved)
//when
AssertNoThrow(expression: resolved = try container.resolve() as AutoWiredClient!)
XCTAssertNotNil(resolved)
//when
AssertNoThrow(expression: resolved = try container.resolve(tag: "tag") as AutoWiredClient?)
XCTAssertNotNil(resolved)
//when
AssertNoThrow(expression: resolved = try container.resolve(tag: "tag") as AutoWiredClient!)
XCTAssertNotNil(resolved)
}
}
+1 -7
View File
@@ -301,23 +301,17 @@ class ComponentScopeTests: XCTestCase {
func testThatItReusesResolvedInstanceWhenResolvingOptional() {
var otherService: Service!
var impOtherService: Service!
var anyOtherService: Any!
var anyImpOtherService: Any!
container.register { ServiceImp1() as Service }
.resolvingProperties { container, service in
otherService = try! container.resolve() as Service?
impOtherService = try! container.resolve() as Service!
anyOtherService = try! container.resolve((Service?).self)
anyImpOtherService = try! container.resolve((Service!).self)
}
let service = try! container.resolve() as Service
XCTAssertTrue(otherService as! ServiceImp1 === service as! ServiceImp1)
XCTAssertTrue(impOtherService as! ServiceImp1 === service as! ServiceImp1)
XCTAssertTrue(anyOtherService as! ServiceImp1 === service as! ServiceImp1)
XCTAssertTrue(anyImpOtherService as! ServiceImp1 === service as! ServiceImp1)
}
func testThatItHoldsWeakReferenceToWeakSingletonInstance() {
-1
View File
@@ -116,7 +116,6 @@ class DefinitionTests: XCTestCase {
let def = Definition<Service, ()>(scope: .unique) { ServiceImp() as Service }
XCTAssertTrue(def.implementingTypes.contains(where: { $0 == Service?.self }))
XCTAssertTrue(def.implementingTypes.contains(where: { $0 == Service!.self }))
}
}
+38 -28
View File
@@ -30,7 +30,7 @@ private class ServiceImp1: Service { }
private class ServiceImp2: Service { }
private protocol Server: class {
weak var client: Client! { get }
var client: Client! { get }
}
private protocol Client: class {
var server: Server! { get }
@@ -124,12 +124,6 @@ class DipTests: XCTestCase {
//then
XCTAssertTrue(optService is ServiceImp1)
//and when
let impService = try! container.resolve((Service!).self)
//then
XCTAssertTrue(impService is ServiceImp1)
}
func testThatItResolvesInstanceRegisteredWithTag() {
@@ -153,12 +147,6 @@ class DipTests: XCTestCase {
//then
XCTAssertTrue(optService is ServiceImp1)
//and when
let impService = try! container.resolve((Service!).self, tag: "service")
//then
XCTAssertTrue(impService is ServiceImp1)
}
func testThatItResolvesDifferentInstancesRegisteredForDifferentTags() {
@@ -189,14 +177,6 @@ class DipTests: XCTestCase {
//then
XCTAssertTrue(optService1 is ServiceImp1)
XCTAssertTrue(optService2 is ServiceImp2)
//and when
let impService1 = try! container.resolve((Service!).self, tag: "service1")
let impService2 = try! container.resolve((Service!).self, tag: "service2")
//then
XCTAssertTrue(impService1 is ServiceImp1)
XCTAssertTrue(impService2 is ServiceImp2)
}
func testThatNewRegistrationOverridesPreviousRegistration() {
@@ -242,14 +222,8 @@ class DipTests: XCTestCase {
XCTAssertTrue(resolveDependenciesCalled)
resolveDependenciesCalled = false
//and when
let _ = try! container.resolve((Service!).self)
//then
XCTAssertTrue(resolveDependenciesCalled)
}
func testThatItThrowsErrorIfCanNotFindDefinitionForType() {
//given
container.register { ServiceImp1() as ServiceImp1 }
@@ -882,3 +856,39 @@ extension DipTests {
)
}
}
extension DipTests {
// https://bugs.swift.org/browse/SR-8878
func test_weak_mirror_regression() {
class A {
static var released = false
deinit {
A.released = true
}
}
class B {
static var released = false
weak var a: A?
init(a: A) {
self.a = a
}
deinit {
B.released = true
}
}
let container = DependencyContainer()
let tag = "my_tag"
container.register(.unique, tag: tag, factory: B.init(a:))
do {
let a0 = A()
let _: B = try container.resolve(tag: tag, arguments: a0)
XCTAssertTrue(B.released)
// Due to regression in swift 4.2 Mirror retains weak children
// https://bugs.swift.org/browse/SR-8878
XCTAssertFalse(A.released)
} catch {
}
}
}
+252
View File
@@ -0,0 +1,252 @@
//
// DipUI
//
// Copyright (c) 2016 Ilya Puchka <ilyapuchka@gmail.com>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
//
#if (canImport(UIKit) || canImport(AppKit)) && !SWIFT_PACKAGE
import XCTest
@testable import Dip
#if canImport(UIKit)
import UIKit
typealias Storyboard = UIStoryboard
typealias ViewController = UIViewController
typealias StoryboardName = String
extension UIStoryboard {
@nonobjc
@discardableResult func instantiateViewControllerWithIdentifier(_ identifier: String) -> UIViewController {
return instantiateViewController(withIdentifier: identifier)
}
}
#else
import AppKit
typealias Storyboard = NSStoryboard
typealias ViewController = NSViewController
typealias StoryboardName = NSStoryboard.Name
extension NSStoryboard {
@discardableResult func instantiateViewControllerWithIdentifier(_ identifier: String) -> NSViewController {
return instantiateController(withIdentifier: NSStoryboard.SceneIdentifier(identifier)) as! NSViewController
}
}
#endif
#if os(iOS)
let storyboardName: StoryboardName = "UIStoryboard"
#elseif os(tvOS)
let storyboardName: StoryboardName = "TVStoryboard"
#else
let storyboardName: StoryboardName = StoryboardName("NSStoryboard")
#endif
class DipViewController: ViewController, StoryboardInstantiatable {}
class NilTagViewController: ViewController, StoryboardInstantiatable {}
class DipUITests: XCTestCase {
let storyboard: Storyboard = {
let bundle = Bundle(for: DipUITests.self)
return Storyboard(name: storyboardName, bundle: bundle)
}()
func testThatViewControllerHasDipTagProperty() {
let viewController = storyboard.instantiateViewControllerWithIdentifier("DipViewController")
XCTAssertEqual(viewController.dipTag, "vc")
}
func testThatItDoesNotResolveIfContainerIsNotSet() {
let container = DependencyContainer()
container.register(tag: "vc") { ViewController() }
.resolvingProperties { _, _ in
XCTFail("Should not resolve when container is not set.")
}
storyboard.instantiateViewControllerWithIdentifier("DipViewController")
}
func testThatItDoesNotResolveIfTagIsNotSet() {
let container = DependencyContainer()
container.register(tag: "vc") { ViewController() }
.resolvingProperties { _, _ in
XCTFail("Should not resolve when container is not set.")
}
DependencyContainer.uiContainers = [container]
storyboard.instantiateViewControllerWithIdentifier("ViewController")
}
func testThatItResolvesIfContainerAndStringTagAreSet() {
var resolved = false
let container = DependencyContainer()
container.register(storyboardType: DipViewController.self, tag: "vc")
.resolvingProperties { _, _ in
resolved = true
}
DependencyContainer.uiContainers = [container]
storyboard.instantiateViewControllerWithIdentifier("DipViewController")
XCTAssertTrue(resolved, "Should resolve when container and tag are set.")
}
func testThatItResolvesIfContainerAndNilTagAreSet() {
var resolved = false
let container = DependencyContainer()
container.register(storyboardType: NilTagViewController.self)
.resolvingProperties { _, _ in
resolved = true
}
DependencyContainer.uiContainers = [container]
storyboard.instantiateViewControllerWithIdentifier("NilTagViewController")
XCTAssertTrue(resolved, "Should resolve when container and nil tag are set.")
}
func testThatItDoesNotResolveIfTagDoesNotMatch() {
let container = DependencyContainer()
container.register(storyboardType: DipViewController.self, tag: "wrong tag")
.resolvingProperties { _, _ in
XCTFail("Should not resolve when container is not set.")
}
DependencyContainer.uiContainers = [container]
storyboard.instantiateViewControllerWithIdentifier("DipViewController")
}
func testThatItResolvesWithDefinitionWithNoTag() {
var resolved = false
let container = DependencyContainer()
container.register(storyboardType: DipViewController.self)
.resolvingProperties { _, _ in
resolved = true
}
DependencyContainer.uiContainers = [container]
storyboard.instantiateViewControllerWithIdentifier("DipViewController")
XCTAssertTrue(resolved, "Should fallback to definition with no tag.")
}
func testThatItIteratesUIContainers() {
var resolved = false
let container1 = DependencyContainer()
let container2 = DependencyContainer()
container2.register(storyboardType: DipViewController.self, tag: "vc")
.resolvingProperties { container, _ in
XCTAssertTrue(container === container2)
resolved = true
}
DependencyContainer.uiContainers = [container1, container2]
storyboard.instantiateViewControllerWithIdentifier("DipViewController")
XCTAssertTrue(resolved, "Should resolve using second container")
}
}
protocol SomeService: class {
var delegate: SomeServiceDelegate? { get set }
}
protocol SomeServiceDelegate: class { }
class SomeServiceImp: SomeService {
weak var delegate: SomeServiceDelegate?
init(delegate: SomeServiceDelegate) {
self.delegate = delegate
}
init(){}
}
protocol OtherService: class {
var delegate: OtherServiceDelegate? { get set }
}
protocol OtherServiceDelegate: class {}
class OtherServiceImp: OtherService {
weak var delegate: OtherServiceDelegate?
init(delegate: OtherServiceDelegate){
self.delegate = delegate
}
init(){}
}
protocol SomeScreen: class {
var someService: SomeService? { get set }
var otherService: OtherService? { get set }
}
class ViewControllerImp: SomeScreen, SomeServiceDelegate, OtherServiceDelegate {
var someService: SomeService?
var otherService: OtherService?
init(){}
}
extension DipUITests {
func testThatItDoesNotCreateNewInstanceWhenResolvingDependenciesOfExternalInstance() {
let container = DependencyContainer()
//given
var factoryCalled = false
container.register(.shared) { () -> SomeScreen in
factoryCalled = true
return ViewControllerImp() as SomeScreen
}
//when
let screen = ViewControllerImp()
try! container.resolveDependencies(of: screen as SomeScreen)
//then
XCTAssertFalse(factoryCalled, "Container should not create new instance when resolving dependencies of external instance.")
}
func testThatItResolvesInstanceThatImplementsSeveralProtocols() {
let container = DependencyContainer()
//given
container.register(.shared) { ViewControllerImp() as SomeScreen }
.resolvingProperties { container, resolved in
//manually provide resolved instance for the delegate properties
resolved.someService = try container.resolve() as SomeService
resolved.someService?.delegate = resolved as? SomeServiceDelegate
resolved.otherService = try container.resolve(arguments: resolved as! OtherServiceDelegate) as OtherService
}
container.register(.shared) { SomeServiceImp() as SomeService }
container.register(.shared) { OtherServiceImp(delegate: $0) as OtherService }
//when
let screen = try! container.resolve() as SomeScreen
//then
XCTAssertNotNil(screen.someService)
XCTAssertNotNil(screen.otherService)
XCTAssertTrue(screen.someService?.delegate === screen)
XCTAssertTrue(screen.otherService?.delegate === screen)
}
}
#endif
+49
View File
@@ -30,6 +30,25 @@ private protocol ForwardedType: class { }
private class ServiceImp1: NSObject, Service, ForwardedType { }
private class ServiceImp2: NSObject, Service, ForwardedType { }
private protocol Dependency {}
private struct DependencyImpl: Dependency {}
private class DependencyRefImpl: Dependency {}
private struct DependencyClient {
let dep: Dependency
init(dependency: Dependency) {
self.dep = dependency
}
}
private struct OptionalDependencyClient {
let dep: Dependency?
init(dependency: Dependency?) {
self.dep = dependency
}
}
class TypeForwardingTests: XCTestCase {
let container = DependencyContainer()
@@ -44,6 +63,7 @@ class TypeForwardingTests: XCTestCase {
("testThatItCallsResolvedDependenciesBlockProvidedAfterRegistrationWhenResolvingByTypeForwarding",testThatItCallsResolvedDependenciesBlockProvidedAfterRegistrationWhenResolvingByTypeForwarding),
("testThatItFallbackToDefinitionWithNoTagWhenResolvingInstanceByTypeForwarding", testThatItFallbackToDefinitionWithNoTagWhenResolvingInstanceByTypeForwarding),
("testThatItCanResolveOptional", testThatItCanResolveOptional),
("testThatItReusesInstancesResolvedForOptionalType", testThatItReusesInstancesResolvedForOptionalType),
("testThatItFirstUsesTaggedDefinitionWhenResolvingOptional", testThatItFirstUsesTaggedDefinitionWhenResolvingOptional),
("testThatItThrowsErrorWhenResolvingNotImplementedTypeWithTypeForwarding", testThatItThrowsErrorWhenResolvingNotImplementedTypeWithTypeForwarding),
("testThatItOverridesIfSeveralDefinitionsWithTheSameTagForwardTheSameType", testThatItOverridesIfSeveralDefinitionsWithTheSameTagForwardTheSameType),
@@ -252,6 +272,35 @@ class TypeForwardingTests: XCTestCase {
XCTAssertTrue(object is ServiceImp1)
XCTAssertTrue(anyObject is ServiceImp1)
}
func testThatItReusesInstancesResolvedForOptionalType() {
var alreadyResolved = false
container.register(.singleton) { () -> Dependency in
XCTAssertFalse(alreadyResolved)
return DependencyImpl() as Dependency
}
container.register() { DependencyClient(dependency: try! self.container.resolve()) }
container.register() { OptionalDependencyClient(dependency: try! self.container.resolve()) }
let _ = try! container.resolve() as OptionalDependencyClient
let _ = try! container.resolve() as DependencyClient
alreadyResolved = false
let _ = try! container.resolve() as DependencyClient
let _ = try! container.resolve() as OptionalDependencyClient
container.register(.singleton) { () -> Dependency in
XCTAssertFalse(alreadyResolved)
return DependencyRefImpl() as Dependency
}
let client1 = try! container.resolve() as DependencyClient
let client2 = try! container.resolve() as OptionalDependencyClient
XCTAssertTrue(client1.dep as! DependencyRefImpl === client2.dep as! DependencyRefImpl)
}
func testThatItFirstUsesTaggedDefinitionWhenResolvingOptional() {
let expectedTag: DependencyContainer.Tag = .String("tag")