GitHub/DeviceKit
1
0
Fork 0
mirror of https://github.com/devicekit/DeviceKit.git synced 2026-05-17 10:20:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Danger plist warning being triggered on every PR (#489)

Browse Source 
The warning "Plist changed, don't forget to localize your plist values" was being incorrectly shown on every PR, even when no plist file was modified. Fixed two bugs in the Dangerfile:
1. Inverted condition: Changed from `if !is_plist_change` to `if is_plist_change` so the warning only fires when a plist is actually modified
2. Wrong file path: Changed from checking `"ProjectName/Info.plist"` to `"Source/Info.plist"` to match the actual project structure
This commit is contained in:
Zandor Smith
2026-03-02 19:32:51 +01:00
committed by GitHub
parent 92f1800ce9
commit 43fedd8fc3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Dangerfile
+2 -2
View File
@@ -31,9 +31,9 @@ if has_app_changes && !has_test_changes && git.lines_of_code > 10
end
# Info.plist file shouldn't change often. Leave warning if it changes.
is_plist_change = git.modified_files.sort == ["ProjectName/Info.plist"].sort
is_plist_change = git.modified_files.include?("Source/Info.plist")
if !is_plist_change
if is_plist_change
warn "Plist changed, don't forget to localize your plist values"
end