mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

T

sebmarkbage f902e21009 Switch to binding the console with badging instead of calling it directly (#30461 )

This is a major nit but this avoids an extra stack frame when we're
replaying logs.

Normally the `printToConsole` frame doesn't show up because it'd be
ignore listed.

<img width="421" alt="Screenshot 2024-07-25 at 11 49 39 AM"
src="https://github.com/user-attachments/assets/81334c2f-e19e-476a-871e-c4db9dee294e">

When you expand to show ignore listed frames a ton of other frames show
up.

<img width="516" alt="Screenshot 2024-07-25 at 11 49 47 AM"
src="https://github.com/user-attachments/assets/2ab8bdfb-464c-408d-9176-ee2fabc114b6">

The annoying thing about this frame is that it's at the top of the stack
where as typically framework stuff ends up at the bottom and something
you can ignore. The user space stack comes first.

With this fix there's no longer any `printToConsole` frame.

<img width="590" alt="Screenshot 2024-07-25 at 12 09 09 PM"
src="https://github.com/user-attachments/assets/b8365d53-31f3-43df-abce-172d608d3c9c">

Am I wiling to eat the added complexity and slightly slower performance
for this nit? Definitely.

DiffTrain build for commit https://github.com/facebook/react/commit/e8df0cf9f7c7f641192f19841db9bf34b6a0abf7.

2024-07-25 09:37:11 -07:00

compiled-rn

Switch to binding the console with badging instead of calling it directly (#30461 )

2024-07-25 09:37:11 -07:00

README.md

fist commit

2023-02-20 16:27:42 +00:00

README.md

react-fbsource-import

Languages

JavaScript 67.1%

TypeScript 29.4%

HTML 1.5%

CSS 1.1%

C++ 0.6%

Other 0.2%