react

mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

Files

T

Philipp f47a958ea8 Don’t add onclick listener to React root (#13778 )

Fixes #13777

As part of #11927 we introduced a regression by adding onclick handler
to the React root. This causes the whole React tree to flash when tapped
on iOS devices (for reasons I outlined in
https://github.com/facebook/react/issues/12989#issuecomment-414266839).

To fix this, we should only apply onclick listeners to portal roots. I
verified that my proposed fix indeed works by checking out our DOM
fixtures and adding regression tests.

Strangely, I had to make changes to the DOM fixtures to see the behavior
in the first place. This seems to be caused by our normal sites (and 
thus their React root) being bigger than the viewport:

![](http://cl.ly/3f18f8b85e91/Screen%20Recording%202018-10-05%20at%2001.32%20AM.gif)

An alternative approach to finding out if we're appending to a React
root would be to add a third parameter to `appendChildToContainer` based
on the tag of the parent fiber.

2018-10-09 10:27:06 +02:00

create-subscription

fix - small misspelling (#13768 )

2018-10-04 04:05:51 -04:00

events

Revert "Do not bind topLevelType to dispatch" (#13674 )

2018-09-17 18:43:16 +01:00

jest-react

Jest + test renderer helpers for concurrent mode (#13751 )

2018-10-03 18:37:41 -06:00

react

Wrap retrySuspendedRoot using SchedulerTracing (#13776 )