mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00

T

josephsavona d65fb06955 fix: restore selection should consider the window of the container (#30951 )

## Summary

Fixes #30864

Before this PR the active elemen was always taken from the global
`window`. This is incorrect if the renderer is in one window rendering
into a container element in another window. The changes in this PR adds
another code branch to use a `defaultView` of the container element if
it exists so that `restoreSelection` after a commit will actually
restore to the correct window.

## How did you test this change?

I patched these changes to the repro repo in the linked issue #39864
https://github.com/ling1726/react-child-window-focus-repro/blob/master/patches/react-dom%2B18.3.1.patch.

I followed the same repro steps in the linked issue and and could not
repro the reported problem. Attaching screen recordings below:

Before
![focus
repro](https://github.com/user-attachments/assets/81c4b4f9-08b5-4356-8251-49b909771f3f)

After

![after](https://github.com/user-attachments/assets/84883032-5558-4650-9b9a-bd4d5fd9cb13)

DiffTrain build for [d9c4920e8b](https://github.com/facebook/react/commit/d9c4920e8b3fff3d3da24d14adf7ac884aee55b2)

2024-09-13 13:36:35 -07:00

compiled

fix: restore selection should consider the window of the container (#30951 )

2024-09-13 13:36:35 -07:00

.gitattributes

.gitattributes to ensure LF line endings when we should

2014-01-17 16:25:53 -08:00

.gitignore

Renamed packages/react-devtools-scheduling-profiler to packages/react-devtools-timeline (#22691 )

2021-11-04 10:02:06 -04:00

LICENSE

[Codemod] Update copyright header to Meta (#25315 )