Joe Savona 79e3fc0acb Fix for method call not memoizing in same scope as outer call ...

Fixes T175282980. InferReactiveScopeVariables had logic to force assigning a 
scope to MethodCall property lookups with the idea of forcing the method call 
lookup to be in the same scope as the method call itself. But this doesn't work 
if we never assign a scope to the method call! That can happen if we're able to 
infer that the method call produces a primitive and doesn't need memoization. 

This PR changes things so that: 

* InferReactiveScopeVariables no longer assumes that MethodCall property values 
need a scope 

* We run a separate pass that ensures that _if_ a MethodCall has a scope, that 
it's property is in the scope, and that otherwise its property doesn't get a 
scope. This is similar to the existing passes that force a single scope for 
related instructions like ObjectMethod+ObjectExpression and fbt operands/calls.

2024-03-13 13:52:29 -07:00

compiler

Fix for method call not memoizing in same scope as outer call

2024-03-13 13:52:29 -07:00

S

Description

No description provided

declarativefrontendjavascriptlibraryreactui

MIT

1.8 GiB

Languages

JavaScript 67.1%

TypeScript 29.4%

HTML 1.5%

CSS 1.1%

C++ 0.6%

Other 0.2%