Dan Abramov
f123763fe1
Read index off the Fiber
2019-04-24 15:05:33 +01:00
Dan Abramov
5d2d4213ec
Delete stale paths
2019-04-24 15:05:21 +01:00
Dan Abramov
e050529c7d
Read renderer ID from operations
2019-04-24 15:00:46 +01:00
Dan Abramov
26162988aa
Fix tests
2019-04-24 14:37:46 +01:00
Dan Abramov
7eb7c5a350
Match Fibers to saved selection as they mount
...
This implements matching Fibers against the tracked selection path.
The algorithm is optimized to do as little checks as possible:
* When not trying to restore selection, we don't do anything
* When restoring selection, we only check .return pointers of new mounts
* Only when .return pointers match our current deepest match, we compare the frames
2019-04-24 14:37:46 +01:00
Dan Abramov
3bb837b683
Implement getPathForElement to serialize the selected path
...
Note this doesn't restore the selection yet.
2019-04-24 14:37:46 +01:00
Dan Abramov
b1a7007cc5
Keep track of root insertion order in the renderer
...
Normally, Fibers have key or index which we'll use to match things up between reloads. However, roots don't have such a concept. We'll use their insertion order as an approximation. If it's consistent, we'll be able to restore the selection.
2019-04-24 14:37:46 +01:00
Dan Abramov
d8abecdcf9
Persist and restore selection in agent
...
This implements the infrastructure for saving and restoring renderer-specific selection state in the session storage.
Note this doesn't actually implement the calculation and tracking of paths in the renderer. It only simulates that the renderer can do it. The actual implementation will come in a later commit.
2019-04-24 14:37:46 +01:00
Brian Vaughn and GitHub
085d00e877
Merge pull request #196 from bvaughn/selected-element-suspense
...
Convert inspected element (right panel) to use Suspense
2019-04-23 18:33:05 -07:00
Brian Vaughn
7262a30cf3
Reverted optimization to avoid re-sending inspected fiber unless it committed
2019-04-23 18:04:25 -07:00
Brian Vaughn
0aa7d2f800
Reverted optimization to avoid re-sending inspected fiber unless it committed
2019-04-23 14:03:58 -07:00
Brian Vaughn
1e5c0b7856
Re-added the selection message
2019-04-23 13:43:38 -07:00
Brian Vaughn
4dcb34ea32
Fixed Flow error
2019-04-23 11:32:07 -07:00
Brian Vaughn
53c7338420
Updated flow-bin to attempt to fix the error
2019-04-23 09:00:25 -07:00
Brian Vaughn
d85f566d66
Merged master (tooltip changes)
2019-04-23 08:49:40 -07:00
Brian Vaughn
8b33dd673d
Added @reach/tooltip
2019-04-23 08:41:52 -07:00
Brian Vaughn
ec7536704d
Locked down canary versions
2019-04-22 19:32:16 -07:00
Brian Vaughn
7f1531044b
Differentiate between no-change and no-element-found when inspecting element
2019-04-22 15:37:55 -07:00
Brian Vaughn
00872e2e51
Fixed suspense fallback issue by moving inspection message side effect before suspending render
2019-04-22 15:25:55 -07:00
Brian Vaughn
64bb2d31f9
Fixed bug with cache invalidation
2019-04-22 15:18:32 -07:00
Brian Vaughn
64bc49d523
Run first setState with explicit priority in case of non-React event handlers
2019-04-22 15:11:04 -07:00
Brian Vaughn
e31ae91023
Removed duplicate scheduler module
2019-04-22 13:10:47 -07:00
Brian Vaughn
ba640df982
Merge branch 'master' into selected-element-suspense
2019-04-22 10:47:34 -07:00
Brian Vaughn
433934f55e
Refactored TreeContext to use less memoization (based on feedback from Sebastian)
2019-04-22 10:39:21 -07:00
Brian Vaughn
d53ae2ea8a
Refactored TreeContext to use less memoization (based on feedback from Sebastian)
2019-04-22 10:19:59 -07:00
Brian Vaughn
70be637d48
Don't schedule an update with React unless the curent element was invalidated
2019-04-22 09:37:55 -07:00
Brian Vaughn
5970bf4b40
Changed polling approach. Fixed remove event typo.
2019-04-22 09:37:55 -07:00
Brian Vaughn
3de18de25e
Tried to implement two setState pattern, but it does not feel right
2019-04-22 09:37:55 -07:00
Brian Vaughn
957c389566
Adding polling and initial stab at not serializing duplicate inspected Element props
2019-04-22 09:37:34 -07:00
Brian Vaughn
c6b19cc141
Refactored insepected element cache to use the context API
2019-04-22 09:37:34 -07:00
Brian Vaughn
09b023a6e6
Naive suspense implementation for selected element panel
...
This commit leaves a few major things uunresolved:
* We aren't yet polling for updates
* We aren't yet using the two setState pattern
* The resource cache will grow unbounded over time because we aren't yet clearing items from it
* The renderer interface is not smart enough to avoid resending unchanged data between requests
2019-04-22 09:37:34 -07:00
Brian Vaughn and GitHub
76b29ad0a9
Merge pull request #201 from gaearon/scroll-fix
...
Fix scrolling to selected row in collapsed mode
2019-04-22 09:37:15 -07:00
Brian Vaughn
52652f3456
Toggle method no longer emits 'mutated' event unless it mutated the store
2019-04-21 12:20:23 -07:00
Brian Vaughn
129466ed91
Yarn deploy sets production NODE_ENV
2019-04-21 09:05:55 -07:00
Brian Vaughn and GitHub
a01fc44a78
Merge pull request #205 from bvaughn/@reach/tooltip
...
[BLOCKED] Use new @reach/tooltip
2019-04-21 09:01:23 -07:00
Brian Vaughn
91f74a5134
Fixed focus styles for OwnersStack dropdown toggle button
2019-04-21 08:59:24 -07:00
Brian Vaughn
09b995ab1c
Tidied up CSS variables
2019-04-21 08:38:58 -07:00
Brian Vaughn
66df03d179
Renamed CSS var color-text-color to color-text
2019-04-21 08:29:51 -07:00
Brian Vaughn
8220df734c
Tweaked hover and focus colors. Temporarily disabled Tooltip.
2019-04-21 08:23:20 -07:00
Brian Vaughn
a129089891
Tweaking focus/active colors and only showing focus rect on tab
2019-04-20 15:44:24 -07:00
Brian Vaughn
403bf49a78
Use new @reach/tooltip
2019-04-20 14:29:03 -07:00
Brian Vaughn and GitHub
4218dcbf99
Merge pull request #203 from gaearon/push-ops
...
Push operations directly to the array
2019-04-20 14:27:53 -07:00
Brian Vaughn and GitHub
740993baa9
Merge branch 'master' into push-ops
2019-04-20 14:26:46 -07:00
Brian Vaughn and GitHub
72156c744f
Merge pull request #204 from gaearon/no-weakset
...
Replace WeakSet with return pointer check
2019-04-20 14:23:59 -07:00
Brian Vaughn and GitHub
94d9f61a7d
Merge pull request #206 from gaearon/leading
...
Ignore leading edge of find-by-DOM throttle
2019-04-20 14:22:49 -07:00
Dan Abramov
006e03c38e
Ignore leading edge of find-by-DOM throttle
2019-04-20 22:17:12 +01:00
Dan Abramov
c0d7023a88
Replace WeakSet with return pointer check
2019-04-20 21:42:30 +01:00
Dan Abramov
02a3a22753
Push operations directly to the array
2019-04-20 21:05:52 +01:00
Brian Vaughn
4b9082eea1
Changed style and position of search-for-element button to more closely matchin Chrome ( based on user testing)
2019-04-20 10:44:03 -07:00
Dan Abramov
4ffdffb598
Fix scrolling to selected row in collapsed mode
2019-04-20 16:20:03 +01:00
Dan Abramov
Brian VaughnandGitHub
Brian Vaughn