Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,190 Commits 681 Branches 148 Tags
ea8e06283c191f63e3d48bfdeddbc8f39603edd5
Commit Graph
5190 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul O’Shannessy ea8e06283c Merge pull request #4780 from matchu/patch-1 
avoid the phrase "key property"
 2015-09-03 12:50:36 -07:00
matchu 6541903bc4 avoid the phrase "key property" 
React components can be assigned a special property named `key`. Therefore, it's helpful to avoid the phrase "key property" unless you're talking about the `key` property :)

I'm not sold on the replacement phrase, though... I think it's solid, but two fancy words like "fundamental" and "invariant" next to each other just seem a bit unwelcoming xP then again, we're talking about some heavy technical stuff; if there aren't any lighter words that are equally precise, then these should probably stand.
 2015-09-03 12:03:15 -07:00
Ben Alpert 566dba25ef Merge pull request #4773 from spicyj/new-dt-blog 
New devtools blog post
 2015-09-02 15:15:27 -07:00
Ben Alpert f5bd8fc0ad New devtools blog post 2015-09-02 12:34:10 -07:00
Ben Alpert 697c09a26e Merge pull request #4759 from spicyj/devprod 
Fix diverging behavior of ReactFragment in `__DEV__`
 2015-09-01 17:35:14 -07:00
Ben Alpert 4b9c349fd0 Merge pull request #4702 from spicyj/react-mod-depr 
Add deprecation warnings to React module
 2015-09-01 14:40:48 -07:00
Ben Alpert 4d29125d39 Merge pull request #4764 from spicyj/pre-commit 
Remove leftover env variable logic in pre-commit hook
 2015-09-01 14:39:53 -07:00
Ben Alpert c04d02e5e8 Add warnings to React module 2015-09-01 14:36:41 -07:00
Ben Alpert c74977c091 Remove leftover env variable logic in pre-commit hook 2015-09-01 14:35:47 -07:00
Ben Alpert b1e16b9d7e React -> ReactDOM in test files 2015-09-01 14:34:37 -07:00
Ben Alpert d9d8aae33e Merge pull request #4763 from spicyj/pre-commit 
Add linting pre-commit hook
 2015-09-01 14:33:49 -07:00
Ben Alpert 31cb102650 Merge pull request #4762 from spicyj/ts 
Make TypeScript test work with ReactDOM
 2015-09-01 14:30:56 -07:00
Ben Alpert 25fec05ab4 Add linting pre-commit hook 
Anyone who wants it will have to do

```
ln -s scripts/git/pre-commit .git/hooks/pre-commit
```

or similar.
 2015-09-01 14:29:52 -07:00
Ben Alpert 589c8364b0 Make TypeScript test work with ReactDOM 2015-09-01 14:28:12 -07:00
Ben Alpert 7e5ce19a94 Fix diverging behavior of ReactFragment in __DEV__ 
We could also remove the return statements but this is not a hot path and this seems safer.
 2015-09-01 13:27:17 -07:00
Paul O’Shannessy 9400b34363 Merge pull request #4746 from zpao/use-fbjs-lint 
Use eslintrc from fbjs
 2015-08-31 23:21:29 -07:00
Paul O’Shannessy 7645c07720 Use eslintrc from fbjs 2015-08-31 23:05:04 -07:00
Ben Alpert 2d63dfd73c Merge pull request #4755 from MichelleTodd/react-warnings-0.14 
Update warning messages to use ReactDOM and ReactDOMServer as appropriate
 2015-08-31 23:03:10 -07:00
Michelle Todd 719fe15b9e Update warning messages to use ReactDOM and ReactDOMServer as appropriate 
Fixes #4710.

- `React.findDOMNode` => `ReactDOM.findDOMNode`
- `React.render` => `ReactDOM.render` or "top-level render" (depends on whether we're in DOM-specific usage or generic cases)
- `React.renderToString` => `ReactDOMServer.renderToString`
- `React.renderToStaticMarkup` => `ReactDOMServer.renderToStaticMarkup`
 2015-08-31 22:55:27 -07:00
Paul O’Shannessy f118e5ebe7 Merge pull request #4750 from zpao/fbjs-0.2 
Upgrade to fbjs, fbjs-scripts @ 0.2
 2015-08-31 22:47:02 -07:00
Ben Alpert 487cc586f7 Merge pull request #4731 from spicyj/map-one-pass 
Make React.Children.map do one pass only
 2015-08-31 18:52:51 -07:00
Ben Alpert 6013105a9c Make React.Children.map do one pass only 
Changed: createFragment no longer includes nulls in its output (since toArray doesn't and they share code).

Changed: React.Children.map no longer warns for clashing keys; traverseAllChildren will later when rendering.

Also change the generated key format around to accomodate. My keys are probably not bulletproof but should definitely be safe against accidental collisions.
 2015-08-31 18:47:09 -07:00
Paul O’Shannessy 52b4c9eabf Upgrade to fbjs, fbjs-scripts @ 0.2 2015-08-31 17:19:42 -07:00
Ben Alpert dc4f011f57 Merge pull request #4735 from spicyj/shallow-error 
Better error for invalid element when shallow rendering
 2015-08-31 13:30:56 -07:00
Ben Alpert 0e2bf2fe75 Merge pull request #4744 from spicyj/gh-4635-f 
Fix code style/grammar on synthetic event warning
 2015-08-31 13:06:46 -07:00
Paul O’Shannessy dc23faf64d Merge pull request #4739 from henrik/patch-1 
docs: "also lets pass" -> "also lets you pass"
 2015-08-31 11:44:29 -07:00
Ben Alpert 42602a8922 Fix code style/grammar on synthetic event warning 2015-08-31 11:32:12 -07:00
Jim 0ff65cc892 Merge pull request #4635 from edvinerikson/event-pooling-warning 
Added warning when calling methods on a released event.
 2015-08-31 10:49:01 -07:00
Henrik Nyh 01151c1dea docs: "also lets pass" -> "also lets you pass" 2015-08-30 10:19:34 +02:00
Ben Alpert f641f29db0 Merge pull request #4737 from oliviertassinari/patch-1 
[adler32] fix wrong name
 2015-08-29 11:18:18 -07:00
Olivier Tassinari 0304051591 [adler32] fix wrong name 2015-08-29 19:07:36 +01:00
Ben Alpert f4d7feb8be Better error for invalid element when shallow rendering 
Fixes #4721, fixes #4730.
 2015-08-28 18:21:30 -07:00
Ben Alpert a7230de902 Merge pull request #4727 from spicyj/gh-4233 
Make findDOMNode error clearer
 2015-08-28 12:52:18 -07:00
Paul O’Shannessy e53cee9af6 Merge pull request #4734 from zpao/reverse-logic 
Reverse condition of a ternary for readability
 2015-08-28 11:39:48 -07:00
Paul O’Shannessy 2e5b047f04 Reverse condition of a ternary for readability 2015-08-28 11:34:50 -07:00
Ben Alpert 024f71535c Merge pull request #4720 from spicyj/destructor 
Add destructors to pooled classes in ReactChildren
 2015-08-27 19:06:11 -07:00
Ben Alpert 16d8f20576 Add destructors to pooled classes in ReactChildren 
And make destructors mandatory so we're less likely to forget again.
 2015-08-27 19:05:56 -07:00
Paul O’Shannessy bdc7ce9f01 Merge pull request #4482 from niole/issue4168 
Add additional contextual information to invalid-style-prop warning
 2015-08-27 18:13:29 -07:00
Niole Nelson 70c07c67b7 resolves issue #4168, style prop error now names React class that erroring element is a child of. 2015-08-27 18:10:51 -07:00
Ben Alpert 8b967052d8 Merge pull request #4732 from spicyj/eslint-undef 
Enable no-undef for eslint
 2015-08-27 18:07:51 -07:00
Ben Alpert 75873707f9 Enable no-undef for eslint 2015-08-27 18:03:14 -07:00
Ben Alpert 72d5b8f116 Merge pull request #4700 from spicyj/frag-array 
Make createFragment return an array, disallow objects as children
 2015-08-26 11:12:06 -07:00
Ben Alpert 127917d454 Merge pull request #4701 from spicyj/gh-4525 
Add deprecation notice for React.addons.batchedUpdates
 2015-08-25 11:40:33 -07:00
Ben Alpert d4f38933f2 Merge pull request #4703 from spicyj/rarr 
Clarify use of arrow functions
 2015-08-25 11:38:13 -07:00
Ben Alpert 66881ae083 Fix formatting in test utils docs 2015-08-25 09:47:38 -07:00
Edvin Erikson 34af8f8597 Added warning when calling methods on a released event. 2015-08-25 14:45:56 +02:00
Ben Alpert d15938cd92 Clarify use of arrow functions 
Per https://github.com/facebook/react/commit/1db20999f0336cfacc6af5ee6f5a77803d74381b#commitcomment-12865588.
 2015-08-24 17:21:10 -07:00
Ben Alpert e64b402df9 Add deprecation notice for React.addons.batchedUpdates 
Fixes #4525.
 2015-08-24 16:20:56 -07:00
Ben Alpert 6a2cdd58a4 Make findDOMNode error clearer 
Fixes #4233.
 2015-08-24 16:15:44 -07:00
Ben Alpert 6abf025d46 Make createFragment return an array, disallow objects as children 2015-08-24 16:09:08 -07:00