Commit Graph

3710 Commits

Author SHA1 Message Date
Paul O’Shannessy e60db7316f Merge pull request #3198 from zpao/jsx-option-parsing
Move option parsing into react-tools proper.
2015-02-19 15:54:11 -08:00
Paul O’Shannessy 0f85884fa4 Merge pull request #3201 from zpao/non-factory-invariant
Warn when using constructor function directly
2015-02-19 15:53:50 -08:00
Sebastian Markbåge 977204991b Merge pull request #3205 from sebmarkbage/warningfixes
More warnings to ReactFragment.create
2015-02-19 15:43:18 -08:00
Sebastian Markbage 5a2c80382c More warnings to ReactFragment.create
Apparently I could've used these too because if you accept an arbitrary
node, then these could end up being objects, but those objects might
also be arrays or elements.
2015-02-19 15:11:49 -08:00
Paul O’Shannessy 02d225f26e Merge pull request #3193 from fisherwebdev/remove_lodash
Remove lodash devDependency
2015-02-19 14:22:34 -08:00
Paul O’Shannessy ad31cfa4dc Warn when using constructor function directly
We no longer support the legacy factory style of calling component constructors
directly. We only support createElement or the wrapping of classes with
createFactory. Instead of letting this fail in a gross way as we try to run,
add a nice warning that shows up before the gross TypeError.
2015-02-19 13:57:48 -08:00
Jim a2f77208e6 Merge pull request #3180 from cody/https
Using https URLs for embedded fiddles
2015-02-19 13:18:34 -08:00
Paul O’Shannessy 21a9e8b6e8 Merge pull request #3189 from hzoo/more-lint
More lint - remove spaces in object braces / array brackets
2015-02-19 11:42:02 -08:00
Paul O’Shannessy 629d400774 Merge pull request #3165 from oiva/jquery-mobile-example
Change how components are rendered in jQuery Mobile example. Fixes #2880
2015-02-19 10:48:26 -08:00
Paul O’Shannessy 112f7aa249 Move option parsing into react-tools proper.
We were doing some preprocessing for module options in the command line. Since
we also expose the same API via react-tools (and JSXTransformer), we need to do
the same processing from the API. So just move it all to the same place.
2015-02-19 09:46:25 -08:00
fisherwebdev 10d336d4eb Remove lodash devDependency 2015-02-18 22:41:58 -08:00
Steven Luscher f1288d1055 Added the immutability talk to the React.js Conf update.
(cherry picked from commit de8b3eb9d4)
2015-02-18 21:42:11 -08:00
Henry Zhu eba5d1365c lint: remove spaces from array brackets 2015-02-19 00:13:36 -05:00
Henry Zhu 07cfd66028 lint: remove spaces from object braces 2015-02-19 00:10:31 -05:00
Timothy Yung b0789c9582 Merge pull request #3187 from yungsters/shallow
Support unmounting in ReactShallowRenderer
2015-02-18 17:47:12 -08:00
yungsters e9e33b984f Support unmounting in ReactShallowRenderer
Reviewers: @sebmarkbage, @zpao

Test Plan:

```
$ npm test ReactTestUtils
```
2015-02-18 17:45:42 -08:00
Paul O’Shannessy 6c29eba035 Merge pull request #2821 from zpao/unitless-css-boxflex
Add boxFlex and boxFlexGroup to CSS Unitless Properties
2015-02-18 17:22:56 -08:00
Stefan Dombrowski 8ba3ba49d2 Using https for embedded fiddles
Official announcement from jsfiddle:
https://twitter.com/jsfiddle/status/565041134435852289
2015-02-18 23:07:48 +01:00
Paul O’Shannessy 6f7b9a97bf Merge pull request #3108 from zpao/quadratic-example
Replace Ballmer Peak example with Quadratic Formula
2015-02-18 14:02:17 -08:00
Paul O’Shannessy 1caeda30ea Replace Ballmer Peak example with Quadratic Formula 2015-02-18 13:59:26 -08:00
Steven Luscher 85a6462062 Added special edition round-up for React.js Conf 2015
(cherry picked from commit 233980826c)
2015-02-18 13:30:26 -08:00
Sebastian Markbåge 5499321d63 Merge pull request #3183 from yungsters/master
Support rendering to null in ShallowComponentRenderer
2015-02-18 11:43:07 -08:00
yungsters e952869ff8 Support rendering to null in ShallowComponentRenderer
Reviewers: @sema, @zpao

Test Plan:
```
$ npm jest
```
2015-02-18 11:31:02 -08:00
Sebastian Markbåge 00a3b9233f Merge pull request #3177 from sebmarkbage/fixbindwarningstring
Forgotten string
2015-02-17 18:26:32 -08:00
Sebastian Markbage 377319b863 Forgotten string
We forgot this `%s` as this was converted.
2015-02-17 18:26:12 -08:00
Sebastian Markbåge c61207588d Merge pull request #3175 from sebmarkbage/fixhasownorder
Avoid reading the property if hasOwnProperty is false
2015-02-17 16:02:18 -08:00
Sebastian Markbage 67cf95c16d Avoid reading the property if hasOwnProperty is false
Easy with an Object.assign polyfill
2015-02-17 15:59:01 -08:00
Sebastian Markbåge de3ecabd6c Merge pull request #3148 from hmarr/fix-nan-mutation-warning
Prevent NaN props from triggering warnings
2015-02-17 15:41:18 -08:00
Sebastian Markbåge cf4bef8bd7 Merge pull request #3171 from sebmarkbage/moarwarnings
Moar Warnings
2015-02-17 15:09:33 -08:00
Oiva Eskola 4c32fb487e Wrap jQuery Mobile example's components with React.createFactory to fix on v0.13.0. Fixes #2880 2015-02-18 00:13:13 +02:00
Jim f6920ba377 Merge pull request #3170 from adelevie/patch-1
Make tutorial CDN URLs use https
2015-02-17 11:50:54 -08:00
Sebastian Markbage 2490289c4a Warn if getDOMNode or isMounted is accessed in render
This is an anti-pattern that can be easily avoided by putting the logic
in componentDidMount and componentDidUpdate instead.

It creates a dependency on stale data inside render without enforcing
a two-pass render.
2015-02-17 11:49:20 -08:00
Alan deLevie 4980bcb0f3 Make tutorial CDN URLs use https 2015-02-17 14:34:01 -05:00
Sebastian Markbage 91194126d8 Warn if using Maps as children
We're not sure if this is the way we want to support this API. It creates
two ways of doing things.

It is convenient to avoid needing to explicitly redefine the key of Maps.
However, this use case isn't as common as having an iterable where the
key is on the value, not the key.
2015-02-17 11:23:12 -08:00
Paul O’Shannessy a8d9bff3ca Merge pull request #3168 from briankung/docs-jsx-namespacing
[Docs] Clarify section on namespaced components
2015-02-17 11:10:33 -08:00
Paul O’Shannessy 9e2da7a0ae Merge pull request #3164 from oiva/master
Fix sourcemap filenames when using transformWithDetails. Fixes #3140
2015-02-17 11:07:19 -08:00
Sebastian Markbage 3587460675 Warn if accessing .type on a factory
This was an important convenience as an upgrade path but shouldn't be
necessary if you're using best-practice of calling createFactory in the
consuming component.
2015-02-17 11:06:54 -08:00
Paul O’Shannessy 68a8e4491f Merge pull request #3147 from hzoo/lint-fixes
lint whitespace , trailing comma
2015-02-17 10:58:42 -08:00
Paul O’Shannessy 6cd7ab5254 Merge pull request #3154 from iamdustan/patch-1
s/upate/update
2015-02-17 10:55:42 -08:00
Brian Kung 26e0b1a298 [Docs] Clarify section on namespaced components
While going through the docs, I wasn't sure if the first example was
something I should do or not. This makes the wording a bit more clear.
2015-02-17 06:40:48 -06:00
Ben Alpert 6d97c708a9 Merge pull request #3167 from MichelleTodd/docs-grammar
[Docs] Reword section on React without JSX
2015-02-16 17:26:23 -08:00
Michelle Todd 17f2c26139 [Docs] Reword section on React without JSX
Summary:
This section was confusing. I reworded it from:

"JSX is completely optional. You don't have to use JSX with React.
You can create these trees through `React.createElement`. The first
argument is the tag, pass a properties object as the second
argument and children to the third argument."

to:

"JSX is completely optional; you don't have to use JSX with React.
You can create React elements in plain JavaScript using
`React.createElement`, which takes a tag name or component, a
properties object, and variable number of optional child
arguments."

and additionally added another child element to the example code.

Test Plan:
Read the new paragraph!
2015-02-16 17:12:19 -08:00
Ben Alpert 6729acf370 Merge pull request #3162 from vsiao/mount-element
Fix ReactMount._renderNewRootComponent signature
2015-02-16 16:05:08 -08:00
Oiva Eskola 35e24759f1 fix sourcemap filenames when using transformWithDetails. Fixes #3140 2015-02-16 22:21:51 +02:00
Vincent Siao 96e4e3cbbc Fix ReactMount._renderNewRootComponent signature (ReactComponent -> ReactElement) 2015-02-15 19:25:18 -08:00
Dustan Kasten dc21dca50e s/upate/update 2015-02-14 22:09:31 -05:00
Henry Zhu cb49492f88 lint whitespace
- use spaces
- remove space before paren in function
-  remove space before colon in object
2015-02-14 11:12:18 -05:00
Harry Marr 198aabaafb Prevent NaN props from triggering warnings
Previously, `checkAndWarnForMutatedProps` would flag `NaN` props as
having been mutated, because `NaN !== NaN`. This prevents that warning
from being emitted by explicitly checking for `NaN`s.
2015-02-14 10:06:55 +00:00
Henry Zhu 74726f0af5 remove space before round brace in function expressions 2015-02-13 23:41:53 -05:00
Henry Zhu e2a57920da lint whitespace , trailing comma 2015-02-13 23:13:47 -05:00