Ben Alpert
e47fa115bb
Merge pull request #3883 from spicyj/revert-nested
...
Revert "Add key warning to nested collections"
2015-05-18 23:11:29 -07:00
Ben Alpert
69e6ab5083
Add test for DOM node as this.props.children
2015-05-18 23:11:07 -07:00
Ben Alpert
39402fe75d
Revert "Add key warning to nested collections"
...
This heuristic isn't great because it relies on inspecting deep children which aren't guaranteed to be React elements. In particular, this was causing stack overflows in a component we had that used a *DOM node* as children, like `<DOMContainer>{node}</DOMContainer>`.
This reverts commits:
0a3aa8493a
64c9d9d762
0c58f4f6b1
8cf226e442
086636747f
2015-05-18 23:11:07 -07:00
Paul O’Shannessy
6502da8f8d
Merge pull request #3894 from bhamodi/patch-2
...
Update Styling Guide in Contributing Docs
2015-05-18 10:53:09 -07:00
Paul O’Shannessy
9308a8abe6
Merge pull request #3892 from spicyj/docs-wwb
...
[docs] Clarify wording in Working with the Browser
2015-05-18 10:47:37 -07:00
Baraa Hamodi
00342dfc26
Update Styling Guide in Contributing Docs
2015-05-17 23:38:40 -07:00
Ben Alpert
c7381ea48d
[docs] Clarify wording in Working with the Browser
...
I think the change in #3889 misinterpreted this slightly; this makes it clearer.
2015-05-17 11:58:17 -07:00
Paul O’Shannessy
490d8835fc
Merge pull request #3737 from Morhaus/nested-proptypes-warnings
...
Better warnings for nested propTypes
2015-05-16 12:09:29 -07:00
Paul O’Shannessy
095d4691ca
Merge pull request #3888 from marocchino/korean-update
...
Update Korean Translation to 5275244
2015-05-16 12:03:42 -07:00
Paul O’Shannessy
97d338fd5b
Merge pull request #3889 from garethnic/WorkBrowser
...
change wording in 'Working with the Browser'
2015-05-16 11:09:49 -07:00
Gareth Nicholson
07bfadf054
change wording
2015-05-16 15:55:29 +02:00
Shim Won
6f434b35ad
Update Korean Translation to 5275244
2015-05-16 21:49:04 +09:00
Sebastian Markbåge
5275244676
Merge pull request #3866 from sebmarkbage/coreapi
...
Reorganize Src Directory for Isomorphic React Package
2015-05-15 18:39:36 -07:00
Sebastian Markbage
0b063f8a09
Reorganize Src Files for Isomorphic React Package
...
The new folder structure is organized around major packages that are expected to ship separately in some form.
`/isomorphic`
I moved classic/modern and children utils into a directory called "isomorphic" with the main export being ReactIsomorphic. This will eventually become the "react" package.
This includes all the dependencies that you might need to create a component without dependencies on the renderer/reconciler.
The rest moves into decoupled renderers.
`/renderers/dom/client` - This is the main renderer for DOM.
`/renderers/dom/server` - This is the server-side renderer for HTML strings.
`/addons` and `/test` - Same as before for now.
You're not supposed to take on a dependency inside another package.
Shared code is organized into a "shared" directory which is intended to support all the packages in that subdirectory. Meaning that once we swap to CommonJS modules, the only time you should use `..` is to target `../shared/` or `../../shared`.
E.g. `/shared/` is common utils that are used by everything.
`/renderers/shared/` is code that is shared by all renderers, such as the main reconciliation algorithm.
Shared code will likely be copied into each package rather than referenced. This allow us to have separate state and allow inlining and deadcode elimination.
2015-05-15 18:35:22 -07:00
Paul O’Shannessy
bea5a57750
Merge pull request #3746 from chrisgrovers/patch-1
...
Fixed Formatting.
2015-05-15 18:09:44 -07:00
Paul O’Shannessy
c464e873fd
Merge pull request #3874 from bhamodi/patch-1
...
Update CONTRIBUTING.md
2015-05-15 18:08:00 -07:00
Paul O’Shannessy
3ef24f73bb
Merge pull request #3881 from ef718/docs-grammar
...
Fix punctuation and grammar
2015-05-15 17:57:36 -07:00
Paul O’Shannessy
cfa354415b
Followup to #3852 , use https
2015-05-15 17:51:57 -07:00
Ben Alpert
35e67a793e
Merge pull request #3882 from wali-s/get-html5-minlength-working
...
Get HTML5 minlength working.
2015-05-15 15:51:14 -07:00
wali-s
aeb45360ed
Get HTML5 minlength working.
...
Adding minLength=X to an input element would not work, whereas maxLength=X would work.
This change gets minLength=X working.
2015-05-15 15:47:15 -07:00
Ben Alpert
7112a35037
Merge pull request #3847 from bloodyowl/option-flatten-children
...
<option> added children flatten, & warn if invalid
2015-05-14 10:36:27 -07:00
Ben Alpert
69fc206f96
Merge pull request #3719 from spicyj/vdn2
...
Add more context to DOM nesting warning
2015-05-14 10:33:21 -07:00
Ben Alpert
5c7b4a043f
Merge pull request #3651 from spicyj/tac-noi
...
Don't thread index through traverseAllChildren
2015-05-14 10:32:49 -07:00
Elaine Fang
d24cfa6405
Add punctuation
2015-05-14 13:15:06 -04:00
Matthias Le Brun
4a012b0741
<option> added children flatten, & warn if invalid
2015-05-14 12:44:04 +02:00
Morhaus
12a43d4eee
Better warnings for nested propTypes
...
`arrayOf`, `shape` and `objectOf` warnings now display the full path of
the invalid key.
2015-05-14 11:33:07 +02:00
Baraa Hamodi
b276af5c0a
Update CONTRIBUTING.md
...
Make the contributing sentence make a little bit more sense.
2015-05-13 23:17:31 -07:00
Ben Alpert
05b98ac70c
Merge pull request #3872 from spicyj/nested-num
...
Split message for deep numeric key warning too
2015-05-13 15:32:13 -07:00
Paul O’Shannessy
db25a63c12
Merge pull request #3869 from zpao/jsx-cleanup
...
JSX -> Babel cleanup
2015-05-13 15:31:48 -07:00
Paul O’Shannessy
76d016c6f1
Use Babel to transform JS in docs, update other calls
2015-05-13 15:26:23 -07:00
Ben Alpert
0a3aa8493a
Split message for deep numeric key warning too
2015-05-13 15:23:29 -07:00
Ben Alpert
922d531445
Merge pull request #3871 from spicyj/group
...
Deprecate reactjs Google Group
2015-05-13 15:16:51 -07:00
Ben Alpert
ffabf4b5ff
Deprecate reactjs Google Group
2015-05-13 15:16:33 -07:00
Ben Alpert
51843ec710
Merge pull request #3870 from spicyj/gh-3865
...
Clarify ReactElement prop validation message
2015-05-13 15:14:00 -07:00
Ben Alpert
bed4de3eca
Clarify ReactElement prop validation message
...
Fixes #3865 .
2015-05-13 12:37:54 -07:00
Ben Alpert
67aea08b4f
Merge pull request #3861 from spicyj/nested-v
...
Split out warning message for nested key warning
2015-05-13 11:51:11 -07:00
Paul O’Shannessy
555d5dc35c
Merge pull request #3864 from cvrebert/patch-1
...
bower.json: remove moot `version` field
2015-05-13 11:12:10 -07:00
Paul O’Shannessy
9769f96974
[docs] Move pre-compiled JS files
2015-05-13 10:57:47 -07:00
Paul O’Shannessy
b258d34c73
Don't run non-existant fbtransform tests
2015-05-13 10:52:51 -07:00
Chris Rebert
73c84c8319
bower.json: remove moot version field
...
Per https://github.com/bower/bower.json-spec/commit/a325da3d79baab018c572d75dc1781b12322f6cd
2015-05-12 22:31:18 -07:00
Ben Alpert
64c9d9d762
Split out warning message for nested key warning
...
Also make sure to mark child array as validated in cloneElement as well.
2015-05-12 16:33:04 -07:00
Ben Alpert
f0bdadf85b
Merge pull request #3857 from spicyj/dev-rckv
...
Set _reactChildKeysValidated in dev mode only
2015-05-11 17:06:18 -07:00
Ben Alpert
0c58f4f6b1
Set _reactChildKeysValidated in dev mode only
2015-05-11 17:02:49 -07:00
Jim
6b19cf9ce3
Merge pull request #3856 from chaseadamsio/chaseadamsio-patch-1
...
Change object typo to objects
2015-05-11 13:56:58 -07:00
Chase Adams
a21b82d151
Change object typo to objects
2015-05-11 13:29:14 -07:00
Paul O’Shannessy
1549bae2ab
Merge pull request #3834 from chicoxyzzy/remove_jslint
...
remove jslint comments
2015-05-10 22:52:57 -07:00
Paul O’Shannessy
1748dc8131
Merge pull request #3837 from davidneat/transition-group-appear-high-level-docs
...
Added transitionAppear docs
2015-05-10 22:51:46 -07:00
Paul O’Shannessy
7839e07231
0.14.0-alpha1
2015-05-10 22:36:50 -07:00
Paul O’Shannessy
64014c4641
Fix esprima-fb dependency
2015-05-10 22:25:08 -07:00
Ben Alpert
0de20e35bc
Merge pull request #3852 from thewarpaint/patch-1
...
Add Wikipedia link to Cross-site scripting article on "XSS attack" string
2015-05-10 13:28:10 -07:00