Commit Graph
8428 Commits
Author SHA1 Message Date
Dominic Gannaway dd0ae1a233 moved shims to shims directory in rollup scripts 2017-03-23 16:21:36 +00:00
Dominic Gannaway 37d334b314 added extractErrors warning 2017-03-23 16:20:25 +00:00
Dominic Gannaway c81f2fbd7f added extract-errors support 2017-03-23 16:15:28 +00:00
Dominic Gannaway b4100edba2 fixed fixture path changes 2017-03-23 15:36:23 +00:00
Dominic Gannaway 02b70bc3c5 renamed bundles and paths 2017-03-23 15:02:44 +00:00
Dominic Gannaway e8a2318d0c added react-test-renderer bundles 2017-03-23 13:45:22 +00:00
Dominic Gannaway feda028b80 removed all react/lib/* dependencies from appearing in bundles created on build 2017-03-22 19:31:37 +00:00
Dominic Gannaway 373e15b4a7 fixed merge conflict 2017-03-22 19:14:19 +00:00
Dominic Gannaway 39a8b69230 updated internal modules (WIP) 2017-03-22 19:13:01 +00:00
Dominic Gannaway e8f49c4679 Improved UMD bundles, added better fixture testing and doc plus prod builds 2017-03-22 19:01:11 +00:00
Dan Abramov b0b9f37960 Fix up Flow syntax 2017-03-22 18:41:42 +00:00
Dan AbramovandGitHub 8de9c6c12c Add injection for error dialog (#9235) 2017-03-22 18:21:12 +00:00
Bernard LinandBrandon Dail fbc6977fbc Conferences (#9234)
* standard format for React Rally

* move React Conf 2017 to past conferences
2017-03-22 10:40:13 -05:00
Brian Vaughn 8ce5fe97b5 Bumped React version to 16.0.0-alpha.5 2017-03-21 13:04:08 -07:00
Dominic Gannaway 0e2f67168b added NPM package creation and copying into build chain 2017-03-21 18:57:51 +00:00
Dominic Gannaway 4a578dbc65 Fixed merge conflicts in ReactNative.js and ReactMethodsMixin.js 2017-03-21 14:10:04 +00:00
Dominic Gannaway 14324bc927 added NODE_DEV and NODE_PROD 2017-03-21 13:56:52 +00:00
Valentin SherginandBen Alpert 97ab3f5ef8 Removed optimization for events without target in ReactNativeEventEmitter (#9219)
* Removed optimization for events without target in ReactNativeEventEmitter

This PR fixes the problem originally introduced in https://github.com/facebook/react/pull/6590
The problem is that `ResponderEventPlugin` (and `ResponderTouchHistoryStore`) relies on that fact that touch events are balanced.
So if one `startish` event happened, should be coming `endish` event. Otherwise there is no way to maintain internal `trackedTouchCount` counter. So, if we drop some events, we break this logic.

Moreover, that optimization clearly contradict with this statement from `ResponderEventPlugin`:
```
We must be resilient to `targetInst` being `null` on `touchMove` or
`touchEnd`. On certain platforms, this means that a native scroll has
assumed control and the original touch targets are destroyed.
```

This issue causes several major problems in React Native, and one of them (finally!) is easy to reproduce: https://github.com/facebook/react-native/issues/12976 .

The test also illustrates this problem.

* Prettier
2017-03-20 17:07:28 -07:00
Brian VaughnandGitHub 7f665da0ee ReactNative upstream sync (#9197)
* Addresses a circular dependency between NativeMethodsMixin and ReactNativeFiber:

* Created new ReactNativeFiberHostComponent with similar interface but without unnecessary call to findNodeHandle.
* Created new Flow interface for mixins to ensure ReactNativeFiberHostComponent and NativeMethodsMixinUtils stay synced.
* Moved helper methods to NativeMethodsMixinUtils to be shared between the 2 wrappers.

This diff was submitted and reviewed internally along with some other ReactNative changes. This is the React-only portion.

* Removed unused Flow type import

* Copied a Flow fix from internal
2017-03-20 13:50:31 -07:00
Dan AbramovandGitHub e15a481773 Re-add tests unintentionally deleted in #9209 (#9225)
These tests are useful and don't test addons specifically.
I moved them to appropriate places in the codebase.
2017-03-20 19:38:54 +00:00
Dominic Gannaway 9255c6483d better handling of bundling ReactCurrentOwner and accessing it from renderer modules 2017-03-20 16:51:13 +00:00
Dan AbramovandGitHub 34e4352cba Delete addons (#9209)
* Delete addons

* Remove ReactFragment dependency from tests

* Remove addons testing from fixtures

* Don't mention createFragment() in a warning

* Address feedback

* Remove unused variables

* Remove mention of deleted file

* Add a missing key to the test

* Fix lint
2017-03-20 16:15:01 +00:00
Dominic Gannaway 6aa9936529 improved how bundles are built by exposing externals and making the process less "magical", also tidied up code and added more comments 2017-03-20 14:52:03 +00:00
CodinCatandDan Abramov 0ceb5115ac Use single quotes, remove extra whitespace (#9215) 2017-03-19 18:34:53 +00:00
Sasha AickinandDan Abramov 78761c387f Add unit tests for props to attribute mapping in SSR. (#9106)
* Added a handful of SSR unit tests, ported from a previous pull request.

* Fixing linting errors

* Fixed a test helper function to properly report errors.

* Un-nested the new rendering tests. Updated the fiber test passing/not passing lists.

* Edited to comply with the react/jsx-space-before-closing eslint rule, which will soon be merged into master.

* Response to code review from @spicyj. Moved tests to separate file, reworked wording of test names, corrected use of canUseDom, and simplified tests against tagName. Thanks for the help, @spicyj!

* Converted the unit tests to use async-await style.

* Moved async-await babel transform for tests from .babelrc to preprocessor.js.

* Response to code review in PR #9089. Thanks, @spicyj!

* Fixing some bugs in the SSR unit tests.

* Missed deleting some repeated code in the last commit.

* Adding unit tests for property to attribute mapping in SSR.

* Removing some redundant unit tests.

* Oops. I forgot to re-run record-tests after c593dbc; fixing that here.

* Reformatting for prettier so that the build will pass.
2017-03-19 16:08:55 +00:00
Dominic Gannaway d5b91d36a2 further improved and tidied up build process 2017-03-18 21:04:08 +00:00
Andrew ClarkandGitHub f606e0e7d3 Merge pull request #9145 from acdlite/explicitnullcheckfiberupdatequeue
Use explicit null checks in ReactFiberUpdateQueue
2017-03-17 10:44:11 -07:00
Brian VaughnandGitHub ad2b6545fe Upgraded Flow dev dependency to 41 for 'implements' support (#9196) 2017-03-16 17:12:50 -07:00
Sebastian MarkbågeandGitHub 096975afab Record fiber tests (#9195) 2017-03-16 16:29:05 -07:00
Sebastian MarkbågeandGitHub 9c7cf20dd5 Ignore event listener extraction on numeric text components (#9194)
In ReactDOM we don't dispatch events in the synthetic event system on to
text nodes. We back up one to the element before dispatching.

In React Native we don't do that. The iOS native side doesn't dispatch on
the text nodes but only the parent. The Android native side however does
dispatch on text nodes.

We already covered this for strings, but current element in Stack can be
a number if it is numeric text content.
2017-03-16 15:29:06 -07:00
Dan Abramov 8fa5d94cd3 Merge branch 'master' into rollup 2017-03-16 19:44:14 +00:00
Dan Abramov e4fcbecc1e Add a working RN build 2017-03-16 19:10:46 +00:00
Andrew ClarkandGitHub 9549ebfae5 Merge pull request #9187 from acdlite/prettierci
Failing to run prettier should block CI
2017-03-16 11:55:41 -07:00
Andrew Clark 8802c20c22 Run yarn prettier to format code
CI should now pass
2017-03-16 11:53:44 -07:00
Andrew Clark cbdddbeb58 (test) Commit changes without running prettier to see if CI fails 2017-03-16 11:53:44 -07:00
Andrew Clark 0e5be287f7 Exit with failing code if prettier throws to ensure CI is blocked 2017-03-16 11:53:44 -07:00
Andrew Clark c71a8ecd00 Add prettier instructions to PR template and contribution guide 2017-03-16 11:53:44 -07:00
Andrew Clark 7cf2950ebb Pass args as an array 2017-03-16 11:53:44 -07:00
Andrew Clark ecf2e44908 CI should fail if prettier wasn't run 2017-03-16 11:53:44 -07:00
Andrew Clark f365e52dd7 Add prettier script
`scripts/prettier/index.js write` will run prettier on source files.
Run using `yarn prettier`.

`scripts/prettier/index.js` will throw if any source files are not
formatted with prettier. We'll use this to block CI.

Based on similar script in Jest repo.
2017-03-16 11:53:44 -07:00
Jamison DanceandBrandon Dail 7253e6544b Add React Rally to conferences list (#9179) 2017-03-15 14:20:57 -10:00
Andrew Clark bc30ef9842 Work around loose typing for fiber.updateQueue
The updateQueue field is currently an any type. Check the fiber's tag so
that only UpdateQueues are passed to getPendingPriority.
2017-03-15 15:05:04 -07:00
Andrew Clark 21e0e3711b Use explicit null checks in ReactFiberUpdateQueue
Follow-up to #8978
2017-03-15 15:04:59 -07:00
Dominic Gannaway 04972cde8e tidied up the options for bundles, so they can define what types they output and exclude 2017-03-15 21:48:41 +00:00
Dan Abramov 7a2819042f Work in progress: start adding ReactNative bundle 2017-03-15 21:29:39 +00:00
Dan Abramov 2c9ea97f5e Merge branch 'master' into rollup 2017-03-15 20:09:13 +00:00
James LongandGitHub b1b4a2fb25 Merge pull request #9101 from sebmarkbage/prettier
Use Prettier
2017-03-14 15:33:27 -07:00
Sebastian Markbage 7e078d6a92 Fix lint rules
The typeof one is a bit strange because the disable rule gets moved.
2017-03-14 14:12:35 -07:00
Sebastian Markbage ba1299acc2 Non idempotent steps in prettier 2017-03-13 17:06:03 -07:00
Sebastian Markbage 1843f87168 Run prettier 2017-03-13 17:05:18 -07:00