Commit Graph
6387 Commits
Author SHA1 Message Date
Jim dcd092560d Merge pull request #6305 from maherbeg/maher-error-find-dom-node
Test to verify findDOMNode does not throw in willMount
2016-03-24 18:59:55 -07:00
Maher Beg 70de7e4a38 Test to verify findDOMNode does not throw in willMount
Adds a test to prevent a regression of throwing an error when
calling `findDOMNode(this)` in a component's `componentWillMount`
function. This previously used to throw an invariant violation but
now does not any more.
2016-03-24 18:06:27 -07:00
Paul O’Shannessy 9358ce3b02 Merge pull request #6332 from kentcdodds/pr/beginner-friendly
add beginner friendly resource for learning how to PR
2016-03-24 16:07:01 -07:00
Paul O’Shannessy 6a8ebfc418 Merge pull request #6331 from zpao/isonpmorphic
Make Browserify-specific modules to remove DOM dependencies from npm package
2016-03-24 16:01:51 -07:00
Paul O’Shannessy d17091ddeb Make Browserify-specific modules to remove DOM dependencies from npm package 2016-03-24 15:28:52 -07:00
Paul O’Shannessy ae2a7c723f Merge pull request #6333 from kentcdodds/pr/beginner-friendly-badge
add prs welcome badge
2016-03-24 14:58:15 -07:00
Kent C. Dodds 6b307a55fb add prs welcome badge 2016-03-24 14:18:32 -06:00
Kent C. Dodds f0dbc1e1d3 add beginner friendly resource for learning how to PR 2016-03-24 13:20:18 -06:00
Jim e119f20927 Merge pull request #6330 from speedskater/patch-1
Updated react conf links
2016-03-24 08:57:21 -07:00
Jim 414f057bc2 Merge pull request #6296 from jontewks/add-warnings
Add warnings for onFocusIn and onFocusOut props
2016-03-24 08:37:45 -07:00
speedskater c212226fff Updated react conf links
* Added React Conf 2016
* Fixed Links for React Conf 2015
2016-03-24 08:11:35 +01:00
Jim d8ee071c92 Merge pull request #6195 from mxstbr/perf-links
Add benchling engineering articles about perf to docs
2016-03-23 16:47:42 -07:00
Dan Abramov f80f2379cd Merge pull request #6326 from gaearon/fix-test
Fix ReactPerf.printOperations() test to work with createElement = false
2016-03-23 22:58:20 +00:00
Dan Abramov 0f1240e877 Fix ReactPerf.printOperations() test to work with createElement = false 2016-03-23 22:24:32 +00:00
Paul O’Shannessy 5e770f4d2d Merge pull request #6191 from strawbrary/edit-on-github-position
[docs] keep position of "Edit on GitHub" link fixed
2016-03-23 12:24:16 -07:00
Paul O’Shannessy bfb9444300 Merge pull request #6242 from edvinerikson/add-origin-to-css-warnings
added component name to css property warnings
2016-03-23 12:12:51 -07:00
Dan Abramov f5a9fb378d Add missing set -e to Travis builds
Fixes #6150, corrects a mistake made in d138b286db
2016-03-23 18:59:59 +00:00
Dan Abramov 1e8156143a Merge pull request #6310 from gaearon/setstate-warning
Add more specific error messages for bad callback in setState, replaceState, and ReactDOM.render
2016-03-23 14:50:36 +00:00
Jim 75c2b6ab59 Merge pull request #6257 from terry3/highlight-not-working
Highlight 'NOT' word in example page.
2016-03-22 22:54:48 -07:00
terry3 7169da21ba Highlight 'NOT' word in example page. 2016-03-23 09:19:58 +08:00
Jon Tewksbury a7fae7e4c7 Add warnings for onFocusIn and onFocusOut props 2016-03-21 17:22:37 -07:00
Jim c528732504 Merge pull request #6307 from cbrwizard/getEventCharCode_unit_tests
getEventCharCode unit tests
2016-03-21 16:17:06 -07:00
Dan Abramov af4fe68b14 Change message format to be more consistent with other errors 2016-03-21 23:13:47 +00:00
Dan Abramov d4657b8331 Add bad callback invariants to ReactDOM.render() calls 2016-03-21 22:33:15 +00:00
Paul O’Shannessy d433c2f376 Merge pull request #6313 from jimfb/script-integrity-attribute
Removed script security attributes, since fb.me isn't setting the proper headers.
2016-03-21 15:19:16 -07:00
Jim 8b026f901c Removed script security attributes, since fb.me isn't setting the proper headers. 2016-03-21 15:06:08 -07:00
Paul O’Shannessy 39ccdccef1 Merge pull request #6312 from vjeux/fix_docs_jump
[website] Fix jump on the header
2016-03-21 14:44:57 -07:00
Dan Abramov ebe5128489 Use specific method names in error messages 2016-03-21 21:40:17 +00:00
Dan Abramov 552f00b536 Make setState() callback error message more descriptive
Fixes #6306
2016-03-21 21:24:19 +00:00
Christopher Chedeau fe617082d9 [website] Fix jump on the header
Algolia adds two inline styles

```css
  position: relative;
  vertical-align: top;
```

to the element once the script inserted at the end of the page runs which super slightly moves the header. The fix is to always apply those two rules this way it doesn't jump. I did not notice it on my machine because it doesn't move when custom fonts are not being used.

Test Plan:
- Open two tabs: reactjs.com and localhost:4000/react
- Click around on reactjs.com to prime the cache with the fonts
- Switch tabs and click around on localhost (but do not force refresh!)
- Now you get custom fonts loaded locally and it doesn't jump when you change tabs
2016-03-21 14:12:20 -07:00
Paul O’Shannessy 40c4635e17 Merge pull request #6303 from qerub/use-loose-envify
Use loose-envify instead of envify
2016-03-21 12:24:46 -07:00
Christoffer Sawicki ecf824cc2a Use loose-envify instead of envify
This reduces the number of transitive dependencies and decreases the build time (by ~6% on my machine).
2016-03-21 20:18:17 +01:00
Paul O’Shannessy 75e4ef167e Merge pull request #6309 from victor-homyakov/patch-1
Free memory allocated by testElement after usage
2016-03-21 12:16:16 -07:00
Victor Homyakov 0393488f39 Free memory allocated by testElement after usage
IE11 reports `testElement` as detached DOM node consuming memory. It is captured in closure of `setInnerHTML` function and could be safely cleared after feature test.
2016-03-21 14:07:26 +03:00
cbrwizard 7bdf4dba75 getEventCharCode unit tests
Adds unit tests to getEventCharCode.
2016-03-21 12:56:45 +03:00
Dan Abramov 441d9b65bd Merge pull request #6301 from gaearon/remove-dead-export
Remove unused export from DOMChildrenOperations
2016-03-20 00:41:29 +00:00
Dan Abramov cfec10bd51 Remove unused export from DOMChildrenOperations 2016-03-19 21:05:05 +00:00
Jim 2f24f89111 Merge pull request #6281 from rgarifullin/microfix_docs
Microfix docs
2016-03-19 11:24:27 -07:00
Dan Abramov 67f8524e88 Merge pull request #6289 from gaearon/strip-circular-refs
Strip complex values from ReactPerf.printDOM() output
2016-03-18 22:24:18 +00:00
Dan Abramov d138b286db Try disabling coverage on master to prevent Travis crashes
We suspect that memory overhead caused by coverage might be the reason Travis fails on master. No guarantees it will work but worth a try.
2016-03-18 00:14:25 +00:00
Dan Abramov b6547734c6 Strip complex values from ReactPerf.printDOM() output
Fixes #6288
2016-03-17 21:23:43 +00:00
Dan Abramov 5520c399a6 Merge pull request #6287 from gaearon/rename-perf-methods
Rename ReactPerf methods to match the upcoming ReactPerf revamp
2016-03-17 20:47:02 +00:00
Dan Abramov ea55d66760 Rename ReactPerf methods to match the upcoming ReactPerf revamp 2016-03-17 20:18:42 +00:00
rgarifullin 8e6996267f Add missing semicolon in test-utils part of docs 2016-03-17 22:51:11 +03:00
Dan Abramov 8046cbda10 Merge pull request #6285 from gaearon/no-addons
Remove react/addons
2016-03-17 19:26:03 +00:00
Dan Abramov b322d65320 Fix the ReactDefaultPerf test to match changes in #6286 2016-03-17 19:23:21 +00:00
Dan Abramov 67647fd82f Merge pull request #6286 from gaearon/opaque-perf-measurements
Make ReactPerf.getLastMeasurements() opaque
2016-03-17 19:12:07 +00:00
Dan Abramov 51d37c64c3 Make ReactPerf measurements opaque
We intend to change the measurement format significantly in #6046. In order to introduce the new ReactPerf during 15.x release cycle, we are making the measurement structure opaque-ish in 15.0.
2016-03-17 18:48:55 +00:00
Dan Abramov a7ed9fd199 Remove react/addons 2016-03-17 18:18:04 +00:00
Jim 663a78399c Merge pull request #6273 from cbrwizard/getEventKey_tests
getEventKey unit tests
2016-03-17 10:38:16 -07:00