Commit Graph
4654 Commits
Author SHA1 Message Date
oluckyman db40beafbe Show warning when componentDidUnmount is defined
Fixes #4194
2015-06-22 21:09:33 +02:00
Ben Alpert df05c6efb8 Fix typo in blog post
(#4183)
2015-06-20 16:49:33 -07:00
Ben Alpert 64b5f043dd Merge pull request #4170 from johanneslumpe/patch-1
Guard against a null node
2015-06-20 16:42:23 -07:00
Jim ede27d2e86 Merge pull request #4172 from jimfb/freeze-props
Freeze ReactElement.props in dev mode
2015-06-19 14:13:17 -07:00
Johannes Lumpe b16f9d42b1 Guard against a null node
This could fix #2619
2015-06-19 11:21:22 +03:00
Sebastian Markbåge 59dfe87d04 Merge pull request #4171 from sebmarkbage/simplifylifecycle
Simplified Life Cycles
2015-06-18 23:16:27 -07:00
Sebastian Markbage c1330dcfcd Unit tests for unmounted setState and isMounted 2015-06-18 22:55:52 -07:00
Jim 95373ce769 Freeze ReactElement.props in dev mode 2015-06-18 14:49:06 -07:00
Sebastian Markbage 8659223939 Lint fixes 2015-06-18 14:12:21 -07:00
Sebastian Markbage dddebd1344 Use hack to support isMounted without stateful module
This hack allow us to get rid of the stateful module ReactLifeCycle since
we can infer the value of isMounted even without it. This gets rid of
the try/catch which is deopting all mountComponent calls.

As a next step we could deprecate isMounted completely and avoid stateful
APIs. Since it can be easily simulated if you truly need it.
2015-06-18 14:10:12 -07:00
Sebastian Markbage 140af9b985 Allow callbacks to be enqueued during componentWillMount
Since I fixed the server-side rendering it is now possible to trigger these
callbacks on the client alone. They will still be queued up on the server
but they are never executed.
2015-06-18 13:35:39 -07:00
Sebastian Markbage e737acb472 Let updates be enqueued during render
This allows updates to be enqueued during render. setState in
componentWillMount will still be collected as part of the first pass so
if nothing else get added as pending, they won't trigger a second rerender.

This allow us to get rid of one more stateful special case.
2015-06-18 13:35:39 -07:00
Sebastian Markbage 40b7c19a89 Use a custom batching strategy for server rendering
This simply ignores any enqueued actions. This means that we don't have to have special logic for componentWillMount. It is just that those updates are never enqueued.
2015-06-18 13:34:30 -07:00
Sebastian Markbage 3af73834d9 Remove currentlyUnmountingComponent
This was used for any invariant that was subsequently removed. It turns
out that this is completely unnecessary now. Any setState calls will
enqueue and update and the component added to the update queue. However,
since the pending fields are reset after componentWillUnmount, any update
will still be ignored.
2015-06-18 12:36:50 -07:00
Sebastian Markbage 7443f63ae9 Remove an unnecessary warning
It was impossible to get here because if you enqueue something

Also ensure that they're only used in DEV because we will be reading
state that is DEV only here.
2015-06-18 12:36:45 -07:00
Sebastian Markbage c4cafcecd9 Move current owner to isomorphic
This should only be used for tracking string refs. For that purpose, we
need a single central stateful module that is coupled to createElement.
Which is why it needs to live in isomorphic.

Eventually this will go away completely.
2015-06-18 09:05:35 -07:00
Ben Alpert 016021207c Merge pull request #4154 from spicyj/gh-3478
Improve error message when mounting non-string/function elements
2015-06-17 16:26:02 -07:00
Paul O’Shannessy a841b4f5fb Merge pull request #2981 from hzoo/jsdoc-fixes 2015-06-17 16:06:37 -07:00
Paul O’Shannessy 531e6280a3 Merge pull request #4158 from zpao/mv-packages
Move npm packages into folder
2015-06-17 12:18:37 -07:00
Ben Alpert 642323e5a8 Improve error message when mounting non-string/function elements 2015-06-17 12:04:05 -07:00
Paul O’Shannessy 12c9fee94e Move npm packages into folder 2015-06-17 12:01:44 -07:00
Paul O’Shannessy ec791582f4 Merge pull request #4156 from tako-black/fix_link
Fix link of getting-started.ja-JP.md
2015-06-17 11:53:21 -07:00
Paul O’Shannessy 10ada3b5f5 Merge pull request #4157 from zpao/svg-image
Support SVG image, other related cleanup
2015-06-17 11:44:29 -07:00
Paul O’Shannessy ace49f304b Merge pull request #4100 from zpao/deprecate-react-calls
Deprecate non-isomorphic react methods in npm module
2015-06-17 11:15:46 -07:00
Paul O’Shannessy bdbbe40b1e Merge pull request #4140 from zpao/mv-errorutils
Move ReactErrorUtils out of vendor
2015-06-17 10:51:02 -07:00
Paul O’Shannessy efdd75685d Support SVG image 2015-06-17 10:47:53 -07:00
Paul O’Shannessy 572a1d895c Update getMarkupWrap with list of SVG supported in ReactDOM 2015-06-17 10:40:11 -07:00
Paul O’Shannessy 265fdc3eed Rewrite SVG initialization in getMarkupWrap 2015-06-17 10:37:13 -07:00
Kohei TAKATA 3c53d25587 Fix link of getting-started.ja-JP.md 2015-06-17 22:17:47 +09:00
Ben Alpert c265504fe2 Merge pull request #4152 from spicyj/rce
Disallow passing a DOM component to reactComponentExpect
2015-06-16 23:33:09 -07:00
Ben Alpert 306c2dd5a9 Merge pull request #4151 from spicyj/fairti
Disallow passing a DOM component to findAllInRenderedTree
2015-06-16 23:32:53 -07:00
Ben Alpert cf6b3ff0e2 Disallow passing a DOM component to reactComponentExpect
We won't be able to support this after DOM-components-as-refs but we don't expect many people to be passing DOM components to this function anyway, and it should be fairly straightforward for people to clean up failing unit tests using this function.

(This module also isn't public API and never has been.)
2015-06-16 17:51:06 -07:00
Ben Alpert 4070c4ca20 Disallow passing a DOM component to findAllInRenderedTree
We won't be able to support this after DOM-components-as-refs but we don't expect many people to be passing DOM components to this function anyway, and it should be fairly straightforward for people to clean up failing unit tests using this function.
2015-06-16 16:37:37 -07:00
Ben Alpert c9b0c26966 Invert logic in findAllInRenderedTreeInternal
With DOM components we won't be able to go from public instance to internal instance reliably, so do the traversal on internal instances.
2015-06-16 14:38:03 -07:00
Paul O’Shannessy e571b32061 Wrap calls to deprecated functions with a warning. 2015-06-16 13:23:40 -07:00
Paul O’Shannessy f306ed65b3 Merge pull request #4121 from cristovaov/tutorial-doc/script-src
update script sources to be even with the example file ...
2015-06-16 12:37:20 -07:00
Paul O’Shannessy 6248abb6ee Merge pull request #4142 from zpao/lint-changed
npm script to run lint only on changed files
2015-06-16 11:41:28 -07:00
Paul O’Shannessy ddac9473ca npm script to run lint only on changed files 2015-06-16 11:24:02 -07:00
Ben Alpert efcf2e318e Merge pull request #4145 from RReverser/patch-1
Update 2015-06-12-deprecating-jstransform-and-react-tools.md
2015-06-16 10:57:50 -07:00
Sebastian Markbåge 2d29691019 Merge pull request #4105 from sebmarkbage/moveismounted
Move isMounted logic into the ReactUpdateQueue
2015-06-16 10:36:04 -07:00
Ingvar Stepanyan cab21c7783 Update 2015-06-12-deprecating-jstransform-and-react-tools.md
Add paragraph about parsing JSX after deprecation of esprima-fb.
2015-06-16 16:18:18 +03:00
Paul O’Shannessy 93be1939b5 Move ReactErrorUtils out of vendor
Some other small changes now that it's linted.
2015-06-16 01:16:17 -07:00
Ben Alpert 78da37da50 Merge pull request #4137 from spicyj/setpropsinternal
Remove _setPropsInternal
2015-06-15 23:33:14 -07:00
Ben Alpert ee367a8a02 Remove _setPropsInternal
Nothing uses this.
2015-06-15 23:28:27 -07:00
Ben Alpert d67f23fb0e Merge pull request #4115 from spicyj/dom-hash
Reduce hash lookups for DOM properties
2015-06-15 14:15:55 -07:00
Paul O’Shannessy a2862f3c2f Merge pull request #4097 from zpao/react-dom-package
Build react-dom package
2015-06-15 12:04:44 -07:00
Paul O’Shannessy 3bae8f5f35 Build react-dom package 2015-06-15 11:01:39 -07:00
Paul O’Shannessy 193773e349 Merge pull request #4103 from marocchino/ko-update
Update Korean transltaion to 4c778e2
2015-06-15 10:56:40 -07:00
Paul O’Shannessy f8ffb0f8b3 Merge pull request #4132 from tako-black/translate_why-react_to_japanese
Translate 01-why-react.md to Japanese
2015-06-15 10:51:32 -07:00
Kohei TAKATA 1d3906f91d Translate 01-why-react.md to Japanese 2015-06-15 21:30:12 +09:00