Commit Graph

3071 Commits

Author SHA1 Message Date
Lee Byron d4ac1229a6 Merge pull request #2458 from leebyron/fix-iterable
[traverseAllChildren] fix out-of-scope var use.
2014-11-03 21:25:01 -05:00
Lee Byron a3608d27ab [traverseAllChildren] fix out-of-scope var use.
Dear ES6 gods, bring us `let` soon.

This fixes an issue where non-keyed iterables are used as children and the value of `i` would be undefined because its used out of scope. This adds a separately scoped iteration index value and appropriately increments it as iteration continues. Doi.

While I'm in there, make the usage of falsey `nameSoFar` more obvious and more consistent with the existing usage on L115

Test plan: first wrote a test covering this previously untested path. Saw an identical issue as was experienced in development environment. Then ensured test passed after this diff.
2014-11-03 21:19:28 -05:00
Sebastian Markbåge cb50a8698b Remove unrelated comment
This is no longer unwrapping a legacy factory (which are gone).
2014-10-31 12:39:38 -07:00
Paul O’Shannessy 1666661a06 Merge pull request #2433 from zpao/fiddle-integration
Bring in jsfiddle integration script, add harmony
2014-10-31 11:22:57 -07:00
Paul O’Shannessy 1abe716358 Merge pull request #2443 from kruppel/kurt/minor-tip-typo
Fix typo in If/Else JSX doc.
2014-10-31 10:11:32 -07:00
Kurt Ruppel 4b3b32e418 Fix typo in If/Else JSX doc. 2014-10-31 09:52:44 -07:00
Sebastian Markbåge 881c9b5be8 Merge pull request #2435 from sebmarkbage/fixretest
Use dump cache and remove factory from ReactElement-test
2014-10-30 12:06:21 -07:00
Paul O’Shannessy d8ed3e5cf9 Merge pull request #2437 from zpao/lint-cleanup
Cleanup a couple unused variables
2014-10-30 12:05:38 -07:00
Paul O’Shannessy 295c1e3652 Cleanup a couple unused variables 2014-10-30 11:38:53 -07:00
Paul O’Shannessy bf99ab1c89 Merge pull request #2434 from Shraymonks/propTypes-docs
Update deprecated propTypes
2014-10-30 09:43:02 -07:00
Sebastian Markbage 7f7b7f386a Use dump cache and remove factory from ReactElement-test
We need to use dump cache because we don't enable it by default internally.

While I'm at it, I might as well kill the ComponentFactory variable which
is now just an alias.
2014-10-30 02:50:28 -07:00
Raymond Ha 92d171a4fc Update deprecated propTypes 2014-10-29 21:00:32 -07:00
Paul O’Shannessy 0f5368341f Bring in jsfiddle integration script, add harmony 2014-10-29 19:35:27 -07:00
Paul O’Shannessy 7071d1c316 Merge pull request #2419 from johnheroy/patch-1
Add comma for readability in tutorial.md
2014-10-29 18:03:48 -07:00
Paul O’Shannessy eb7f806566 Merge pull request #2431 from wassil/master
Extending period in which click events are ignored
2014-10-29 18:02:44 -07:00
Juraj Dudak c563e19739 Extending period in which click events are ignored 2014-10-29 14:06:37 -07:00
Paul O’Shannessy b2b8e5c08a Merge pull request #2428 from cody/fixes
React.renderComponent --> React.render
2014-10-29 11:44:35 -07:00
Stefan Dombrowski 93ac4d09a1 React.renderComponent --> React.render
Also fixed a spelling mistake.
2014-10-29 19:05:16 +01:00
Paul O’Shannessy ce1b394529 Followup fix for React.PropTypes.node
This should have gone in as a part of #2343
2014-10-28 22:49:25 -07:00
Sebastian Markbåge a54ed49eb0 Merge pull request #2375 from sebmarkbage/droplegacyfactories
Drop Legacy Factories
2014-10-28 18:00:32 -07:00
John Heroy 129d66a62e Add comma for readability in tutorial 2014-10-28 15:22:40 -07:00
Sebastian Markbage 9b36b04d75 Drop internal uses of .type on the class 2014-10-28 15:08:52 -07:00
Sebastian Markbage 199a7d6903 Drop Legacy Factories Around Classes
Classes are now pure classes without a legacy factory around them.

Since classes will become just any function that returns a valid instance,
let's drop isValidClass.

There's some hacks in here for auto-mocking frameworks (jest) that mock the
prototype of these classes. These hacks allow these classes to be mounted.
2014-10-28 15:08:52 -07:00
Sebastian Markbage 531c2bc4c9 Drop ReactDOM from internal DOM extensions
These used to be exposed as strings on the legacy factories but are now
gone.
2014-10-28 15:08:52 -07:00
Paul O’Shannessy 581085ea1b Merge pull request #2416 from zachasme/update-jstransform
Update jstransform version to 7.0
2014-10-28 15:01:57 -07:00
Paul O’Shannessy 22ffb57a93 Merge pull request #2415 from zpao/sync-internal
Sync internal
2014-10-28 14:30:06 -07:00
Cheng Lou 86336997cd Merge pull request #2418 from spencer48/patch-1
(docs) Added commas to increase readability.
2014-10-28 17:26:18 -04:00
Spencer Handley a55a3f77a1 Added comma to increase readability.
When thumbing through the docs, I noticed a few missing commas. I inserted two commas and did not alter any source code.
2014-10-28 13:56:14 -07:00
Paul O’Shannessy 17b190bee2 Add 0.12 starter kit 2014-10-28 11:48:53 -07:00
Christopher Chedeau 26c8a70c1d Change the date and the link url to match the proper roundup 2014-10-28 11:36:12 -07:00
Paul O’Shannessy 9e895bc360 Correct changes from 0.12-stable merge 2014-10-28 11:20:33 -07:00
Paul O’Shannessy 8b041eaa5a Merge branch '0.12-stable' 2014-10-28 11:18:02 -07:00
Paul O’Shannessy f2947a0ca1 Merge pull request #2399 from zpao/0.12-docs
Docs updates for 0.12
2014-10-28 11:17:25 -07:00
Paul O’Shannessy fa2597a3b3 0.12 blog post 2014-10-28 11:16:29 -07:00
Paul O’Shannessy 8ef1f96850 0.12 CHANGELOG 2014-10-28 11:16:28 -07:00
Paul O’Shannessy 3eb8222c22 Update cdnjs link, include jsdelivr in readme 2014-10-28 11:06:32 -07:00
Paul O’Shannessy fcd4be3933 Update version references in the readme 2014-10-28 11:06:32 -07:00
Paul O’Shannessy 0b8454724e Update Authors & Acknowledgements for 0.12 2014-10-28 11:06:32 -07:00
Christopher Chedeau 081115609c React.js Conf blog post
Closes #2412
2014-10-28 11:06:31 -07:00
Cheng Lou 539db8e9c8 Merge pull request #2414 from benleiken/patch-1
Moved key requirement note into 'getting started'
2014-10-28 11:06:31 -07:00
Paul O’Shannessy 4d47ff36b2 Merge pull request #2413 from LeonFedotov/patch-1
Changing api documentation for jsx transformer
2014-10-28 11:06:31 -07:00
Sebastian Markbage 98bf80254f Update Docs Navigation 2014-10-28 11:06:31 -07:00
Sebastian Markbage 1cb3f25e78 More Descriptor -> Element renames 2014-10-28 11:06:31 -07:00
Sebastian Markbage b7a548c4bf Replace transferPropsTo with transferring props patterns 2014-10-28 11:06:30 -07:00
Sebastian Markbage 9b1ee4de46 Updated Docs for new JSX Changes
Moved non-JSX explanation to Displaying Data.
Overhauled JSX in Depth.
Added JSX Spread Section.
2014-10-28 11:06:30 -07:00
Paul O’Shannessy 0dd942b121 Update Animation docs for createElement 2014-10-28 11:06:30 -07:00
Paul O’Shannessy eb2827ec6a Update React.DOM -> React.createElement through docs 2014-10-28 11:06:30 -07:00
Paul O’Shannessy 0344aaf18d Use --harmomy in docs examples for cleaner code 2014-10-28 11:06:30 -07:00
Zacharias c260c45db3 Update jstransform version to ^7.0.0 2014-10-28 13:48:48 +01:00
Tienchai Wirojsaksaree ff12423d63 Fixing touch/mouse issues with TapEventPlugin
On ios device, browser simulates mouse events, but does that with
a delay, because of double tap gesture. The problem is that
TapEventPlugins listens to both types of events, so it fires twice

Everytime there is a touch event, we should ignore mouse events that
follow it.  This way, we still respond to both mouse and touch events,
just ignore the device generated ones.
2014-10-27 17:02:03 -07:00