Commit Graph
7153 Commits
Author SHA1 Message Date
Ben Alpert d2039d7fac Improve error messages for invalid element types (#8612)
(cherry picked from commit eca5b1d48e)
2017-01-06 17:04:29 +00:00
dfrownfelter d93cedad7f Delete fiveArgumentPooler (#8597)
(cherry picked from commit b106ca0c8e)
2017-01-06 16:59:06 +00:00
Brian Vaughn b2ce4125f6 Merge pull request #8594 from bvaughn/dont-warn-about-getInitialState-on-class-if-state-set
Don't warn about class components using getInitialState if state is set
(cherry picked from commit 3c6d4bacdd)
2017-01-06 16:58:50 +00:00
Kurt Weiberth 3ec576ec1d add dependencies to react-test-renderer and react-addons (#8467)
**What** and **Why**:

* When using npm version 2, `object-assign` and `fbjs` were not getting properly installed
* This PR adds `object-assign` and `fbjs` as explicit dependencies to both `react-test-renderer` and `react-addons`
(cherry picked from commit 7cd26024ce)
2017-01-06 16:58:22 +00:00
Ben Alpert 5216190247 Update release checklist (#8389)
(cherry picked from commit a98e8227b8)
2017-01-06 16:58:22 +00:00
Eoin Hennessy c9a8c128bb Refactor precacheChildNodes slightly (#8018)
This ‘fixes’ a bizarre IE9 script engine issue. #7803
(cherry picked from commit 6ce8f1f93c)
2017-01-06 16:58:22 +00:00
Brandon Dail 4dd625a93f Correctly render placeholder for textarea in IE11 (#8020)
* Check if textContent should be set for textarea

shouldSetNodeTextContent returns whether a node.textContent should be
updated. Currently it only covers one case, which is to avoid setting
the textContent if the text is empty and a placeholder exists.

* Only set node.value if it's equal to initialValue

In IE11 textContent is populated when the placeholder attribute is set.
Without this check, we end up setting node.value equal to the
placeholder text, causing the textarea to actually render with the text
inside.

This check makes sure that textContent is equal to our expected
initialValue, which should be the case when using defaultValue.

* Remove placeholder/textarea check, use contentToUse instead

(cherry picked from commit e644faa610)
2017-01-06 16:58:22 +00:00
Diego Muracciole 278409db05 Injected Host Component classes are not being considered by the reconciler (#8050)
* Consider Host Component classes when creating a new internal instance

* Remove unused tagToComponentClass & injectComponentClasses from ReactHostComponent

(cherry picked from commit 461a74115c)
2017-01-06 16:58:21 +00:00
Nathan Hunzaker ed760d1567 Fix uncontrolled input decimal point "chopping" on number inputs, and validation warnings on email inputs (#7750)
* Only assign defaultValue if it has changed.

* Improve comment about reason for defaultValue conditional assignment

(cherry picked from commit 0d20dcf910)
2017-01-06 16:58:21 +00:00
Ben Alpert 2cabb02098 docs update for v15.4.1 2016-11-22 17:56:04 -08:00
Ben Alpert 2075139ce5 15.4.1 v15.4.1 2016-11-22 17:47:12 -08:00
Ben Alpert 20b4399d5d 15.4.1 changelog 2016-11-22 17:47:11 -08:00
Ben Alpert bf16d23d81 shrinkwrap 2016-11-22 17:34:20 -08:00
Ben Alpert 027d8808b7 Stopgap fix for element disabling (#8387)
Fix for #8308. This is a bad hack -- EventPluginHub.getListener isn't even DOM-specific -- but this works for now and lets us release 15.4.1.
(cherry picked from commit c7129ce1f0)
2016-11-22 17:34:20 -08:00
Paul O’Shannessy 24ffd57dfa Fix browser bundle for AMD (#8374)
* Fix browser bundle for AMD

* Final fix for standalone browser build.

Much more scientific than the rest so it should stick.

* Throw when we can't find code we need to replace.

(cherry picked from commit a3ba48bf72)
2016-11-22 17:24:29 -08:00
Dan Abramov 9941c48914 Restructure code to work around a Rollup bug (#8384) 2016-11-22 17:16:13 -08:00
Paul O’Shannessy 76e67908ce Merge remote-tracking branch 'upstream/15-stable' into 15-dev 2016-11-22 11:14:05 -08:00
Mikhail Osher 91676a619a Fix object spread operator (#8378)
Object spread operator performs shallow copy of object's arguments, so it should be placed before new properties are assigned.
2016-11-22 15:54:22 +00:00
Simen Bekkhus 65f9d2ae9e Fix link to PureComponent in docs (#8375) 2016-11-22 15:54:11 +00:00
Michael Sinov 33070fb881 update react-without-es6.md (#8351) 2016-11-19 18:19:50 +00:00
Dan Abramov 3c8b63ea6c Merge pull request #8346 from shubheksha/docs/improve-state-and-lifecycle
Improved sections of state and lifecycle docs
2016-11-19 18:07:42 +00:00
Dan Abramov 01a445a418 Merge pull request #8345 from shubheksha/docs/improve-introducing-jsx
Improved some sections of the introducing JSX docs
2016-11-19 18:07:22 +00:00
Dan Abramov a74116c82c Merge pull request #8339 from nolanlawson/patch-1
Update 2016-11-16-react-v15.4.0.md
2016-11-18 13:01:27 +00:00
Dan Abramov f8ef2e4efe Merge pull request #8335 from lacker/newlink
add link to useful doc
2016-11-18 13:01:15 +00:00
Dan Abramov a884bca7a1 Merge pull request #8332 from gaearon/prod-dev
[Docs] Expand Installation and clarify why use bundlers
2016-11-18 13:00:59 +00:00
Dan Abramov a484f30bc5 Tweak examples 2016-11-17 14:45:51 +00:00
Marcy Sutton e0cf1e0ae7 fix(a11y): add missing labels to forms doc
Showing how to create a form without labeling inputs is an accessibility anti-pattern. This change adds labels to the examples to address that. Codepen may still need to be updated depending on how that example is created.
2016-11-17 14:45:44 +00:00
Kevin Lacker eb1077bc4c include the version number in the header (#8315) 2016-11-17 14:35:35 +00:00
Tanner d7db851253 Remove spread operator (#8273)
* Remove spread operator

I believe what was meant here was to express that you would create the new player object with all the previous properties of the existing player object in addition to now updating the score value. That being said, this is a simple example, and the player object clearly has no other values. Objects are not (by default) iterable using this operator, so this little piece does more harm than good. I believe the new example to be much clearer.

* Using Object.assign()

* Tweak wording
2016-11-17 14:35:21 +00:00
Dave Voyles d220385c53 Clarity on constructor of Board object for tutorial.md (#8224)
* Update tutorial.md

Is it possible to be more clear here?
 This implies that we are removing the constructor from GAME, and not board (which is what I believe the author is trying to say).
It took me several reads to understand. 

With this edit, it is now clear that the adjustment is being made to -Board- and not to -Game-

* also remove "for Board earlier"
2016-11-17 14:35:04 +00:00
Brandon Dail 04447d302c Merge pull request #8277 from qiuyuntao/master
docs: delete unnecessary brackets
(cherry picked from commit 024f62ecfe)
2016-11-16 15:22:39 +00:00
Brandon Dail 14089c9360 Update reference-react-dom.md (#8285)
Add missing closing bracket
(cherry picked from commit cdcbf2f39b)
2016-11-16 15:22:39 +00:00
Samuel Scheiderich 83efef15f3 Add freenode #reactjs link to support.md (#8270)
* Add freenode #reactjs link to support.md

* Changed irc link to http webchat link.

(cherry picked from commit 9d201918bf)
2016-11-16 15:22:39 +00:00
Michele Bertoli 881254182e Make the Shallow Rendering example clearer (#8269)
* Make the Shallow Rendering example clearer

I was reading through the documentation, and I found that the `render` call on the `renderer` was missing.

* Use a regular function to define MyComponent

(cherry picked from commit 53e45e78e4)
2016-11-16 15:22:39 +00:00
Shuhei Kagawa 04f1fe7fbf Correct a method param in Implementation Notes (#8252)
(cherry picked from commit fa4710fe51)
2016-11-16 15:22:39 +00:00
Arni Fannar 5f55b8aaf7 Update refs-and-the-dom.md (#8250)
Since a lot of projects use [airbnb eslint config](https://www.npmjs.com/package/eslint-config-airbnb) where [this rule](http://eslint.org/docs/rules/no-return-assign) is enabled (and its a good rule) some people might get confused when they are trying this out in their project.
(cherry picked from commit f4059e5e5b)
2016-11-16 15:22:39 +00:00
Guilherme Oenning e5e387da9e fix broken docs links (#8163)
* fix broken links to outdated code

* another broken links to outdated code

* update hash commit & folder structure to current

(cherry picked from commit b847226ec4)
2016-11-16 15:22:38 +00:00
Ville Immonen bda773c963 Remove string ref from function component example (#8244)
Refs can't be attached to stateless functional components.
(cherry picked from commit 3668a2e678)
2016-11-16 15:22:38 +00:00
Nate 2f7e6c3a5d Fix typos in Shallow Rendering Documentation (#8226)
* Fix typos in Shallow Rendering Documentation

* Fix another occurrence

(cherry picked from commit 2317fcaccb)
2016-11-16 15:22:38 +00:00
Satoshi Nakajima b434310383 Replaced old refs with new callback refs (#8254)
(cherry picked from commit 3e708497d2)
2016-11-16 15:22:25 +00:00
Dan Abramov 550db27a1c Add 15.4.0 blog post 2016-11-16 14:49:14 +00:00
tomocchino 5ce8853ccb Update website for 15.4.0 2016-11-16 14:29:35 +00:00
tomocchino 1c1f68e8dc 15.4.0 v15.4.0 2016-11-16 14:16:57 +00:00
tomocchino 443683525f Update Changelog & Readme for 15.4.0 2016-11-16 14:13:26 +00:00
tomocchino 88296d994d Merge branch '15-dev' into 15-stable 2016-11-16 14:08:52 +00:00
tomocchino eee3bce748 Update error codes 2016-11-16 13:46:20 +00:00
tomocchino 6466714e4c Update dependencies / shrinkwrap 2016-11-16 13:43:33 +00:00
Brandon Dail 7df71a2525 Use _hostContainerInfo to track test renderer options (#8261)
* Use _hostContainerInfo to track test renderer options

The transaction is not available when unmounting or updating the
instance, so we track it using _hostContainerInfo

* Throw if hostContainerInfo is not populated in getPublicInstance

* Linting fixes

* Remove transaction from ref lifecycle code path

We don't need to pass the transaction around anymore since we store the
test options on _hostContainerInfo instead

* Remove unused argument

(cherry picked from commit e43aaab254)
2016-11-16 12:08:28 +00:00
Josh Perez 28e51005dc Shares debugID information across modules (#8097)
Prior to this, React was using a nextDebugID variable that was locally
scoped to both `instantiateReactComponent` and `ReactShallowRenderer`.
This caused problems when the debugIDs would collide, the `itemMap` in
`ReactComponentTreeHook` would be overwritten and tests would fail
with the message "Expected onBeforeMountComponent() parent and
onSetChildren() to be consistent".

This change shares the debugID with both modules thus preventing any
collisions in the future.
(cherry picked from commit 6eebed0535)
2016-11-16 12:07:24 +00:00
Ben Alpert fbe19e90b9 Fix captured/bubbled in ReactNativeTreeTraversal (#8019)
Follow-up to #7741. Added a test for RN event bubbling that fails before the fix.
(cherry picked from commit a8beab3341)
2016-11-16 12:06:55 +00:00