Commit Graph
8302 Commits
Author SHA1 Message Date
Dominic Gannaway ccfefc8a17 should fix fb and cjs bundles for ReactCurrentOwner 2017-03-10 13:51:28 +00:00
Dan Abramov c4dfd17c59 Change forwarding modules to import from -fb
This is another, more direct fix for ReactPerf circular dependency
2017-03-10 13:29:26 +00:00
Dan Abramov c20ceebec3 Rename -core suffix to -fb for clarity 2017-03-10 13:28:02 +00:00
Dan Abramov c9499d1457 Revert "Add a lazy shim for ReactPerf"
This reverts commit 723b402c07.
2017-03-10 13:27:03 +00:00
Dan Abramov 955b7e7ab4 Fix forwarding module for ReactCurrentOwner 2017-03-10 02:22:18 +00:00
Dan Abramov 723b402c07 Add a lazy shim for ReactPerf
This prevents a circular dependency between ReactGKJSModule and ReactDOM
2017-03-10 02:01:37 +00:00
Dan Abramov a09bed0b34 Use -core suffix for all bundles
This makes it easier to override things in www.
2017-03-09 23:14:26 +00:00
Dominic Gannaway 6114597a1f made ReactPerf and ReactTestUtils bundle again 2017-03-09 17:32:47 +00:00
Dominic Gannaway fdb6e237bf added comments to the module aliasing code 2017-03-09 16:45:02 +00:00
Dominic Gannaway 8ef3aa5d18 more forwarding modules 2017-03-09 15:53:23 +00:00
Dominic Gannaway 47fa99e4c1 improved how certain modules get inlined for fb and cjs 2017-03-09 15:29:24 +00:00
Dominic Gannaway ff0c87129f more progress on forwarding modules and FB config 2017-03-09 15:11:06 +00:00
Dominic Gannaway 690a72b870 adding forwarding modules 2017-03-08 18:49:56 +00:00
Dominic Gannaway 15b13cd99c builds a cjs bundle 2017-03-08 14:51:16 +00:00
Dominic Gannaway 238dcf743d More WIP 2017-03-07 19:34:46 +00:00
Dominic Gannaway d00cf558dc dev/prod mode WIP 2017-03-07 17:42:00 +00:00
Dominic Gannaway 3c24a4ca53 WIP 2017-03-07 16:52:53 +00:00
Dominic Gannaway 9d78fa8c1d fbjs support 2017-03-07 16:27:36 +00:00
Dominic Gannaway 30c8371cd5 WIP 2017-03-07 16:21:22 +00:00
Andrew Clark fc4633775a Remove destructuring, since the version of node on www doesn't support it 2017-03-02 16:44:04 -08:00
Andrew ClarkandGitHub cf4c06ceba Merge pull request #9098 from acdlite/printwarnings
Add script to print out a list of warnings
2017-03-02 16:39:43 -08:00
Sunny RipertandBrandon Dail 179240ca30 Fix spacing in documentation (#9070)
Replace non-breaking space by space.
2017-03-02 13:57:58 -06:00
Jason QuenseandBrandon Dail 2757a53fa5 Add fixture components (#8860)
* add fixture components

* add a few more options and styles

* Test fixture updates

- Pull in React from window global
- Add field to TestCase for fix PR links
- Update some styles

* Remove unused Fixture.Result comment

* Remove leading # from resolvedBy link

* Implement tag loading utility that caches response

Don't bust the cache doing feature detection

COME ON

* Use 'local' without version for option
2017-03-02 13:38:27 -06:00
Andrew Clark 9c8547cc9f Add script to print out a list of warnings
We'll use this in the GH sync script to track which warnings have
changed since the last sync
2017-03-02 11:37:01 -08:00
Vesa LaaksoandDan Abramov a190cfce29 Update Lifting State Up not to mix up DOM value with component state (#9032)
* Update Lifting State Up not to mix up DOM value with component state

A few weeks ago when teaching my friend, she got stuck on
`this.state.value` vs. `event.target.value`. As the documentation
talked a lot about "values", and the term value could mean three
different things (values in general, the "value" prop / DOM value of
the <input> component and the value in state/props), it was not weird
that she got a bit confused.

* Rename Lifting State Up onChange props to onTemperatureChange

This is in-line with how the temperature is provided as a prop named `temperature`

* Fix one value prop not being renamed to temperature

* Update codepen examples in Lifting state up documentation

* Update devtools state change to reflect docs change
2017-03-02 00:28:09 +00:00
Dan AbramovandGitHub c8f14c26b0 Add a step to the release process 2017-03-01 22:56:06 +00:00
Andrew ClarkandGitHub 5881371b61 Merge pull request #9087 from acdlite/fixstringcasting
Fix string casting and remove Flow suppression comments
2017-03-01 13:51:17 -08:00
Sasha AickinandBen Alpert 3788654d57 Adding some server rendering unit tests. (#9055)
* Added a handful of SSR unit tests, ported from a previous pull request.

* Fixing linting errors

* Fixed a test helper function to properly report errors.

* Un-nested the new rendering tests. Updated the fiber test passing/not passing lists.

* Edited to comply with the react/jsx-space-before-closing eslint rule, which will soon be merged into master.

* Response to code review from @spicyj. Moved tests to separate file, reworked wording of test names, corrected use of canUseDom, and simplified tests against tagName. Thanks for the help, @spicyj!
2017-03-01 13:39:47 -08:00
Andrew Clark 5e5bc69230 Fix string casting and remove Flow suppression comments 2017-03-01 13:07:22 -08:00
Andrew Clark d1ee199492 Fix usage of Boolean constructor 2017-03-01 12:30:32 -08:00
Bryan BraunandKevin Lacker 7a878d27e3 Replace the header_links plugin with client-side generated anchors. (#4165)
* Replace the header_links plugin with client-side generated anchors.

Fixes facebook/react#4124

* Move anchor-link code into a separate script

Also adds a couple comments, for context.
2017-03-01 11:52:54 -08:00
Andrew ClarkandAndrew Clark 737dac4f03 areChildrenOffscreen -> shouldDeprioritizeSubtree 2017-03-01 10:56:31 -08:00
Andrew ClarkandAndrew Clark a1cd77db6e Pass type to areChildrenOffscreen, too 2017-03-01 10:56:31 -08:00
Andrew ClarkandAndrew Clark 4602e768f3 Add areChildrenOffscreen to host config
Renderers can determine whether a node's children are offscreen based on
the host component's props. If so, they are given OffscreenPriority.

useSyncScheduling takes precedence.
2017-03-01 10:56:31 -08:00
Andrew ClarkandAndrew Clark 4ef197b7d4 Check if we're in sync mode before deprioritizing hidden subtrees 2017-03-01 10:56:31 -08:00
Andrew ClarkandAndrew Clark 81eef12507 Test that hidden subtrees render/update synchronously
When useSyncScheduling is set to true (as it is in the DOM renderer),
we shouldn't give OffscreenPriority to hidden subtrees. Everything
should be sync/task.
2017-03-01 10:56:31 -08:00
Andrew ClarkandGitHub 0585ee8b22 Merge pull request #9082 from acdlite/nobooleanorstringconstructors
Enforce no boolean or string constructors
2017-03-01 10:55:42 -08:00
Dominic GannawayandGitHub 18b86bc9d8 Merge pull request #9080 from trueadm/remove-stack-dependencies-from-tests
[Fiber] Remove stack dependencies from tests
2017-03-01 18:24:10 +00:00
Fokke ZandbergenandBrandon Dail 8eb7068364 Square renders button, not div (#9084) 2017-03-01 09:40:45 -06:00
Dominic GannawayandGitHub 8bc11649df Merge branch 'master' into remove-stack-dependencies-from-tests 2017-03-01 12:32:36 +00:00
Andrew Clark b963396c61 Run test script 2017-02-28 18:57:06 -08:00
Andrew Clark 7d5cc2eee3 Add test for no-primitive-constructors rule 2017-02-28 18:57:06 -08:00
Andrew Clark 2f63b0d6c9 Add error for number constructor, too 2017-02-28 18:57:06 -08:00
Andrew Clark b9c96cfc73 Add caveat about symbols to string error message 2017-02-28 18:57:06 -08:00
Andrew Clark 6ac5fd3c2b Rename rule to no-primitive-constructors 2017-02-28 18:57:06 -08:00
Andrew Clark 1e9812e31b Convert usage of String and Boolean constructors 2017-02-28 18:56:57 -08:00
Sebastian MarkbågeandGitHub e452e33741 providesModule -> explicit requires for cross-package dependencies (#9078)
* Add forwarding modules

* Codemod to use full package path outside of own package

Files that require modules from a different package than their own now
does so by the npm path name instead of the providesModule.

* Codemod fbjs module dependencies

* Fix gulp module mapping config

This is a bit lame but because of our module rewrite we need to white
list all the paths that we don't *don't* want to rewrite.
2017-02-28 18:42:52 -08:00
Andrew Clark 5f92d28e52 New ESLint rule that warns against Boolean and String constructors 2017-02-28 13:04:33 -08:00
Ben AlpertandGitHub a269e7ec3f Enable react/jsx-space-before-closing rule (#9077)
We mostly do this but not 100%; I fixed the stragglers here with `./node_modules/.bin/eslint --fix src` and enabled the lint rule.
2017-02-28 09:03:08 -08:00
Dominic Gannaway d2944bb5bf updates test-failing and tests-passing 2017-02-28 15:02:48 +00:00