Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,928 Commits 681 Branches 148 Tags
bb0fc28facaf4bb282a0ba98d7f366bd4840bbb0
Commit Graph
3928 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul O’Shannessy bb0fc28fac Fix PureRender test to use providesModule 2015-03-16 13:56:43 -07:00
Paul O’Shannessy b0a59a643a Merge pull request #3381 from zpao/jsx-nonstrictmodule 
Fix module option parsing of jsx command
 2015-03-16 13:24:35 -07:00
Paul O’Shannessy 4c9a07aad4 Merge pull request #3419 from xmo-odoo/patch-1 
Link to inserting raw HTML document
 2015-03-16 13:22:33 -07:00
Jim f3f1294589 Merge pull request #2842 from Acubed/master 
Generate XML-compatible void tags and boolean attributes
 2015-03-16 12:49:59 -07:00
Jim fb2999076c Merge pull request #3422 from jviereck/doc-typo-fix 
Fix small typo ("of" instead of "or")
 2015-03-16 11:03:06 -07:00
Julian Viereck c6108afdc7 Fix small typo 2015-03-16 18:27:04 +01:00
Paul O’Shannessy a9e787665d Merge pull request #3413 from zpao/travis 
Fix TravisCI fast bail check
 2015-03-16 09:28:45 -07:00
xmo-odoo f0c7b0c8ed Link to inserting raw HTML document 2015-03-16 10:51:20 +01:00
Austin Wright 29416f422e Appease eslint 2015-03-14 14:08:18 -07:00
Austin Wright b52bb22342 Move list of newline-eating tags to variable 2015-03-14 13:57:15 -07:00
Austin Wright 030a7b34c7 Add back \n-to-be-eaten for the plain-text elements 
The comment hack to enable polyglot HTML isn't cross-browser, or simply doesn't work.
 2015-03-14 13:53:12 -07:00
Austin Wright 8e714f9898 Update tests to use Polyglot profile of HTML 2015-03-14 13:53:12 -07:00
Austin Wright e913e85e1a Use a Polyglot HTML-safe method of escaping leading newline in rawtext elements 2015-03-14 13:53:12 -07:00
Austin Wright 8bc828aa7c Generate XML-compatible tags and boolean attributes 2015-03-14 13:53:12 -07:00
Paul O’Shannessy 08b1515f7f Update TravisCI to use exiting env var 
$TRAVIS_COMMIT_RANGE was broken but it seems what we're doing is worse and
resulting in false negatives.

The result of the bad range was that we weren't running lint or tests for
things we should have been. It actually looks like $TRAVIS_COMMIT has been
wrong and it's not clear why this has been working at all.
 2015-03-13 18:39:47 -07:00
Paul O’Shannessy 68a2f89cc6 Merge pull request #3402 from vkramskikh/fix-empty-selects-with-value 
Fix for empty <select> elements with value
 2015-03-13 18:04:57 -07:00
Ben Alpert ed257cb691 Merge pull request #3412 from spicyj/gh-3329 
Squash getDOMNode warning from isDOMComponent
 2015-03-13 17:55:02 -07:00
Ben Alpert 70985ba68d Squash getDOMNode warning from isDOMComponent 
Fixes #3329.
 2015-03-13 17:11:02 -07:00
Ben Alpert bcd70ad500 Merge pull request #3410 from robertknight/3409-style-null-to-nonnull 
Fix incorrect update of style when props.style transitions from null to non-null
 2015-03-13 17:07:01 -07:00
Robert Knight ee86942d77 Fix incorrect update of style when props.style transitions from null to non-null 
ReactDOMComponent maintains a copy of the previous style
object to support in-place mutations of props.style.

This cached object was not cleared when the style
property was removed in a props update.

Fixes #3409
 2015-03-13 22:16:19 +00:00
Vitaly Kramskikh 2f52d81865 Fix for empty <select> elements with value 
There is an exception when value or defaultValue is set but there are no
children as ReactDOMSelect tries to mark the first children as selected
even if there are no children.
 2015-03-13 21:48:02 +07:00
Paul O’Shannessy 228c00b813 Merge pull request #3397 from koba04/eslint-ignore-built-files 
ESLint ignores built files
 2015-03-12 18:25:42 -07:00
Toru Kobayashi ed0e242e07 ESLint ignores built files 2015-03-13 09:58:20 +09:00
Sebastian Markbåge ca8d7cba1b Merge pull request #3355 from cpojer/shallowCompare 
Add shallowCompare module and use it in PureRenderMixin + tests
 2015-03-12 17:45:22 -07:00
Paul O’Shannessy d19636295b Merge pull request #3394 from cody/getDOMNode 
Fix in docs: getDOMNode --> findDOMNode
 2015-03-12 14:12:23 -07:00
Stefan Dombrowski 84e6a392a3 Fix in docs: getDOMNode --> findDOMNode 2015-03-12 22:07:03 +01:00
Ben Alpert 1f72387a47 Merge pull request #3385 from RichardLitt/patch-2 
Nominalized 'shallow copy'
 2015-03-11 16:27:26 -07:00
Richard Littauer 00e89454ec Nominalized 'shallow copy' 
I mis-parsed 'shallow copies' as adjective noun, instead of as a compound verb. I've adjusted the text to make it easier to parse on the first read, which should also help ESL learners to be able to parse it easier.
 2015-03-11 16:22:24 -07:00
Paul O’Shannessy 78001d3abc jsx_orphaned_brackets_transformer v1.0.1 2015-03-11 15:52:54 -07:00
Paul O’Shannessy b459f2ff99 Merge pull request #3384 from syranide/npmjobt 
Fix jsx_orphaned_brackets_transformer using jstransformer with an older esprima version
 2015-03-11 15:51:38 -07:00
syranide 4485f6a439 Fix jsx_orphaned_brackets_transformer using jstransformer with an older esprima version 2015-03-11 23:48:05 +01:00
Ben Alpert f8672c7270 Fix grammar in warning message 2015-03-11 15:47:04 -07:00
Ben Alpert d9e06462a3 Merge pull request #3383 from ariabuckles/proptype-warnings 
[PropTypes] Add warnings if PropTypes return functions
 2015-03-11 15:46:17 -07:00
Aria Buckles 206e69c403 [PropTypes] Make invalid proptype warning clearer 
Addresses comments on #3383, making the invalid proptype specification
warning clearer and making the tests for it a bit clearer.
 2015-03-11 15:36:51 -07:00
Ben Alpert 098f316aff It\ns -> Its 2015-03-11 15:28:24 -07:00
Paul O’Shannessy adf4aee1b4 [docs] it's --> its 2015-03-11 15:25:57 -07:00
Aria Buckles d973e32336 [PropTypes] Add warnings if PropTypes return functions 
Summary:
Right now, if a component specifies a propType as, for example,
`myProp: React.PropTypes.shape`, without an actual shape
parameter, any prop type will be accepted, because
`React.PropTypes.shape` returns a function (the actual validator),
not an Error, currently indicating that propType checking passed.

This can create an unfortunate situation where a component looks
like it has fully specified `propTypes`, but in fact does not.

This commit addresses this by warning if a propType checker returns
anything non-falsy that is not an Error (currently all the library
PropTypes return null or an Error).

Test Plan:
Added a unit test; ran `jest` in the root repo directory.
Also ran `grunt lint` and `grunt test`
 2015-03-11 15:09:18 -07:00
Paul O’Shannessy c4a2e4d414 Fix module option parsing of jsx command 2015-03-11 14:26:51 -07:00
Jim 3d8b47bbcc Merge pull request #3356 from cpojer/findDOMNode 
foo.getDOMNode => React.findDOMNode(foo)
 2015-03-11 08:47:56 -07:00
Jim 5afa657d77 Merge pull request #3370 from varunrau/master 
Fixed shallowEqual for arguments that are not objects
 2015-03-11 08:34:49 -07:00
Varun Rau 6cd004f20a Fixed shallowEqual implementation to handle the case when inputs are not objects. 
If either argument is not an object and unequal, then shallowEqual should return false.
If only one argument is an object, then shallowEqual should return false.

Fixes #3369
 2015-03-10 18:03:51 -07:00
cpojer 413e96d0cd Add some important getDOMNode tests back. 2015-03-10 17:27:19 -07:00
cpojer ae7da3aadd foo.getDOMNode => React.findDOMNode(foo) 2015-03-10 17:17:21 -07:00
Jim 91b45641b8 Merge pull request #3317 from ianobermiller/fix-shallow-equal 
shallowEqual: bail if either argument is falsey
 2015-03-10 15:45:03 -07:00
Ben Alpert 53f92bf858 Fix comma splice and line length 2015-03-10 15:36:27 -07:00
Jim 645a6caaf5 Merge pull request #3323 from jonhester/ie8-compat-mode 
warn if IE8 is in compatibility mode
 2015-03-10 15:35:09 -07:00
Ben Alpert 462e8f1be8 Merge pull request #3327 from Simek/initialize-variables-fix 
initialize dev variables in dev mode only in shouldUpdateReactComponent.js
 2015-03-10 15:33:29 -07:00
Ben Alpert cff3f35bf7 Merge pull request #3321 from Smert/master 
Bringing the code to one style.
 2015-03-10 15:32:43 -07:00
Ben Alpert 4d9561d938 Merge pull request #3310 from darcyadams/console-exists-before-warn 
Check that console exists before warning
 2015-03-10 15:32:32 -07:00
Ben Alpert b95fe57743 Merge pull request #3253 from jsfb/fix-comment-to-reflect-class-type-usage 
Fix comment to reflect the new (non-deprecated) way of accessing a class type.
 2015-03-10 15:31:50 -07:00