mzabriskie
ae5a124745
Using %s in warning message
2015-01-26 18:09:21 -07:00
mzabriskie
fca0fdc115
Better tests
2015-01-26 18:08:51 -07:00
mzabriskie
b6edbae3fc
Renaming assertValidStyle to warnValidStyle
2015-01-26 17:50:35 -07:00
mzabriskie
94fb463c06
Moar tests
2015-01-26 17:45:51 -07:00
mzabriskie
05e2bc6b5c
Fixing lint failures
2015-01-26 17:41:54 -07:00
mzabriskie
4054bb13cd
Provide warning when using styles containing a semicolon
2015-01-26 17:33:44 -07:00
Sebastian Markbåge
4486a17c24
Merge pull request #2933 from sebmarkbage/pendingcontext
...
Remove _pendingContext
2015-01-24 21:54:36 -08:00
Sebastian Markbage
adabfe2f49
Remove _pendingContext
...
There is no way to queue an update to a context so there is no need for
this field. The only way to get a new context is from above.
Soon _pendingElement will get the same treatment. Once _setPropsInternal
can be removed.
2015-01-24 20:09:14 -08:00
Sebastian Markbåge
1c90efbf7c
Merge pull request #2923 from sebmarkbage/dropcomponentmixin
...
Replace ReactComponentMixin with ReactReconciler
2015-01-23 18:06:50 -08:00
Sebastian Markbage
690409a912
Replace ReactComponentMixin with ReactReconciler
...
Instead of putting the shared code in a base class method, we use a wrapper
call around all invokations. That way they're free to add code before AND
after the non-shared code.
That way we ensure that component extensions don't need to implement
ReactComponentMixin and do super() calls into it. This helps to create a
tighter API for custom component extensions.
This provides the first step towards moving these methods to static
methods which allows to use a different dispatch mechanism instead of
virtual method calls. E.g. pattern matching.
2015-01-23 17:27:42 -08:00
Ben Alpert
ac7677bb11
Update .mailmap for me
2015-01-23 11:10:22 -08:00
Sebastian Markbåge
0e108b180a
Merge pull request #2918 from sebmarkbage/fixcontexts
...
Move Component Class Instantiation into ReactCompositeComponent
2015-01-23 10:41:47 -08:00
Sebastian Markbage
9abd1133c9
Pass context to the constructor
...
This should reenable reading this.context from getInitialState.
Added a bunch of tests for this too.
2015-01-23 10:09:45 -08:00
Sebastian Markbage
766a79c695
Move component class instantiation into ReactCompositeComponent
...
We need to move instantiation into the mount phase for context purposes.
To do this I moved the shallow rendering stuff into ReactTestUtils and
reused more of the existing code for it by instantiating a noop child.
Everywhere we refer to the "type" we should pass it to ReactNativeComponent
to resolve any string value into the underlying composite.
2015-01-23 10:09:45 -08:00
Sebastian Markbåge
8616a6f60e
Merge pull request #2919 from sebmarkbage/removecreateref
...
Remove React.createRef API
2015-01-22 19:13:55 -08:00
Sebastian Markbage
a3a464c8fc
Remove React.createRef API
...
This API was removed so this won't work.
2015-01-22 19:11:11 -08:00
Ben Alpert
f9821de909
Merge pull request #2917 from spicyj/ref-composite
...
Switch first-class refs to use functions
2015-01-22 18:19:05 -08:00
Ben Alpert
322bde6eb0
Switch first-class refs to use functions
...
Closes #1373 .
Test Plan: jest
2015-01-22 18:10:25 -08:00
Jim
734aedb977
Merge pull request #2892 from jsfb/fbme-url-for-dangerouslySetInnerHtml
...
Added fb.me url to error message.
2015-01-22 17:07:28 -08:00
Ben Alpert
a534264c1e
Merge pull request #2916 from spicyj/ref-composite
...
Move ref code to ReactCompositeComponent
2015-01-22 16:01:51 -08:00
Ben Alpert
9c3d6b8881
Move ref code to ReactCompositeComponent
...
You can only get a ref to a ReactCompositeComponent, so move the ref code here which gives us more flexibility to put it at the correct time in the lifecycle.
There should be no behavior change in this commit.
Test Plan: jest
2015-01-22 15:36:59 -08:00
Paul O’Shannessy
3d109aa11b
Merge pull request #2915 from zpao/lint-fixup
...
Fix a couple small lint issues
2015-01-22 14:56:25 -08:00
Paul O’Shannessy
c33d443c0b
Fix a couple small lint issues
...
These aren't caught by eslint yet :(
2015-01-22 14:39:08 -08:00
Sebastian Markbåge
8a5c5ba69d
Merge pull request #2913 from sebmarkbage/typewarning
...
Add warning when accessing .type on a component class
2015-01-22 13:39:07 -08:00
Sebastian Markbage
1ed1d7a158
Add warning when accessing .type on a component class
...
Since we removed the wrapper factory around classes, the class is just
the class now so there is no need for this indirection property.
2015-01-22 13:26:34 -08:00
Paul O’Shannessy
6588a84a0f
Merge pull request #2765 from zpao/jsxtransformerlinenumber
...
Check for lineNumber support before using it
2015-01-22 12:58:51 -08:00
Jim
b94adc9724
Added fb.me url to error message.
2015-01-22 12:56:52 -08:00
Paul O’Shannessy
f8a214137a
Merge pull request #2903 from tendant/merge-conflicts-in-translation
...
Update documents for Chinese translation
2015-01-22 12:55:53 -08:00
Paul O’Shannessy
92e361709c
[docs] Use current date in copyright footer
...
This will be based on the site generation time, making doc generation
slightly less deterministic but that's ok. Now we won't depend on
helpful community members updating it for us (#2874 ) when we forget,
it'll just happen naturally the next time the site is generated.
2015-01-22 12:50:52 -08:00
Jim
54b565de93
Merge pull request #2518 from jsfb/documentation-for-dangerouslySetInnerHtml
...
Document justification for dangerouslySetInnerHTML, fixes #2256
2015-01-22 10:52:47 -08:00
Ben Alpert
76e1d5a542
Merge pull request #2902 from swestwood/patch-2
...
Correctly highlight changed line in tutorial.
2015-01-22 08:27:29 -08:00
Lei
943c2aa77a
Add Chinese translation of reusable-components
2015-01-21 19:43:24 -08:00
Lei
833fcb6593
Add Chinese translation of multiple-components
2015-01-21 19:34:40 -08:00
Paul O’Shannessy
6247f30103
Merge pull request #2890 from amykyta/patch-1
...
Update 02.1-jsx-in-depth.md
2015-01-21 19:07:01 -08:00
Timothy Yung
b403af192d
Merge pull request #2900 from wincent/test-desc-fix
...
Fix inaccurate spec description
2015-01-21 18:56:33 -08:00
Paul O’Shannessy
4b2e89dd99
Add npm run build
...
It's a "shortcut" to `grunt build`
2015-01-21 17:23:36 -08:00
Sophia Westwood
a19966f2ea
Correctly highlight changed line in tutorial.
...
This excerpt adds the onSubmit handler to the form element, but the line was not highlighted as having been modified.
2015-01-21 17:15:31 -08:00
Greg Hurrell
76fe572a97
Fix inaccurate spec description
...
The string here was initially accurate, but got out of sync with reality
when the commit was revised (as 892e357fd5 ).
2015-01-21 17:07:29 -08:00
Timothy Yung
892e357fd5
Merge pull request #2894 from yungsters/local-event-trap-mixin
...
Fix LocalEventTrapMixin for Bad Tree State
2015-01-21 15:34:32 -08:00
yungsters
a7aca51f1e
Throw for Misue of LocalEventTrapMixin
...
Summary:
If `getDOMNode()` returns null in `LocalEventTrapMixin`, `listener` will also be null and `accumulateInto` will throw. This changes `LocalEventTrapMixin` to throw a more helpful error message.
Test Plan:
Ran unit test successfully:
```
npm test LocalEventTrapMixin-test.js
```
2015-01-21 15:30:04 -08:00
Jim
6f44f6049e
Document justification for dangerouslySetInnerHTML, fixes #2256
...
Conflicts:
docs/_data/nav_tips.yml
docs/tips/17-children-undefined.md
2015-01-21 12:47:36 -08:00
Isaac Salier-Hellendag
972befe0b6
Merge pull request #2889 from salier/react-default-perf
...
Repair ReactDefaultPerf
2015-01-21 13:28:53 -06:00
amykyta
b8f3c7f7fb
Update 02.1-jsx-in-depth.md
2015-01-21 12:22:29 -05:00
Isaac Salier-Hellendag
de54d84051
Repair ReactDefaultPerf
...
Update ReactDefaultPerf to properly record component names.
2015-01-21 10:52:43 -06:00
Paul O’Shannessy
ce5346f2ce
Merge pull request #2884 from chenglou/fix-ex-source-map
...
Temporarily comment out bundle-collapser for JSXTransformer
2015-01-20 18:55:39 -08:00
Paul O’Shannessy
f9c393f4fb
Fix strict mode violoation in test
2015-01-20 18:26:51 -08:00
Cheng Lou
51d74ca36c
Temporarily comment out bundle-collapser for JSXTransformer
...
This will at least make the examples run while we fix the issue.
2015-01-20 20:27:59 -05:00
Paul O’Shannessy
06de3f31f0
Merge pull request #2875 from kchia/patch-2
...
Update 03-interactivity-and-dynamic-uis.md: correct typo
2015-01-20 16:42:27 -08:00
Paul O’Shannessy
0a62a04909
Merge pull request #2881 from camsong/master
...
Add Chinese translation to several pages.
2015-01-20 16:41:58 -08:00
Sebastian Markbage
a5657d213c
Fix lint
2015-01-20 14:40:19 -08:00