Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,113 Commits 681 Branches 148 Tags
ad133f5b3dbf01331f819f3000ab52097bf7d598
Commit Graph
8113 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Diego Muracciole ad133f5b3d Add onToggle event to details tag (#8831) 
* Add onToggle event to details tag

Fixes #8761

* Map onToggle event on ReactDOMFiberComponent

* Tweak doc

* Trap events on setInitialProperties for details tag
 2017-02-03 10:25:09 +00:00
Andrew Clark 269555e35c Merge pull request #8921 from facebook/revert-8907-fiberproderrorcode 
Revert "Loosen assertion so it matches any production error"
 2017-02-02 15:24:04 -08:00
Andrew Clark bd3070f774 Revert change to test 
See: https://github.com/facebook/react/pull/8907#issuecomment-277111278
 2017-02-02 15:22:28 -08:00
Andrew Clark 57d2d6d77d Merge pull request #8907 from acdlite/fiberproderrorcode 
Loosen assertion so it matches any production error
 2017-02-02 14:42:23 -08:00
Dan Abramov 7e8068b984 Move component base classes into a single file (#8918) 2017-02-02 20:24:39 +00:00
Andrew Clark ea2aa6e613 Fix messages so that they use the same template as Stack 
The production error code system depends on the exact template string
that is passed to `invariant`. This changes the Fiber templates to
match the Stack ones.
 2017-02-02 12:05:00 -08:00
Andrew Clark 02edc6bf18 Loosen assertion so it matches any production error 
The exact error code isn't important.
 2017-02-02 11:17:56 -08:00
Pontus Abrahamsson 55a18bca64 Update conferences.md (#8915) 
* Update conferences.md

* Move confs around
 2017-02-02 13:37:27 +00:00
Omid Hezaveh 79be3543dd Explain arbitrariness of ref name in callback (#8913) 
* Explain arbitrariness of ref name in callback 

The sample code was confusing because it's not clear that "textInput" in this.textInput is an arbitrary name for the ref.

* Tweak wording
 2017-02-02 13:33:12 +00:00
Dan Abramov 9e3a31b2c6 Fix indentation in tutorial (#8914) 2017-02-02 13:24:26 +00:00
Eduard dc04ee87ae Update tutorial.md (#8896) 
* Update tutorial.md

The status <div> used in Board can be deleted as well from render.

* Little tweaks
 2017-02-01 18:12:00 -08:00
Tiago Fernandez 05f5bf6eb6 Link to CodePen editor rather than final result (#8849) 
People want to see the final JS/CSS/HTML, and the final result is already displayed by CodePen.
 2017-02-01 18:02:44 -08:00
Jeffrey Wan 3f5482ee20 Update tutorial.md (#8792) 
* Update tutorial.md

* Fix quoting to be consistent
 2017-02-01 17:42:19 -08:00
John Longanecker b8f0522cc6 Lifting State Up more legible (#8691) 2017-02-01 17:31:01 -08:00
Andrew Clark 86fbb9d583 Merge pull request #8905 from acdlite/fiberfinddomnodeunmount 
[Fiber] findDOMNode during componentWillUnmount
 2017-01-31 16:05:05 -08:00
Andrew Clark c158ff6179 Merge pull request #8908 from acdlite/fiberemptycomponent 
[Fiber] Fix formatting of invalid element invariant
 2017-01-31 16:03:54 -08:00
Andrew Clark 2afcf6e09f Fix formatting of invalid element invariant 
Message is slightly different for functional and class components.
 2017-01-31 15:29:53 -08:00
Andrew Clark 6545012af2 Merge pull request #8893 from gaearon/fix-dom-prod-test 
Add process.cwd to the test process shim
 2017-01-31 15:04:39 -08:00
Andrew Clark 10e5438422 Merge pull request #8906 from acdlite/warningnewline 
Add missing newline to warning
 2017-01-31 14:42:21 -08:00
Andrew Clark 6846ef9fb8 Add newline to warning 2017-01-31 14:41:14 -08:00
Andrew Clark af7ae1be91 Don't swap the trees until after the first pass of the commit phase, 
where componentWillUnmount is called, but before the second pass,
where componentDidMount/Update is called.
 2017-01-31 14:39:52 -08:00
Andrew Clark 35ddd05da4 Merge pull request #8890 from acdlite/fiberfragmentinvariants 
[Fiber] Throw on plain object children
 2017-01-31 13:14:11 -08:00
Andrew Clark 73d27d755e Merge pull request #8897 from acdlite/fiberfixfinddomnode 
[Fiber] Fix findDOMNode algorithm
 2017-01-31 13:13:56 -08:00
Andrew Clark 2a0fb5b4aa Remove legacy React element warning 2017-01-31 11:46:30 -08:00
Andrew Clark 17ec96b014 Run test script 2017-01-31 11:44:35 -08:00
Andrew Clark 7daa90206d Add missing portal case to updateSlot switch statement 2017-01-31 11:44:35 -08:00
Andrew Clark 7af673afc1 Allow object as textarea child 
Preserves Stack behavior. There's already a warning for this.
 2017-01-31 11:44:35 -08:00
Andrew Clark 802c820545 Fallback to owner of returnFiber 
Won't work if the returnFiber is a fragment. Not sure it matters;
warning will just be less descriptive.
 2017-01-31 11:44:35 -08:00
Andrew Clark 3089db94ce Throw on invalid object type children 
Same behavior as Stack
 2017-01-31 11:44:30 -08:00
Andrew Clark ba5b9c0af3 Add invariant 
Defensive coding to prevent an infinite loop.
 2017-01-31 11:35:10 -08:00
Dan Abramov ea9e1575b7 Suppress lint warnings 
Using [] is intentional because we don't want to trigger Babel plugin.
 2017-01-31 19:30:26 +00:00
Andrew Clark 97f6786cba Fix findDOMNode algorithm 2017-01-31 10:24:03 -08:00
Dan Abramov d6d129a1b2 Reassign process.env.NODE_ENV instead of shimming process 2017-01-31 16:28:20 +00:00
Marius Skaar Ludvigsen d8450845fe #6049 add support for onCancel and onClose event (#6247) 2017-01-31 08:10:48 -06:00
Richie Thomas 469e68542b Added double newline delimiters to the following functions/files: (#8777) 
* 'beginLifeCycleTimer' function of ReactDebugTool.js
            * 'bindAutoBindMethod' function of ReactClass.js
            * 'warnNoop' function of ReactServerUpdateQueue.js
            * 'getInternalInstanceReadyForUpdate' function of ReactUpdateQueue.js
            * 'warnNoop' function of ReactNoopUpdateQueue.js
            * 'getDeclarationErrorAddendum' function of ReactDOMComponent.js
            * 'getSourceInfoErrorAddendum' function of ReactElementValidator.js
            * 'getDeclarationErrorAddendum' function of instantiateReactComponent.js and ReactElementValidator.js
            * 'traverseAllChildrenImpl' function of traverseAllChildren.js
            * 'attachRef' function of ReactRef.js
            * 'mountIndeterminateComponent' function of ReactFiberBeginWork.js
            * 'createFiberFromElementType' function of ReactFiber.js
            * 'getDeclarationErrorAddendum' function of ReactDOMSelect.js
            * 'unmountComponentAtNode' function of ReactMount.js
            * 'getDeclarationErrorAddendum' function of ReactControlledValuePropTypes.js
            * 'checkRenderMessage' function of CSSPropertyOperations.js
            * 'getDeclarationErrorAddendum' function of ReactDomFiberSelect.js
            * 'getCurrentComponentErrorInfo' function in 'ReactElementValidator'
            * 'getDeclarationErrorAddendum' function in ReactDOMFiberComponent.js
 2017-01-31 07:41:24 -06:00
Vladimir Kovpak 8bc5a87d04 Added undefined example (#8899) 
Into section `Booleans, Null, and Undefined Are Ignored` I've added example with undefined.
 2017-01-31 07:24:29 -06:00
Ben Alpert 64a47e9fb4 Don't crash Fiber with old devtools (#8900) 
Typo.
 2017-01-31 13:06:53 +00:00
Roman Liutikov 59aac010dd refer to object by name instead of function call context (#8892) 2017-01-30 18:32:26 -06:00
Senin Roman 466bb4ffb9 Fix incorrect markup for ie10 (#8886) 2017-01-30 18:32:07 -06:00
Dan Abramov 3195bcdbcb Add process.cwd to the test process shim 2017-01-30 21:48:05 +00:00
Maksim Shastsel ec936dd848 Delete @nosideeffect annotation (#8882) 2017-01-30 21:42:17 +00:00
Dan Abramov fb4c08baee Fix lint (#8888) 2017-01-30 17:46:07 +00:00
MICHAEL JACKSON 564fa64626 Update context example for react-router v4 beta (#8889) 
* Update context example for react-router@4.0.0-beta.1

* Style nits
 2017-01-30 17:36:47 +00:00
Dan Abramov d8491ca73f Declare __REACT_DEVTOOLS_GLOBAL_HOOK__ for Flow (#8884) 2017-01-30 14:14:30 +00:00
Zac Braddy cae2a6f9d3 Got rid of linting errors on windows machines and a number of linting warnings. (#8846) 2017-01-28 15:36:03 -08:00
Frank Yan 751d221172 Fix typo in EventPropagators.js (#8879) 2017-01-27 18:36:21 -06:00
Dan Abramov d3e29d4e54 [Fiber] Support React DevTools (#8818) 
* Initial React DevTools support for Fiber

* Record a newly failing irrelevant test

This is fine because we don't use it in Stack anyway (at least not that part), and we also rely on Set/Map in other parts of code.
The newly failing test is the one saying "it works without Map/Set".

* Explicitly check for Fiber DevTools support

This lets us ignore pre-Fiber DevTools instead of crashing them by injecting a different API.

* Track the roots in DevTools instead

* Lol Dan this is not how warnings work in our codebase

* Move injection to the renderer

* Notify DevTools about unmounts

* Make it work in production

* Fix lint and flow

* Fixups

* Address feedback
 2017-01-27 22:50:35 +00:00
Paul O’Shannessy 3c75593692 [examples] Use react-standalone (#7669) 
[examples] Use babel-standalone
 2017-01-26 11:57:01 -06:00
Sebastian Markbåge b26265718a Merge pull request #8840 from sebmarkbage/statelesscoroutines 
[Fiber] Simplify coroutines by making yields stateless
 2017-01-26 07:15:36 -08:00
Mitchel Humpherys 39472f1c3e installation.md: Add missing "as" (#8871) 2017-01-25 23:33:49 -06:00