Facebook/react
1
0 Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,349 Commits 681 Branches 148 Tags
8e2dcceee376ae426cffa762cd873c92e61bb4a0
Commit Graph
2349 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ben Alpert 8e2dcceee3 Merge pull request #1597 from spicyj/defaultprops-autobind 
Auto-bind before getDefaultProps
 2014-06-11 10:14:31 -07:00
Ben Alpert 927eb570b9 Merge pull request #1631 from dblandin/master 
Update link to @petehunt's react-server-rendering GitHub repo
 2014-06-10 13:53:37 -07:00
Ben Alpert e1e2fbdcf7 Merge pull request #1636 from harshadsabne/master 
Update 2014-03-21-react-v0.10.md
 2014-06-10 13:45:46 -07:00
Ben Alpert 2f61996ec3 [docs] Point to renderComponent over setProps 2014-06-08 13:04:40 -07:00
cpojer eebcf9f888 Fix ExecutionEnvironment.canUseDOM for IE8. 2014-06-05 12:44:24 -07:00
Christoph Pojer 41ed67d222 Merge pull request #1638 from spicyj/getmodifierstate-2 
Fix getEventModifierState, no allocations
 2014-06-03 14:36:16 -07:00
Ben Alpert e501238c10 Fix getEventModifierState, no allocations 
Alternative to #1637 that doesn't allocate on every event.

Test Plan: Crossed fingers.
 2014-06-03 14:35:29 -07:00
Harshad Sabne 7172b1d5da Update 2014-03-21-react-v0.10.md 
Fix link to React v0.10 RC
 2014-06-03 21:35:49 +05:30
Pete Hunt 87bcbff218 Merge pull request #1632 from spicyj/img-load-error 
Fix onLoad and onError on images
 2014-05-30 17:04:41 -07:00
Ben Alpert 3e34739cb9 Fix onLoad and onError on images 
Fixes bug introduced in c62c2c5.

Test Plan: Tested that the onLoad event was properly triggered on an image. Didn't test onError but I can only assume that it works equally well.
 2014-05-30 16:53:46 -07:00
Devon Blandin d8a2f12498 Update link to @petehunt's react-server-rendering GitHub repo 2014-05-30 14:14:18 -05:00
Cheng Lou 6ce193614c Merge pull request #1627 from Enome/master 
Typo: ClosureScript -> ClojureScript in latest blog post
 2014-05-29 16:20:42 -04:00
enome b72d9f3aab Typo: ClosureScript -> ClojureScript 2014-05-29 22:10:15 +02:00
Ben Alpert 5a856c769d Merge pull request #1614 from chenglou/1-year 
[Blog] One-year anniversary post
 2014-05-29 11:41:51 -07:00
Cheng Lou c5f690a7c7 [Blog] One-year anniversary post 2014-05-29 14:39:59 -04:00
Ben Alpert 8d8dd4d336 Merge pull request #1620 from kmeht/jestDoc 
Reference Jest in TestUtils documentation.
 2014-05-28 23:53:37 -07:00
Kunal Mehta 055275b833 Reference Jest in TestUtils documentation. 2014-05-28 23:51:22 -07:00
Ben Alpert 3297909545 [docs] Fix grammar 2014-05-28 23:31:02 -07:00
Fred Zhao 50516585a4 Update findComponentRoot and processUpdates warnings for SVG 
I ran into a really difficult-to-debug issue with a React app with SVG
elements. Christopher sat down with me for a while and we finally figured out
that the browser was moving non-SVG elements out of a parent `<svg>` node which
triggered the `processUpdates()` invariant. This updates the error message
thrown from there to include this scenario in the possible issues list.
 2014-05-28 18:19:49 -07:00
Paul O’Shannessy 6c7abd36dd Sync upstream modules 
crateObjectFrom is no longer used (was used in ReactPropTypes). Others are small changes.
 2014-05-28 15:13:02 -07:00
Ben Alpert 2e3cf459ba Fix tutorial to have exact translation of example 
Fixes #903.
 2014-05-28 10:29:34 -07:00
Paul O’Shannessy 0ad8cfad1a Merge pull request #1590 from spicyj/svg-classname 
Handle className properly on SVG nodes
 2014-05-28 10:14:59 -07:00
Paul O’Shannessy f230e0a031 Merge pull request #1583 from nhunzaker/jsxtransform-parallel 
Load external scripts in parallel in JSXTransformer
 2014-05-27 14:31:25 -07:00
Timothy Yung bca1f0e352 Merge pull request #1536 from spicyj/gh-1169 
Attach empty onclick listener to each node
 2014-05-27 16:44:08 -04:00
Ben Alpert e096000bb5 Attach empty onclick listener to each node 
Fixes #1169.

This is a more robust way of fixing what MobileSafariClickPlugin previously tried to. Now even if you don't want anything to do with touch events, click events still work properly.

Test Plan: Added a click handler to an `<img />` element and triggered it in the iOS simulator -- it didn't execute before.
 2014-05-27 13:40:17 -07:00
Paul O’Shannessy fa6fe54432 Merge pull request #1596 from mindeavor/patch-1 
Fix typo in Flux TodoMVC Tutorial
 2014-05-27 11:07:09 -07:00
Tom Haggie cd3ba59cf1 Updated the ajax to tip to also mention that you need to check 
that the component is still mounted before updating it's state.

Closes #1600.
 2014-05-26 20:29:48 -07:00
Ben Alpert 03df8d7de0 Ignore built todomvc-flux bundles 2014-05-26 20:27:48 -07:00
Ben Alpert f761f770e1 Don't load todomvc-common/base.js 
Fixes #1603.

It's unnecessary and makes a request to learn.json which doesn't exist.
 2014-05-26 20:19:16 -07:00
Ben Alpert db4a90a9ef Capitalize README for consistency 2014-05-26 20:14:54 -07:00
Ben Alpert 8a460ba2e8 Auto-bind before getDefaultProps 
Fixes #1595.
 2014-05-25 00:40:39 -07:00
Gilbert 330fa30141 Fix typo in Flux TodoMVC Tutorial 
A sentence says "only handles one actionType" when the example code instead handles two.
 2014-05-25 00:21:31 -05:00
Ben Alpert e1457a14fd Run all tests, fix indentation 2014-05-23 23:03:13 -07:00
Ben Alpert 1e268c3591 Merge pull request #1556 from joshma/flux-dispatcher-docs 
Update Flux Dispatcher.dispatch and waitFor examples
 2014-05-23 23:01:25 -07:00
Ben Alpert 3e30940bf3 Bump to React 0.10 in TodoMVC Flux 2014-05-23 16:09:47 -07:00
Paul O'Shannessy 7a9b81ef55 remove spurios module ref 
long long ago in a galaxy far away this was probably a dependency
 2014-05-23 15:35:22 -07:00
Joshua Ma 7954a861d1 Add more complicated fourth listener to AppDispatcher-test 2014-05-23 12:42:09 -07:00
Joshua Ma a616742fce Configure todomvc-flux npm test to use jest 2014-05-23 12:36:38 -07:00
Joshua Ma f8d0291874 Fix doc typo and remove underscore from local var 2014-05-23 12:34:40 -07:00
Paul O'Shannessy c62c2c59bb Remove event listeners from native dom wrapper components 
Not removing them resulted in leaks as we would hold on to removed nodes forever.

This really showed up with images and the load event where we would unmount and create a new img with the same react id as the old one. We properly cleared and primed the caches but we would handle the load event for both nodes. We would eventually hit an invariant in that path as we tried to handle the event for the removed node, which no longer matched the node we had in the cache.

By forcefully removing the listener, we'll avoid this problem entirely and we should leak fewer DOM nodes.
 2014-05-23 11:30:19 -07:00
Ben Alpert 37f61c479e Handle className properly on SVG nodes 
This strategy avoids a runtime check for every set (as opposed to using a mutation method).

Test Plan: Verify that changing className works on a div and a rect in latest Chrome, latest Firefox, IE9. Verify that the div works in IE8.
 2014-05-22 20:31:04 -07:00
Ben Alpert e60a893d2f Bump esprima-fb and jstransform versions 
Fixes #1584, fixes #1475.
 2014-05-22 20:16:37 -07:00
Jeff Morrison 9ef6156d5c Merge pull request #760 from syranide/jsxns 
Support for JSX tag namespaces <React:DOM:div />
 2014-05-22 15:51:49 -07:00
Paul O’Shannessy f9ad17db65 Merge pull request #1363 from spicyj/batch-all 
Batch subupdates caused by any state update
 2014-05-22 15:28:48 -07:00
Ben Alpert 49652c8e20 Merge pull request #1575 from spicyj/dispatch-index 
Make promise selection logic clearer
 2014-05-21 15:39:53 -07:00
Paul O’Shannessy cccdc54b68 Merge pull request #1576 from spicyj/ex-shim 
Add shims to examples
 2014-05-21 15:16:51 -07:00
Ian Obermiller bf5dfc87dc Error in extractEvents 
If the event is on the window object, topScroll, for instance, the topLevelTarget will not have getAttribute defined. Restore the previous `|| !topLevelTarget.attributes` check to avoid an error on every scroll.
 2014-05-21 15:12:26 -07:00
Ben Alpert 696e556eae Merge pull request #1579 from gscottolson/master 
Improve readability of multi-line nav items.
 2014-05-21 12:30:28 -07:00
G Scott Olson c9bac95034 Fix nested UL spacing. 2014-05-21 15:26:01 -04:00
Nate Hunzaker 59a9251c90 Set executed after run 2014-05-21 15:09:52 -04:00